From patchwork Wed Jan 23 04:26:08 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anup Patel X-Patchwork-Id: 1029654 X-Patchwork-Delegate: uboot@andestech.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=wdc.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=wdc.com header.i=@wdc.com header.b="nbf6TAdL"; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=sharedspace.onmicrosoft.com header.i=@sharedspace.onmicrosoft.com header.b="UjZ5BBBE"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 43ksqx1lNBz9s3l for ; Wed, 23 Jan 2019 15:34:05 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id F2CB3C21D4A; Wed, 23 Jan 2019 04:31:37 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=KHOP_BIG_TO_CC, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 278C1C21E02; Wed, 23 Jan 2019 04:27:06 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 798A4C21DEC; Wed, 23 Jan 2019 04:27:04 +0000 (UTC) Received: from esa1.hgst.iphmx.com (esa1.hgst.iphmx.com [68.232.141.245]) by lists.denx.de (Postfix) with ESMTPS id 7B0AEC21DB6 for ; Wed, 23 Jan 2019 04:26:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1548217571; x=1579753571; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=AGopGUiXazjgN5ZuY1nzw0BAbdwpOrkv1RV7FfRgwcQ=; b=nbf6TAdLi+DgX2iGldca9g20Wwt75pl3sL0yfoMMa+3lKlIOMKQbMrCL D4W616mp1FQHqCjP2YdKVWQmfBuJYS7FIJBhboVo073Obqz5UnyorjGol gy7cxW47zdFxfBlx4a++Wh7cjzqahfGop61O6GC4tKXXmqZtmkOKlINbb LUq2zg2pWiObS878LMcyhs7/XYEWLrMjr72+HxVepzU5MSayQXwhO0zMi lfAJbBssBv9PZZabwLLLjKPKzEg2hixhcV3Rg+oFmr+2WHnzqW8KjqonS kYTaCc2Dqu6xhOEjNusa/6oE5Qoyiw2qaG0wChrHEB0eMWhwmllbIyIyp A==; X-IronPort-AV: E=Sophos;i="5.56,509,1539619200"; d="scan'208";a="204536028" Received: from mail-co1nam05lp2051.outbound.protection.outlook.com (HELO NAM05-CO1-obe.outbound.protection.outlook.com) ([104.47.48.51]) by ob1.hgst.iphmx.com with ESMTP; 23 Jan 2019 12:26:10 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector1-wdc-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u0pk+m+saWEBpumb8AcuizP7KdgAEiXUxCJ16WAWEek=; b=UjZ5BBBElEyyjkQHZuD8f/ln2kyYz7OZX59QrvaOHYAUFDuk1C/P+zygMvH53/NSX8lNAhWD7qJWFejguq83ELy/J/XLeF02F0UoU0drbQOT1u2cCjDuidH4KlrfiNVOpobo8SZBRT2uiT8nvSYXDHNMdczr3ymf857z5QKfDR4= Received: from BYAPR04MB5303.namprd04.prod.outlook.com (20.178.49.148) by BYAPR04MB4566.namprd04.prod.outlook.com (52.135.238.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1537.27; Wed, 23 Jan 2019 04:26:08 +0000 Received: from BYAPR04MB5303.namprd04.prod.outlook.com ([fe80::add1:92cc:65d7:5d94]) by BYAPR04MB5303.namprd04.prod.outlook.com ([fe80::add1:92cc:65d7:5d94%2]) with mapi id 15.20.1537.031; Wed, 23 Jan 2019 04:26:08 +0000 From: Anup Patel To: Rick Chen , Bin Meng , Joe Hershberger , Michal Simek , Michal Simek , Lukas Auer , Masahiro Yamada , Simon Glass Thread-Topic: [PATCH v3 09/12] drivers: serial_sifive: Skip baudrate config if no input clock Thread-Index: AQHUstPD4V6gqRfDkUuieMUSHkuUcw== Date: Wed, 23 Jan 2019 04:26:08 +0000 Message-ID: <20190123042442.106038-10-anup.patel@wdc.com> References: <20190123042442.106038-1-anup.patel@wdc.com> In-Reply-To: <20190123042442.106038-1-anup.patel@wdc.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: MAXPR0101CA0055.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:e::17) To BYAPR04MB5303.namprd04.prod.outlook.com (2603:10b6:a03:c8::20) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Anup.Patel@wdc.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [49.207.55.146] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; BYAPR04MB4566; 6:vFLrr9YTIuDTXLM/lUjOK+9MnJRNhRbvBgvRdYyzzaObFEz4D9cS7UWlgpk78k6Ck9espEx0tZ7xS56/9jTDFrS9l1x0UNPFW7OMxJu2Ij0/HgnC7k2rYwkKsiYyTG2w//Tlmg9hE0oo5dJcPJcuxGyn/PQcGzPP6M9H++Rp5qs1oEtnj57y+AvZqlgxrQ+6WBEtk6Wbcm+EAocxTaVgOEcdJ4S3Tm4FvwK5a7Yk2a4cQsu6u7ZgOHObZ+VO5s3osKuOwKmWpI4M3cWWSyxDBLRPok3c/SaQT9ToAINmzvXXaKLEVr8kuQM33TrOWYnor8cZ/yyf4APxqsM1ssV32t1rDRz6IGU2Zj85D9TOIwEquwkJZ9kbQOulVSpbFdywaF7SAaS/qtloFVFYCNayA3eCdH6yXhprNGE1fPxA8cg0vk0yuUCigvQ+0GWJW99oNtkDQ44mZEKSpZc+7DuTtg==; 5:rRvHg3CtrVbt5GulinTPCAOFkvQEUTq2mAugJn7+cIs9f2dR9zKHzNY/zK1Yz87oXJQsaaJzMbgeZ8zIxtdK7MMP17bmhEaKYp4TUvO8Rn/Pi60zHElFZuzX1e07Jjd5gzM25vBa0S5632ZsO9kP0mA7k0V5QMRK3CIR90P80MG93idNfhmsJjhcVdrrn+9DEJFuHT8pRzEglhxyy/pa5g==; 7:mGoKLe1r1TANuiOaXF3aZru7ODktthVZq0YopOwUx0m1ou34Lk3+XaO9P6dsB5vUok5Xgmx4ZLqCX30Z9ljkloeP3GFrZuTghp6aBUrQRXuUjD9nPdnsj7EJm4ITzXkZ1mWJteLMnicB9lLyMlDsmw== x-ms-office365-filtering-correlation-id: 31e96277-d3f6-45ca-a537-08d680eae565 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600109)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:BYAPR04MB4566; x-ms-traffictypediagnostic: BYAPR04MB4566: wdcipoutbound: EOP-TRUE x-microsoft-antispam-prvs: x-forefront-prvs: 0926B0E013 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(136003)(376002)(346002)(366004)(39860400002)(396003)(189003)(199004)(105586002)(305945005)(6512007)(14454004)(256004)(72206003)(6116002)(6436002)(186003)(1076003)(71190400001)(7736002)(8676002)(71200400001)(81156014)(106356001)(6486002)(478600001)(81166006)(52116002)(8936002)(39060400002)(36756003)(53936002)(2906002)(99286004)(25786009)(486006)(386003)(3846002)(6506007)(54906003)(86362001)(26005)(102836004)(476003)(7416002)(446003)(68736007)(110136005)(97736004)(316002)(2616005)(4326008)(55236004)(66066001)(50226002)(11346002)(76176011)(44832011); DIR:OUT; SFP:1102; SCL:1; SRVR:BYAPR04MB4566; H:BYAPR04MB5303.namprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: cuRU4XfSbKopqvAjCTA8vW89XUK37hCZu3aMt0rV9rW+at4eV9sYDxpnaSScZDY39HX29vrlL3nWBUzVrm/fisKvqY2uBIhWTsdVGrxrJ18o3uE44bVtJo1FyVVe7C7ru7c4BaLiefSDpTVEdlrU3f4Rx0TwTuih5L+XIu9x4cDKxYtU6/O0dXy9ZTQmcp1sDCX3YtQbY7brYZ7Yf9BjvrnwdYDsmps8zWuzfJ2uA2oGMlbtsf2VqNY6Guk1sio9erhMhPSAby52WS724iEz8gtZGCSPV2jJKRa7ZzUowUez0H4PC8rRCX87ObfzVBBmEJSLOpCxWx1FOz1VOcR04/OAPRygvKscs2OXAix1lwMEbAoGgG9LEKdDVD+lxm05zACYehkD+/nZzWVMXaIsBPf6cffe8oYNSopMXzYCWqc= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: 31e96277-d3f6-45ca-a537-08d680eae565 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jan 2019 04:26:04.1818 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR04MB4566 Cc: Palmer Dabbelt , U-Boot Mailing List , Alexander Graf , Christoph Hellwig , Paul Walmsley Subject: [U-Boot] [PATCH v3 09/12] drivers: serial_sifive: Skip baudrate config if no input clock X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" From: Atish Patra It is possible that input clock is not available because clk device was not available and 'clock-frequency' DT property is also not available. In this case, instead of failing we should just skip baudrate config by returning zero. Signed-off-by: Atish Patra Signed-off-by: Anup Patel Reviewed-by: Alexander Graf --- drivers/serial/serial_sifive.c | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/serial/serial_sifive.c b/drivers/serial/serial_sifive.c index ea4d35d48c..537bc7a975 100644 --- a/drivers/serial/serial_sifive.c +++ b/drivers/serial/serial_sifive.c @@ -99,27 +99,27 @@ static int _sifive_serial_getc(struct uart_sifive *regs) static int sifive_serial_setbrg(struct udevice *dev, int baudrate) { - int err; + int ret; struct clk clk; struct sifive_uart_platdata *platdata = dev_get_platdata(dev); + u32 clock = 0; - err = clk_get_by_index(dev, 0, &clk); - if (!err) { - err = clk_get_rate(&clk); - if (!IS_ERR_VALUE(err)) - platdata->clock = err; - } else if (err != -ENOENT && err != -ENODEV && err != -ENOSYS) { + ret = clk_get_by_index(dev, 0, &clk); + if (IS_ERR_VALUE(ret)) { debug("SiFive UART failed to get clock\n"); - return err; - } - - if (!platdata->clock) - platdata->clock = dev_read_u32_default(dev, "clock-frequency", 0); - if (!platdata->clock) { - debug("SiFive UART clock not defined\n"); - return -EINVAL; + ret = dev_read_u32(dev, "clock-frequency", &clock); + if (IS_ERR_VALUE(ret)) { + debug("SiFive UART clock not defined\n"); + return 0; + } + } else { + clock = clk_get_rate(&clk); + if (IS_ERR_VALUE(clock)) { + debug("SiFive UART clock get rate failed\n"); + return 0; + } } - + platdata->clock = clock; _sifive_serial_setbrg(platdata->regs, platdata->clock, baudrate); return 0;