From patchwork Thu Jan 17 10:39:16 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anup Patel X-Patchwork-Id: 1026604 X-Patchwork-Delegate: uboot@andestech.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=wdc.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=wdc.com header.i=@wdc.com header.b="Tc032uqM"; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=sharedspace.onmicrosoft.com header.i=@sharedspace.onmicrosoft.com header.b="dlN42bIK"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 43gNfm1F7vz9sBn for ; Thu, 17 Jan 2019 23:29:04 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id CB815C220CC; Thu, 17 Jan 2019 12:26:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=KHOP_BIG_TO_CC, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id BDF40C220BD; Thu, 17 Jan 2019 12:20:57 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id D967DC21D8A; Thu, 17 Jan 2019 10:39:20 +0000 (UTC) Received: from esa2.hgst.iphmx.com (esa2.hgst.iphmx.com [68.232.143.124]) by lists.denx.de (Postfix) with ESMTPS id 29C95C21D4A for ; Thu, 17 Jan 2019 10:39:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1547721570; x=1579257570; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=B5j4bX8cEYGxShhi3AfG9mDq2ekprXX7IL04Lq41L44=; b=Tc032uqMoiwSIbKN+dIXlcbtdseJtL0ocD8zwPWp0uieyssKyBq7duh4 /wG2AMJBFJoF2cGSFEF1BbQ3VnT8iljKwZDSObpFcsle8yWKzxw9ntHUM 8ji5RCU0hIJr6XJV8zo2yC5/T6hWS1ebreCoChuoABsa1LZBM8M1eIMWZ H+q17VueMzE5KDFAQxOdT/sZPZ/ErE7SDuH+LvOscNG2mboMIsXCdxfCz aDlGfHnzpU8ZOSsAZdAde6Wf0Rm+vMGIHJPxbor/tvgtaB8G6P6d+f5KF BEY5zmyy6+7cNkgBNPXuMt4t/z4RSei4n/lk09dghmptocq6egNmo9LbY g==; X-IronPort-AV: E=Sophos;i="5.56,488,1539619200"; d="scan'208";a="197089628" Received: from mail-cys01nam02lp2054.outbound.protection.outlook.com (HELO NAM02-CY1-obe.outbound.protection.outlook.com) ([104.47.37.54]) by ob1.hgst.iphmx.com with ESMTP; 17 Jan 2019 18:39:26 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector1-wdc-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wdJUHtJoWdkfQhbYPHX4rcrWc1z9iuuPKMhx4B6l6rs=; b=dlN42bIKUxj1d56RC8d17EzABGYK44qHRBDcQHqxgXYLnCdmAImxPbfmxSOm7d8l3KJGlV9xEcGOzrmVB5g+smV8ePykJGoyC7K0V0E98cRYxwncSa1cMQaK8rYFHaPg1E4RmdiMw/MRjc5EqzeFqiaYcRhnoFSFnYwfFP1eVyA= Received: from BYAPR04MB5303.namprd04.prod.outlook.com (20.178.49.148) by BYAPR04MB4744.namprd04.prod.outlook.com (52.135.240.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1537.26; Thu, 17 Jan 2019 10:39:16 +0000 Received: from BYAPR04MB5303.namprd04.prod.outlook.com ([fe80::add1:92cc:65d7:5d94]) by BYAPR04MB5303.namprd04.prod.outlook.com ([fe80::add1:92cc:65d7:5d94%2]) with mapi id 15.20.1537.018; Thu, 17 Jan 2019 10:39:16 +0000 From: Anup Patel To: Rick Chen , Bin Meng , Joe Hershberger , Lukas Auer , Masahiro Yamada , Simon Glass Thread-Topic: [PATCH 09/11] drivers: serial: serial_sifive: Skip baudrate config if no input clock Thread-Index: AQHUrlDkAfFmIP0IRUqYFYF3LlLRmw== Date: Thu, 17 Jan 2019 10:39:16 +0000 Message-ID: <20190117103748.36613-10-anup.patel@wdc.com> References: <20190117103748.36613-1-anup.patel@wdc.com> In-Reply-To: <20190117103748.36613-1-anup.patel@wdc.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: MA1PR0101CA0069.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:20::31) To BYAPR04MB5303.namprd04.prod.outlook.com (2603:10b6:a03:c8::20) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Anup.Patel@wdc.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [106.51.16.164] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; BYAPR04MB4744; 6:+ABYYtMyrabnxlzmHKcIbldiGCPBvJXP1PR2EfY5z9+NaDTFmrQI+pmaBrF4r6UjoiFzX0f/SZZUTnlPDSuBGn1ISMQvleDrt0noTyDuvwnR9scajAe/VYdLAbrjnwlm3PQIgYbRQHYaRA+zf0UbjMN48VF1DQ5M2lWSXkPXf6YuzOYpUTPdFGD8eC4kHR0o1TXxotf9azYsSOnJrVcDoccTY+KsnQa+dJIPd1fbutwbWetythWc072aDj1ZmMQCIlXCiQvNFsZWmNM5vm6IogdGvYo0ARE0cw5hohSGaHFD2CBzxDn3Srf2qXTLjh6e597Vx9SshNGJA8JwAwvRD3CYdAP44A5PsJq+ZzSM8EBTPBXSy4We3AL44yUMMdOz+ccDgfgX48P+YBbhJD4xMYkE3AorfBgiMC72r4EGijhEHCHoVR6hJuJri27olFtuoeIgb3EhpqbhH92oQRYt9g==; 5:KwQGZtzdMFIFiOuRv++R/eEn2ZV7tU1CMFtNH05RUzwuHslcqDWCs4ilGWTWEHhuJ/cHN5YP/3NpNy/ePOmArZW5LRSyZ0NNad5KBN2Hks7EEvoUhEaf45xTPuNNqRLZFbCONviXIr/UnbFQLAUtqKWECq4JzgdJcwOSWQ96P2KOVdXLM0QHdxtz4OBZdzIqo6irFcmARyVKmcS1jjB0SA==; 7:er0WjJIU/gIW9UpohPCjYQi/taajyLCxPoftRmPwj6XdYwOnsD6H91m1lbqIcUHCFHXmh0Rv1YrY4hpysnqNhZN888CZCH40EMgofuyUgDvwjXZbdPHqbbIH/EmMCQZQwqYUQsgls4fN19tDpqO1vg== x-ms-office365-filtering-correlation-id: ada70ac7-7495-452d-6e80-08d67c680752 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600109)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:BYAPR04MB4744; x-ms-traffictypediagnostic: BYAPR04MB4744: wdcipoutbound: EOP-TRUE x-microsoft-antispam-prvs: x-forefront-prvs: 0920602B08 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(346002)(366004)(396003)(39860400002)(376002)(136003)(189003)(199004)(9456002)(52116002)(186003)(11346002)(54906003)(6436002)(5660300001)(50226002)(8936002)(316002)(81156014)(8676002)(486006)(71200400001)(97736004)(7416002)(71190400001)(2616005)(25786009)(66066001)(78486014)(476003)(446003)(256004)(44832011)(6116002)(3846002)(1076003)(6486002)(81166006)(4326008)(36756003)(86362001)(6512007)(6506007)(386003)(99286004)(478600001)(2906002)(53936002)(14454004)(110136005)(7736002)(305945005)(26005)(55236004)(106356001)(102836004)(68736007)(76176011)(72206003)(105586002)(39060400002); DIR:OUT; SFP:1102; SCL:1; SRVR:BYAPR04MB4744; H:BYAPR04MB5303.namprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 3tyVNLp9Qmwbm7kpS2v7MFNdtHJ4Vvc3bLqNbyOqGzY32r2J4GYGmk2U1DcxC0Oj9hJQPd9eBo/2dNShyIhxIDIk6VIGPzxpzN2exICy7WXna025zfUHQu87ZIkXhIzOJelJeZB6Xagx1gsohqwZc1I68jkAqIvVGJjZ379xcGg+jBnMOTuAtvy/WNZNGKAqTMI/Tvpar/z0ebFVRcVrxUSfQh8ioykGapvMhqblcR0fl2Ke0gZSJ6U7JVUN8mspKQ3X83U5rhq0kE5BKS7sdk6ef/C5YxvVnrEXEiFYeY7cCqfPIZFN1QGEvnLW344MgRnnQzaPYUXoI0UMO7JBRSavmT42TbzpgJkrFtdhdnJoeoVuwzVUnZNa62VT3qgi3fTDs4ZKugE5qSmDxRSThNori0EM/ZhOmS1uG+7XWhE= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: ada70ac7-7495-452d-6e80-08d67c680752 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jan 2019 10:39:12.7664 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR04MB4744 X-Mailman-Approved-At: Thu, 17 Jan 2019 12:20:43 +0000 Cc: Palmer Dabbelt , U-Boot Mailing List , Alexander Graf , Christoph Hellwig , Paul Walmsley Subject: [U-Boot] [PATCH 09/11] drivers: serial: serial_sifive: Skip baudrate config if no input clock X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" From: Atish Patra It is possible that input clock is not available because clk device was not available and 'clock-frequency' DT property is also not available. In this case, instead of failing we should just skip baudrate config by returning zero. Signed-off-by: Atish Patra Signed-off-by: Anup Patel Reviewed-by: Alexander Graf --- drivers/serial/serial_sifive.c | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/serial/serial_sifive.c b/drivers/serial/serial_sifive.c index ea4d35d48c..537bc7a975 100644 --- a/drivers/serial/serial_sifive.c +++ b/drivers/serial/serial_sifive.c @@ -99,27 +99,27 @@ static int _sifive_serial_getc(struct uart_sifive *regs) static int sifive_serial_setbrg(struct udevice *dev, int baudrate) { - int err; + int ret; struct clk clk; struct sifive_uart_platdata *platdata = dev_get_platdata(dev); + u32 clock = 0; - err = clk_get_by_index(dev, 0, &clk); - if (!err) { - err = clk_get_rate(&clk); - if (!IS_ERR_VALUE(err)) - platdata->clock = err; - } else if (err != -ENOENT && err != -ENODEV && err != -ENOSYS) { + ret = clk_get_by_index(dev, 0, &clk); + if (IS_ERR_VALUE(ret)) { debug("SiFive UART failed to get clock\n"); - return err; - } - - if (!platdata->clock) - platdata->clock = dev_read_u32_default(dev, "clock-frequency", 0); - if (!platdata->clock) { - debug("SiFive UART clock not defined\n"); - return -EINVAL; + ret = dev_read_u32(dev, "clock-frequency", &clock); + if (IS_ERR_VALUE(ret)) { + debug("SiFive UART clock not defined\n"); + return 0; + } + } else { + clock = clk_get_rate(&clk); + if (IS_ERR_VALUE(clock)) { + debug("SiFive UART clock get rate failed\n"); + return 0; + } } - + platdata->clock = clock; _sifive_serial_setbrg(platdata->regs, platdata->clock, baudrate); return 0;