From patchwork Wed Jan 16 18:04:36 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Carlo Caione X-Patchwork-Id: 1026077 X-Patchwork-Delegate: joe.hershberger@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="HpYFop50"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 43fwCM2Dffz9sDr for ; Thu, 17 Jan 2019 05:07:11 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id 0B494C220A3; Wed, 16 Jan 2019 18:06:41 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=RCVD_IN_MSPIKE_H2, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 195B8C22107; Wed, 16 Jan 2019 18:06:39 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 57B7DC22129; Wed, 16 Jan 2019 18:06:26 +0000 (UTC) Received: from mail-ed1-f68.google.com (mail-ed1-f68.google.com [209.85.208.68]) by lists.denx.de (Postfix) with ESMTPS id A3A97C220D2 for ; Wed, 16 Jan 2019 18:06:22 +0000 (UTC) Received: by mail-ed1-f68.google.com with SMTP id h50so6184247ede.5 for ; Wed, 16 Jan 2019 10:06:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RpqkfD2wi3GAaaWHTqB1lYU3CTMmiI0H+Y6msImtttM=; b=HpYFop50RctRzkV5DZfJ/nGlE7mFEzmJ8mm3PFHV9AUf9W6AD12NrlAhaMtuQI40Xd SWk0Pv9n3TjCkNFFgUWzCC1ZrcPEXLKQbFYqmWqiMoKcDYORcWESgXMGPDpDdnIwa9Ac vTEudULxg1WZA/Mq7XsJY/Zxz/a7fcnA7WN4I4rU3jIk09IbNxyNY8Ps9Y97wShR4COz mYnsNu6mKGvi6jlTWBuxuInftSygLCwFbR4M3R9KNjT//Us8DAKPCV6VHHMZPATOWBZP ZX0C7VOloZp092/NzmNv0oR4dnOPigLwW2DP621+wfwGd7+D8xnImstGB3X/twX++H3e 0cOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RpqkfD2wi3GAaaWHTqB1lYU3CTMmiI0H+Y6msImtttM=; b=nZ5aKUUIjtymgpByswa5UVfdoKxrOE19/YM5FiP95I0SmuaZKXVqVzO2gJyIMQ70FO 2CCXR6249bnx/O8F9Z+yZnBh0oHMLyE+0s4Le7T0J/EwMbtZg8bbXOIyR+YDUVItKDkp llRovt+uJNJoaj4gRBKhviYWTF/t9zTHM7ztBBFvK0EIdvcWnDwV3QFxus75z+z9pwlW joX29v8Rfa2nEZsw0kgRoSYV/iuOdF+Kx/G1qNmjIfFcVieM7YBCmO3wAfpqkUS/UYFI cQV21YMPabzMTU+qxt7g/ekOQIKbGs1RRV9onRzzNZTbEBjrYkCbp2m8LXN48XO8IPn3 XgpA== X-Gm-Message-State: AJcUukcl/5bjjeQXT5njoiH6iWZwNXpw4hQcfN18+x+Zzm+9z15kjx40 5FhJWzhRgD9xoiWinmA36Ae01yySIApkrw== X-Google-Smtp-Source: ALg8bN6bWGX4R8N05Kl1+aMGsDQXeZQfE6hVGebPv0jajlFkjbzDLXdKlKtzH3p5lqvCyifinb3BGw== X-Received: by 2002:a50:d551:: with SMTP id f17mr8325956edj.87.1547661982328; Wed, 16 Jan 2019 10:06:22 -0800 (PST) Received: from localhost.localdomain ([2a00:23c4:f7a1:ce00:5105:4b7b:c922:7c6]) by smtp.gmail.com with ESMTPSA id n11sm5705555edn.14.2019.01.16.10.05.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 16 Jan 2019 10:06:06 -0800 (PST) From: Carlo Caione To: joe.hershberger@ni.com, u-boot@lists.denx.de, jbrunet@baylibre.com, narmstrong@baylibre.com Date: Wed, 16 Jan 2019 18:04:36 +0000 Message-Id: <20190116180436.8757-3-ccaione@baylibre.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190116180436.8757-1-ccaione@baylibre.com> References: <20190116180436.8757-1-ccaione@baylibre.com> MIME-Version: 1.0 Cc: Carlo Caione Subject: [U-Boot] [PATCH u-boot 2/2] cmd: mdio: Add new parameter to access MMD PHY registers X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Two new parameters (rmmd and wmmd) are added to allow the `mdio` command to access the content of the MMD PHY registers. Signed-off-by: Carlo Caione --- cmd/mdio.c | 33 +++++++++++++++++++++++++++------ 1 file changed, 27 insertions(+), 6 deletions(-) diff --git a/cmd/mdio.c b/cmd/mdio.c index 184868063a..010632b562 100644 --- a/cmd/mdio.c +++ b/cmd/mdio.c @@ -43,7 +43,7 @@ static int mdio_write_ranges(struct phy_device *phydev, struct mii_dev *bus, int addrlo, int addrhi, int devadlo, int devadhi, int reglo, int reghi, unsigned short data, - int extended) + int extended, int mmd) { int addr, devad, reg; int err = 0; @@ -51,7 +51,9 @@ static int mdio_write_ranges(struct phy_device *phydev, struct mii_dev *bus, for (addr = addrlo; addr <= addrhi; addr++) { for (devad = devadlo; devad <= devadhi; devad++) { for (reg = reglo; reg <= reghi; reg++) { - if (!extended) + if (mmd) + err = phy_write_mmd(phydev, devad, reg, data); + else if (!extended) err = bus->write(bus, addr, devad, reg, data); else @@ -71,7 +73,7 @@ err_out: static int mdio_read_ranges(struct phy_device *phydev, struct mii_dev *bus, int addrlo, int addrhi, int devadlo, int devadhi, - int reglo, int reghi, int extended) + int reglo, int reghi, int extended, int mmd) { int addr, devad, reg; @@ -83,7 +85,9 @@ static int mdio_read_ranges(struct phy_device *phydev, struct mii_dev *bus, for (reg = reglo; reg <= reghi; reg++) { int val; - if (!extended) + if (mmd) + val = phy_read_mmd(phydev, devad, reg); + else if (!extended) val = bus->read(bus, addr, devad, reg); else val = phydev->drv->readext(phydev, addr, @@ -189,6 +193,7 @@ static int do_mdio(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) struct mii_dev *bus; struct phy_device *phydev = NULL; int extended = 0; + int mmd = 0; if (argc < 2) return CMD_RET_USAGE; @@ -232,6 +237,18 @@ static int do_mdio(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) return -1; } } + if (op[1] == 'm') { + phydev = mdio_phydev_for_ethname(argv[2]); + + if (phydev) { + addrlo = phydev->addr; + addrhi = addrlo; + bus = phydev->bus; + mmd = 1; + } else { + return -1; + } + } } switch (op[0]) { @@ -265,12 +282,12 @@ static int do_mdio(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) switch (op[0]) { case 'w': mdio_write_ranges(phydev, bus, addrlo, addrhi, devadlo, devadhi, - reglo, reghi, data, extended); + reglo, reghi, data, extended, mmd); break; case 'r': mdio_read_ranges(phydev, bus, addrlo, addrhi, devadlo, devadhi, - reglo, reghi, extended); + reglo, reghi, extended, mmd); break; } @@ -303,6 +320,10 @@ U_BOOT_CMD( "read PHY's extended register at .\n" "mdio wx [.] - " "write PHY's extended register at .\n" + "mdio rmmd [.] - " + "read PHY's extended register at .\n" + "mdio wmmd [.] - " + "write PHY's extended register at .\n" " may be:\n" " \n" " \n"