From patchwork Thu Dec 27 17:58:42 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ramon Fried X-Patchwork-Id: 1018949 X-Patchwork-Delegate: joe.hershberger@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="QNEQaHGf"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 43QczS0NLBz9s55 for ; Fri, 28 Dec 2018 04:59:11 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id 86414C21DA1; Thu, 27 Dec 2018 17:59:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_MSPIKE_H2, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id ABB02C21C3F; Thu, 27 Dec 2018 17:59:02 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id D3311C21C3F; Thu, 27 Dec 2018 17:59:00 +0000 (UTC) Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by lists.denx.de (Postfix) with ESMTPS id 7CE25C21BE5 for ; Thu, 27 Dec 2018 17:59:00 +0000 (UTC) Received: by mail-wr1-f68.google.com with SMTP id x10so18933756wrs.8 for ; Thu, 27 Dec 2018 09:59:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=KCxuRt0wa9FuuBl0QGa3jbJHpB2QkW4+Ngtal4bhaaA=; b=QNEQaHGfCdnEB3NK1SxLnTMoLcihbBQwuaUMMiyBZM9Gtk9X6pmh8RR0L+cO05N5T+ YGLzBOaYNqyan+2V/LS3ya9tOAbTFafEpdHVqemUGFK6Is1W3iab3MRkYNa+0bHQ4YSI EzDUeIZvp64jUI/JtxxDxoOJorjkeiEs6VHLjs4wKKRtlAAEH6EhGw53397B8pLA/6Jz dj8qfkFity0hMC1s4iRfIW72Oteb5iS/qzia2TLox5jUXkvY/i7bxSvfWOBWA9h2WtEv NKvQDJ9GSfnCFNfr0tMTbdU3Pz/dMS3SHYZ0b577SV+1saFe1HZp2AUhxI381ZP6AHfv WlIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=KCxuRt0wa9FuuBl0QGa3jbJHpB2QkW4+Ngtal4bhaaA=; b=EJ6rQhIzkCf/epOfPoPRXl41W/Gem0mq001+xE+CagnxjzsmxQvBTeCHybJHXLCCYL GVwXi7wB8P6W2dVAOjALgcA8jQhCww2JdiibBo//6sekczMX/et9AQJk3cD0kzJqgZ/n axJN4UA1COoP3FKb0pibjFhwEVQKj5ueL/piBEGgUsJcvuq1Tn5F4alALiVErjt1n8V5 b4KmYVT2HVWT1NA5rINxATgZrDXujcuixAJ0WzFU7NPYyuRrAPi7CGgtBonHBQVPY+Yp 5YOCEPeY8QScksDYyZiGqdoPoGnDBbwyigyZcfF/1yrU4nu+otna4N3HXNtDJ2fzQNKT 4SkA== X-Gm-Message-State: AJcUukfoK3+HuygrEjnwfKIgANSXBP+3SFg7UxDl/cmSmyN6W+idYpBp GCYfwayWIOkHDvNZDiJCyz8= X-Google-Smtp-Source: ALg8bN58DkjMEeL0EMc6XsReBUZyjEj2uzBjoNuiToVH1cu1A+Gyx8McZuZl5958hmpYZSXsQFribA== X-Received: by 2002:adf:c711:: with SMTP id k17mr22048252wrg.197.1545933539819; Thu, 27 Dec 2018 09:58:59 -0800 (PST) Received: from localhost.localdomain ([141.226.31.91]) by smtp.gmail.com with ESMTPSA id e27sm34101386wra.67.2018.12.27.09.58.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Dec 2018 09:58:59 -0800 (PST) From: Ramon Fried To: joe.hershberger@ni.com, daniel.schwierzeck@gmail.com, Tom Rini Date: Thu, 27 Dec 2018 19:58:42 +0200 Message-Id: <20181227175842.31216-1-ramon.fried@gmail.com> X-Mailer: git-send-email 2.19.2 MIME-Version: 1.0 Cc: u-boot@lists.denx.de Subject: [U-Boot] [PATCH v2] net: macb: fix mapping of registers X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Some architectures (MIPS) needs mapping to access IOMEM. Fix that. Fixes: f1dcc19b213d ("net: macb: Convert to driver model") Signed-off-by: Ramon Fried Acked-by: Joe Hershberger --- v2: add casting to phys_addr_t to prevent warning from compiler. drivers/net/macb.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/macb.c b/drivers/net/macb.c index 94c89c762b..c9ee22279a 100644 --- a/drivers/net/macb.c +++ b/drivers/net/macb.c @@ -1151,7 +1151,9 @@ static int macb_eth_ofdata_to_platdata(struct udevice *dev) { struct eth_pdata *pdata = dev_get_platdata(dev); - pdata->iobase = devfdt_get_addr(dev); + pdata->iobase = (phys_addr_t)dev_remap_addr(dev); + if (!pdata->iobase) + return -EINVAL; return macb_late_eth_ofdata_to_platdata(dev); }