From patchwork Mon Dec 17 08:35:23 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Packham X-Patchwork-Id: 1014348 X-Patchwork-Delegate: sr@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="aKglwSqE"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 43JDyn6jJlz9sDN for ; Mon, 17 Dec 2018 19:36:33 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id 9B7CAC21FE5; Mon, 17 Dec 2018 08:36:10 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 2C28BC21FEA; Mon, 17 Dec 2018 08:35:59 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 7F47BC22030; Mon, 17 Dec 2018 08:35:56 +0000 (UTC) Received: from mail-pl1-f196.google.com (mail-pl1-f196.google.com [209.85.214.196]) by lists.denx.de (Postfix) with ESMTPS id 71F02C21FA8 for ; Mon, 17 Dec 2018 08:35:52 +0000 (UTC) Received: by mail-pl1-f196.google.com with SMTP id b5so5793817plr.4 for ; Mon, 17 Dec 2018 00:35:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=S0BbsuXvZQMKLp6NNZ/tJxa679ELHB1GYKyrP6TrIVk=; b=aKglwSqEu1ZXJSg+M9Zs2FNbASvoi/LfFnjIg84bFBAhhqIvAq2CQlUgytRNWqio/e PlCmJvciWdMB0nX56mvTVbwfwLs6NJ1jH6X/bNOpvFrAvtTabn0kioyXiyA2pL3ugaHV x5Vapq90T/x5wVeqPqNqIYjJEtj5g3NFwixJBiP5mYi2dKyDhR+eppjIxl6NceyT7lnI tV6AoGNHT0c4MihDC8pZfJSHBP5Te1vcVP4gFR8gjSdcrCnog0aaLHc9gOMdSNRG5j9+ sJ7FxPnFpO3LHtDainjRdhfdP2VojgzwEz/Bnfv8KxsPnD2uB31bU0euGb4QSdl4xAua BfAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=S0BbsuXvZQMKLp6NNZ/tJxa679ELHB1GYKyrP6TrIVk=; b=FSTYSr4emRCqNyh7fZc2WlvuZfzO+HN4T1yqqaSQsoQa4dqot6dXoSwtW9WyAnDhJd VJUDFr9bYDux7x2OxSbMpwDnEf3cSp2cE3algYDhC5RhfWMH3KBNrJyU8F8X9oY9Dny5 QjB1giycMiI0Jr7MEF3UwLDCVKmXSWgv1MkA/sLz1kyS2wZG+ViPBHzcjtSqhxLuByd9 GK9b9649/BHGw4LFGJsYkNtztPgtCYqWzs/0esY8GyeT7pTKvIi88YJqvha8jzJQ9NK8 HoU4mcEbyZnBtEyzlt3wuTQe0IgyWqtfbz544izkKj/wTmR4GCMQg3qocZMXMldAvddO ez8Q== X-Gm-Message-State: AA+aEWYK2jZn/hhC8TMNgtULH02vKhGVFEXFVNEQKx6ElDazVBf2apdc FLduAt+TF+iDTys94JcasWUF50/hfy8= X-Google-Smtp-Source: AFSGD/VwsH2PVMn6yJ/QBjsZGhOGPWPL3KsQAEM8eKEzJERyYWmW9C0IRZn6dXZOMnpFgA74OO5O4A== X-Received: by 2002:a17:902:be0e:: with SMTP id r14mr11122490pls.124.1545035750863; Mon, 17 Dec 2018 00:35:50 -0800 (PST) Received: from chrisp-dl.ws.atlnz.lc ([2001:df5:b000:22:3a2c:4aff:fe70:2b02]) by smtp.gmail.com with ESMTPSA id o4sm20469787pgs.12.2018.12.17.00.35.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 17 Dec 2018 00:35:50 -0800 (PST) From: Chris Packham To: u-boot@lists.denx.de Date: Mon, 17 Dec 2018 21:35:23 +1300 Message-Id: <20181217083529.19030-2-judge.packham@gmail.com> X-Mailer: git-send-email 2.19.2 In-Reply-To: <20181217083529.19030-1-judge.packham@gmail.com> References: <20181217083529.19030-1-judge.packham@gmail.com> MIME-Version: 1.0 Cc: Tom Rini , Stefan Roese , Chris Packham , Joe Hershberger Subject: [U-Boot] [RFC PATCH v1 1/7] net: mvgbe: fallback phy-mode to GMII X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Some existing device trees don't specify a phy-mode so fallback to GMII when a phy-mode is not provided. Signed-off-by: Chris Packham Reviewed-by: Stefan Roese --- This is similar to what the Linux mv643xx_eth.c network driver does to handle the same case. drivers/net/mvgbe.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/mvgbe.c b/drivers/net/mvgbe.c index 74fed7abd837..037e59ec6e3c 100644 --- a/drivers/net/mvgbe.c +++ b/drivers/net/mvgbe.c @@ -1005,10 +1005,8 @@ static int mvgbe_ofdata_to_platdata(struct udevice *dev) phy_mode = fdt_getprop(gd->fdt_blob, pnode, "phy-mode", NULL); if (phy_mode) pdata->phy_interface = phy_get_interface_by_name(phy_mode); - if (pdata->phy_interface == -1) { - debug("%s: Invalid PHY interface '%s'\n", __func__, phy_mode); - return -EINVAL; - } + else + pdata->phy_interface = PHY_INTERFACE_MODE_GMII; dmvgbe->phy_interface = pdata->phy_interface;