diff mbox series

[U-Boot,v2,18/24] mtd: rawnand: compile-in the NAND core

Message ID	20181128230800.13292-19-miquel.raynal@bootlin.com
State	Superseded
Delegated to:	Jagannadha Sutradharudu Teki
Headers	show Return-Path: <u-boot-bounces@lists.denx.de> From: Miquel Raynal <miquel.raynal@bootlin.com> To: u-boot@lists.denx.de Date: Thu, 29 Nov 2018 00:07:54 +0100 Message-Id: <20181128230800.13292-19-miquel.raynal@bootlin.com> In-Reply-To: <20181128230800.13292-1-miquel.raynal@bootlin.com> References: <20181128230800.13292-1-miquel.raynal@bootlin.com> MIME-Version: 1.0 Cc: Tom Rini <trini@konsulko.com>, Kyungmin Park <kmpark@infradead.org>, Boris Brezillon <boris.brezillon@bootlin.com>, Miquel Raynal <miquel.raynal@bootlin.com>, Steve Rae <steve.rae@raedomain.com>, TsiChung Liew <Tsi-Chung.Liew@nxp.com> Subject: [U-Boot] [PATCH v2 18/24] mtd: rawnand: compile-in the NAND core Precedence: list Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" <u-boot-bounces@lists.denx.de>
Series	MTD defconfigs/Kconfigs/Makefiles heavy cleanup \| expand [U-Boot,v2,00/24] MTD defconfigs/Kconfigs/Makefiles heavy cleanup [U-Boot,v2,01/24] Makefile: move MTD-related lines in coherent Makefiles [U-Boot,v2,02/24] mtd: rename CONFIG_NAND -> CONFIG_MTD_RAW_NAND [U-Boot,v2,03/24] mtd: rename CONFIG_MTD -> CONFIG_DM_MTD [U-Boot,v2,04/24] mtd: rename CONFIG_MTD_DEVICE -> CONFIG_MTD [U-Boot,v2,05/24] mtd: ensure MTD is compiled when there is a NOR flash [U-Boot,v2,06/24] mtd: ensure MTD/the raw NAND core are compiled when there is a NAND flash [U-Boot,v2,07/24] mtd: ensure MTD is compiled when there is a SPI NOR flash [U-Boot,v2,08/24] mtd: ensure UBI is compiled when using fastmap [U-Boot,v2,09/24] mtd: ensure MTD is compiled when UBI is used [U-Boot,v2,10/24] mtd: ensure UBI is compiled when CMD_UBI is selected [U-Boot,v2,11/24] mtd: ensure UBI is compiled when ENV_IS_IN_UBI is selected [U-Boot,v2,12/24] mtd: ensure MTD_RAW_NAND is compiled when ENV_IS_IN_NAND is selected [U-Boot,v2,13/24] mtd: ensure MTD is compiled when ENV_IS_IN_FLASH is selected [U-Boot,v2,14/24] mtd: ensure CMD_NAND is compiled when its options are selected [U-Boot,v2,15/24] configs: remove raw NAND core from k2g defconfigs [U-Boot,v2,16/24] configs: remove MTD support from bcm11130 and M54418TWR defconfigs [U-Boot,v2,17/24] mtd: nand: add includes in NAND core to avoid warnings [U-Boot,v2,18/24] mtd: rawnand: compile-in the NAND core [U-Boot,v2,19/24] dfu: add dependency on the NAND core [U-Boot,v2,20/24] mtd: nand: remove dependency on commands in Kconfig [U-Boot,v2,21/24] mtd: ubi: remove dependency on command in Kconfig [U-Boot,v2,22/24] cmd: make all MTD commands depend on MTD [U-Boot,v2,23/24] mtd: simplify Makefile [U-Boot,v2,24/24] mtd: drop CONFIG_MTD_PARTITIONS

Commit Message

Miquel Raynal Nov. 28, 2018, 11:07 p.m. UTC

The NAND core should be selected by both SPI NAND and raw NAND
drivers.

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
 drivers/mtd/nand/raw/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

Comments

Boris Brezillon Nov. 28, 2018, 11:57 p.m. UTC | #1

On Thu, 29 Nov 2018 00:07:54 +0100
Miquel Raynal <miquel.raynal@bootlin.com> wrote:

> The NAND core should be selected by both SPI NAND and raw NAND
> drivers.
> 
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
>  drivers/mtd/nand/raw/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/mtd/nand/raw/Kconfig b/drivers/mtd/nand/raw/Kconfig
> index a1fd476b0d..5624e47d65 100644
> --- a/drivers/mtd/nand/raw/Kconfig
> +++ b/drivers/mtd/nand/raw/Kconfig
> @@ -1,6 +1,8 @@
>  
>  menuconfig MTD_RAW_NAND
>  	bool "Raw NAND Device Support"
> +	select MTD_NAND_CORE
> +

I'm pretty sure this is not needed (yet). Let's not compile things we
don't need as some devices have storage constraints.

Miquel Raynal Dec. 4, 2018, 2:33 p.m. UTC | #2

Hi Boris,

Boris Brezillon <boris.brezillon@bootlin.com> wrote on Thu, 29 Nov 2018
00:57:19 +0100:

> On Thu, 29 Nov 2018 00:07:54 +0100
> Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> 
> > The NAND core should be selected by both SPI NAND and raw NAND
> > drivers.
> > 
> > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> > ---
> >  drivers/mtd/nand/raw/Kconfig | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/drivers/mtd/nand/raw/Kconfig b/drivers/mtd/nand/raw/Kconfig
> > index a1fd476b0d..5624e47d65 100644
> > --- a/drivers/mtd/nand/raw/Kconfig
> > +++ b/drivers/mtd/nand/raw/Kconfig
> > @@ -1,6 +1,8 @@
> >  
> >  menuconfig MTD_RAW_NAND
> >  	bool "Raw NAND Device Support"
> > +	select MTD_NAND_CORE
> > +  
> 
> I'm pretty sure this is not needed (yet). Let's not compile things we
> don't need as some devices have storage constraints.

Ok, but I will keep the compilation fixes for the time when we will want
to compile these files.


Thanks,
Miquèl

diff mbox series

Patch

diff --git a/drivers/mtd/nand/raw/Kconfig b/drivers/mtd/nand/raw/Kconfig
index a1fd476b0d..5624e47d65 100644
--- a/drivers/mtd/nand/raw/Kconfig
+++ b/drivers/mtd/nand/raw/Kconfig
@@ -1,6 +1,8 @@ 
 
 menuconfig MTD_RAW_NAND
 	bool "Raw NAND Device Support"
+	select MTD_NAND_CORE
+
 if MTD_RAW_NAND
 
 config SYS_NAND_SELF_INIT