diff mbox series

[U-Boot,u-boot-marvell,v3,04/10] arch/arm/dts: Fix Turris Mox device tree

Message ID 20181120120409.12822-4-marek.behun@nic.cz
State Superseded
Delegated to: Stefan Roese
Headers show
Series [U-Boot,u-boot-marvell,v3,01/10] board: turris_mox: Cosmetic restructurization | expand

Commit Message

Marek Behún Nov. 20, 2018, 12:04 p.m. UTC
DTC issues a warning because #address-cells and #size-cells properties
are not set in the mdio node.
Also add ethernet1 alias.
Also add RTC node.
Also fix USB3 regulator startup delay time.
Also fix PCI Express SERDES speed to 5 GHz (this is only cosmetic, the
speed value is not used byt the comphy driver for PCI Express, but
should be 5 GHz nonetheless).

Signed-off-by: Marek Behún <marek.behun@nic.cz>
---
 arch/arm/dts/armada-3720-turris-mox.dts | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

Comments

Stefan Roese Nov. 29, 2018, 1:01 p.m. UTC | #1
On 20.11.18 13:04, Marek Behún wrote:
> DTC issues a warning because #address-cells and #size-cells properties
> are not set in the mdio node.
> Also add ethernet1 alias.
> Also add RTC node.
> Also fix USB3 regulator startup delay time.
> Also fix PCI Express SERDES speed to 5 GHz (this is only cosmetic, the
> speed value is not used byt the comphy driver for PCI Express, but
> should be 5 GHz nonetheless).
> 
> Signed-off-by: Marek Behún <marek.behun@nic.cz>

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

> ---
>   arch/arm/dts/armada-3720-turris-mox.dts | 12 +++++++++++-
>   1 file changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/dts/armada-3720-turris-mox.dts b/arch/arm/dts/armada-3720-turris-mox.dts
> index 9c96dd39a9..2a71da21bf 100644
> --- a/arch/arm/dts/armada-3720-turris-mox.dts
> +++ b/arch/arm/dts/armada-3720-turris-mox.dts
> @@ -24,6 +24,7 @@
>   
>   	aliases {
>   		ethernet0 = &eth0;
> +		ethernet1 = &eth1;
>   		i2c0 = &i2c0;
>   		spi0 = &spi0;
>   	};
> @@ -38,12 +39,16 @@
>   		regulator-name = "usb3-vbus";
>   		regulator-min-microvolt = <5000000>;
>   		regulator-max-microvolt = <5000000>;
> +		startup-delay-us = <2000000>;
>   		shutdown-delay-us = <1000000>;
>   		gpio = <&gpiosb 0 GPIO_ACTIVE_HIGH>;
>   		regulator-boot-on;
>   	};
>   
>   	mdio {
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
>   		eth_phy1: ethernet-phy@1 {
>   			reg = <1>;
>   		};
> @@ -59,7 +64,7 @@
>   
>   	phy1 {
>   		phy-type = <PHY_TYPE_PEX0>;
> -		phy-speed = <PHY_SPEED_2_5G>;
> +		phy-speed = <PHY_SPEED_5G>;
>   	};
>   
>   	phy2 {
> @@ -80,6 +85,11 @@
>   	pinctrl-names = "default";
>   	pinctrl-0 = <&i2c1_pins>;
>   	status = "okay";
> +
> +	rtc@6f {
> +		compatible = "microchip,mcp7941x";
> +		reg = <0x6f>;
> +	};
>   };
>   
>   &sdhci1 {
> 

Viele Grüße,
Stefan
diff mbox series

Patch

diff --git a/arch/arm/dts/armada-3720-turris-mox.dts b/arch/arm/dts/armada-3720-turris-mox.dts
index 9c96dd39a9..2a71da21bf 100644
--- a/arch/arm/dts/armada-3720-turris-mox.dts
+++ b/arch/arm/dts/armada-3720-turris-mox.dts
@@ -24,6 +24,7 @@ 
 
 	aliases {
 		ethernet0 = &eth0;
+		ethernet1 = &eth1;
 		i2c0 = &i2c0;
 		spi0 = &spi0;
 	};
@@ -38,12 +39,16 @@ 
 		regulator-name = "usb3-vbus";
 		regulator-min-microvolt = <5000000>;
 		regulator-max-microvolt = <5000000>;
+		startup-delay-us = <2000000>;
 		shutdown-delay-us = <1000000>;
 		gpio = <&gpiosb 0 GPIO_ACTIVE_HIGH>;
 		regulator-boot-on;
 	};
 
 	mdio {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
 		eth_phy1: ethernet-phy@1 {
 			reg = <1>;
 		};
@@ -59,7 +64,7 @@ 
 
 	phy1 {
 		phy-type = <PHY_TYPE_PEX0>;
-		phy-speed = <PHY_SPEED_2_5G>;
+		phy-speed = <PHY_SPEED_5G>;
 	};
 
 	phy2 {
@@ -80,6 +85,11 @@ 
 	pinctrl-names = "default";
 	pinctrl-0 = <&i2c1_pins>;
 	status = "okay";
+
+	rtc@6f {
+		compatible = "microchip,mcp7941x";
+		reg = <0x6f>;
+	};
 };
 
 &sdhci1 {