diff mbox series

[U-Boot,v2,3/3] riscv: Add S-mode defconfigs for QEMU virt machine

Message ID 20181120112933.23700-4-anup@brainfault.org
State Superseded
Delegated to: Andes
Headers show
Series [U-Boot,v2,1/3] riscv: Add kconfig option to run u-boot in S-mode | expand

Commit Message

Anup Patel Nov. 20, 2018, 11:29 a.m. UTC
This patch adds S-mode defconfigs for QEMU virt machine so
that we can run u-boot in S-mode on QEMU using M-mode runtime
firmware (BBL or equivalent).

Signed-off-by: Anup Patel <anup@brainfault.org>
---
 configs/qemu-riscv32-smode_defconfig | 10 ++++++++++
 configs/qemu-riscv64-smode_defconfig | 11 +++++++++++
 2 files changed, 21 insertions(+)
 create mode 100644 configs/qemu-riscv32-smode_defconfig
 create mode 100644 configs/qemu-riscv64-smode_defconfig

Comments

Bin Meng Nov. 20, 2018, 1:38 p.m. UTC | #1
On Tue, Nov 20, 2018 at 7:29 PM Anup Patel <anup@brainfault.org> wrote:
>
> This patch adds S-mode defconfigs for QEMU virt machine so
> that we can run u-boot in S-mode on QEMU using M-mode runtime
> firmware (BBL or equivalent).
>
> Signed-off-by: Anup Patel <anup@brainfault.org>
> ---
>  configs/qemu-riscv32-smode_defconfig | 10 ++++++++++
>  configs/qemu-riscv64-smode_defconfig | 11 +++++++++++

nits: please use the name: qemu-riscv*_smode_defconfig (_ instead of -)

>  2 files changed, 21 insertions(+)
>  create mode 100644 configs/qemu-riscv32-smode_defconfig
>  create mode 100644 configs/qemu-riscv64-smode_defconfig
>

Please update board/emulation/qemu-riscv/MAINTAINERS to include these
2 defconfigs, otherwise buildman will report warnings.

Other than that,

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Tested-by: Bin Meng <bmeng.cn@gmail.com>

[snip]

Regards,
Bin
Anup Patel Nov. 21, 2018, 3:19 a.m. UTC | #2
On Tue, Nov 20, 2018 at 7:09 PM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> On Tue, Nov 20, 2018 at 7:29 PM Anup Patel <anup@brainfault.org> wrote:
> >
> > This patch adds S-mode defconfigs for QEMU virt machine so
> > that we can run u-boot in S-mode on QEMU using M-mode runtime
> > firmware (BBL or equivalent).
> >
> > Signed-off-by: Anup Patel <anup@brainfault.org>
> > ---
> >  configs/qemu-riscv32-smode_defconfig | 10 ++++++++++
> >  configs/qemu-riscv64-smode_defconfig | 11 +++++++++++
>
> nits: please use the name: qemu-riscv*_smode_defconfig (_ instead of -)

OK, I will update filename of defconfigs

>
> >  2 files changed, 21 insertions(+)
> >  create mode 100644 configs/qemu-riscv32-smode_defconfig
> >  create mode 100644 configs/qemu-riscv64-smode_defconfig
> >
>
> Please update board/emulation/qemu-riscv/MAINTAINERS to include these
> 2 defconfigs, otherwise buildman will report warnings.

Sure, I will update MAINTAINERS file.

>
> Other than that,
>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
> Tested-by: Bin Meng <bmeng.cn@gmail.com>
>

Thanks,
Anup
diff mbox series

Patch

diff --git a/configs/qemu-riscv32-smode_defconfig b/configs/qemu-riscv32-smode_defconfig
new file mode 100644
index 0000000000..0a84ec1874
--- /dev/null
+++ b/configs/qemu-riscv32-smode_defconfig
@@ -0,0 +1,10 @@ 
+CONFIG_RISCV=y
+CONFIG_TARGET_QEMU_VIRT=y
+CONFIG_RISCV_SMODE=y
+CONFIG_DISTRO_DEFAULTS=y
+CONFIG_NR_DRAM_BANKS=1
+CONFIG_FIT=y
+CONFIG_DISPLAY_CPUINFO=y
+CONFIG_DISPLAY_BOARDINFO=y
+# CONFIG_CMD_MII is not set
+CONFIG_OF_PRIOR_STAGE=y
diff --git a/configs/qemu-riscv64-smode_defconfig b/configs/qemu-riscv64-smode_defconfig
new file mode 100644
index 0000000000..b012443370
--- /dev/null
+++ b/configs/qemu-riscv64-smode_defconfig
@@ -0,0 +1,11 @@ 
+CONFIG_RISCV=y
+CONFIG_TARGET_QEMU_VIRT=y
+CONFIG_ARCH_RV64I=y
+CONFIG_RISCV_SMODE=y
+CONFIG_DISTRO_DEFAULTS=y
+CONFIG_NR_DRAM_BANKS=1
+CONFIG_FIT=y
+CONFIG_DISPLAY_CPUINFO=y
+CONFIG_DISPLAY_BOARDINFO=y
+# CONFIG_CMD_MII is not set
+CONFIG_OF_PRIOR_STAGE=y