Message ID | 20181118200732.10915-2-miquel.raynal@bootlin.com |
---|---|
State | Changes Requested |
Delegated to: | Jagannadha Sutradharudu Teki |
Headers | show |
Series | Remove MTD sub-directories from the root Makefile | expand |
On Sun, 18 Nov 2018 21:07:31 +0100 Miquel Raynal <miquel.raynal@bootlin.com> wrote: > Today way is to rely on CMD_NAND to be selected and from the root > Makefile compile what is in drivers/mtd/nand/raw. > > While this will work most of the time with decent configurations, it > is better to also compile this subsystem upon simple request in the > configuration. Otherwise, a user not selecting CMD_NAND but selecting > NAND and any of the controller drivers will not see their build. Fix > this weird situation by adding a single line in the nand/ directory > Kconfig file. > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > --- > drivers/mtd/nand/Makefile | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mtd/nand/Makefile b/drivers/mtd/nand/Makefile > index a358bc680e..2c33447995 100644 > --- a/drivers/mtd/nand/Makefile > +++ b/drivers/mtd/nand/Makefile > @@ -2,4 +2,5 @@ > > nandcore-objs := core.o bbt.o > obj-$(CONFIG_MTD_NAND_CORE) += nandcore.o > +obj-$(CONFIG_NAND) += raw/ Can we rename the Kconfig option into CONFIG_MTD_RAW_NAND to make it consistent with the other ones (should be done in a separate patch). Also, this patch breaks the build: the raw/ dir will be included twice, and the linker will complain about duplicate symbols. Note that your second patch fixes the bug introduce here, but I guess this is the reason this patch was no applied/accepted when initially submitted. > obj-$(CONFIG_MTD_SPI_NAND) += spi/
diff --git a/drivers/mtd/nand/Makefile b/drivers/mtd/nand/Makefile index a358bc680e..2c33447995 100644 --- a/drivers/mtd/nand/Makefile +++ b/drivers/mtd/nand/Makefile @@ -2,4 +2,5 @@ nandcore-objs := core.o bbt.o obj-$(CONFIG_MTD_NAND_CORE) += nandcore.o +obj-$(CONFIG_NAND) += raw/ obj-$(CONFIG_MTD_SPI_NAND) += spi/
Today way is to rely on CMD_NAND to be selected and from the root Makefile compile what is in drivers/mtd/nand/raw. While this will work most of the time with decent configurations, it is better to also compile this subsystem upon simple request in the configuration. Otherwise, a user not selecting CMD_NAND but selecting NAND and any of the controller drivers will not see their build. Fix this weird situation by adding a single line in the nand/ directory Kconfig file. Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> --- drivers/mtd/nand/Makefile | 1 + 1 file changed, 1 insertion(+)