| Message ID | 20181019220743.15020-22-lukas.auer@aisec.fraunhofer.de |
|---|---|
| State | Superseded |
| Delegated to: | Andes |
| Headers | show |
| Series | General fixes / cleanup for RISC-V and improvements to qemu-riscv | expand |
Hi Lukas, On Sat, Oct 20, 2018 at 6:10 AM Lukas Auer <lukas.auer@aisec.fraunhofer.de> wrote: > > CONFIG_INIT_CRITICAL is deprecated and not used for RISC-V. Remove it. > > Signed-off-by: Lukas Auer <lukas.auer@aisec.fraunhofer.de> > --- > > arch/riscv/cpu/start.S | 11 ----------- > 1 file changed, 11 deletions(-) > Please see my patch which does more :) http://git.denx.de/?p=u-boot/u-boot-x86.git;a=commitdiff;h=1f1c216d426a6c2196f8c39f5a2d85fe35096102 Regards, Bin
Hi Lukas, On Mon, Oct 22, 2018 at 5:19 PM Bin Meng <bmeng.cn@gmail.com> wrote: > > Hi Lukas, > > On Sat, Oct 20, 2018 at 6:10 AM Lukas Auer > <lukas.auer@aisec.fraunhofer.de> wrote: > > > > CONFIG_INIT_CRITICAL is deprecated and not used for RISC-V. Remove it. > > > > Signed-off-by: Lukas Auer <lukas.auer@aisec.fraunhofer.de> > > --- > > > > arch/riscv/cpu/start.S | 11 ----------- > > 1 file changed, 11 deletions(-) > > > > Please see my patch which does more :) > > http://git.denx.de/?p=u-boot/u-boot-x86.git;a=commitdiff;h=1f1c216d426a6c2196f8c39f5a2d85fe35096102 You can take my patch above in your v2 if you want. Regards, Bin
Hi Bin, On Thu, 2018-10-25 at 10:57 +0800, Bin Meng wrote: > Hi Lukas, > > On Mon, Oct 22, 2018 at 5:19 PM Bin Meng <bmeng.cn@gmail.com> wrote: > > > > Hi Lukas, > > > > On Sat, Oct 20, 2018 at 6:10 AM Lukas Auer > > <lukas.auer@aisec.fraunhofer.de> wrote: > > > > > > CONFIG_INIT_CRITICAL is deprecated and not used for RISC-V. > > > Remove it. > > > > > > Signed-off-by: Lukas Auer <lukas.auer@aisec.fraunhofer.de> > > > --- > > > > > > arch/riscv/cpu/start.S | 11 ----------- > > > 1 file changed, 11 deletions(-) > > > > > > > Please see my patch which does more :) > > > > http://git.denx.de/?p=u-boot/u-boot-x86.git;a=commitdiff;h=1f1c216d426a6c2196f8c39f5a2d85fe35096102 > > You can take my patch above in your v2 if you want. > > Regards, > Bin That looks very good! Yes, I'll replace this patch with yours in v2. Thanks, Lukas
diff --git a/arch/riscv/cpu/start.S b/arch/riscv/cpu/start.S index 88b4aaa1c0..f375a9316e 100644 --- a/arch/riscv/cpu/start.S +++ b/arch/riscv/cpu/start.S @@ -50,13 +50,6 @@ handle_reset: csrwi mstatus, 0 csrwi mie, 0 -/* - * Do CPU critical regs init only at reboot, - * not when booting from ram - */ -#ifdef CONFIG_INIT_CRITICAL - jal cpu_init_crit /* Do CPU critical regs init */ -#endif /* * Set stackpointer in internal/ex RAM to call board_init_f @@ -286,7 +279,3 @@ trap_entry: addi sp, sp, 32*REGBYTES mret -#ifdef CONFIG_INIT_CRITICAL -cpu_init_crit: - ret -#endif
CONFIG_INIT_CRITICAL is deprecated and not used for RISC-V. Remove it. Signed-off-by: Lukas Auer <lukas.auer@aisec.fraunhofer.de> --- arch/riscv/cpu/start.S | 11 ----------- 1 file changed, 11 deletions(-)