From patchwork Fri Sep 21 10:35:56 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ramon Fried X-Patchwork-Id: 973154 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="T8xGkjJf"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 42Gqth5Gyvz9s7T for ; Fri, 21 Sep 2018 20:42:52 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id 4FE5FC21C38; Fri, 21 Sep 2018 10:40:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_MSPIKE_H2, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 825E8C21E68; Fri, 21 Sep 2018 10:37:50 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 3154BC21E7E; Fri, 21 Sep 2018 10:36:56 +0000 (UTC) Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by lists.denx.de (Postfix) with ESMTPS id 6BA8DC21E96 for ; Fri, 21 Sep 2018 10:36:52 +0000 (UTC) Received: by mail-wr1-f67.google.com with SMTP id j8-v6so8627734wrw.5 for ; Fri, 21 Sep 2018 03:36:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=kzDh9Qz73hzx1L4NgQ7mHjYuLyCAZOaLERqHf/RepGw=; b=T8xGkjJfHGpaOiCDhOJ5wQRW4Ohii2FiXRDGB+G3ne7oeBFZCQjU6OkbEHFaImcGie 2NRSTaHPZZOdgDvur7nY+3CLmkJjV0zDwKc+A4IukibxWfPehedz8ti0cq+IOys4tK3c TpB0VULd9wypWvFFSn/tX9bgSLGGlmfq+yfI5rkwcW5GDCmPMHhDMHHUoYOHmuia4oh6 8Q4vpkhmOECHYcXAu2NPKkwZb4+SxO4Lp/O42FIxIIRRMO/uP0DfRIKBNVLguKoYRECk W138W3znIailJZSNbgOFUCkA3N5RXbB+UIOdtcAignYhBLjVHlV7MlY+TZO3QRHpQBh5 OA9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=kzDh9Qz73hzx1L4NgQ7mHjYuLyCAZOaLERqHf/RepGw=; b=e0Xqh7NXgbeuN9B0/97w7Xj/yYtM/166QLDarnhmvLJULnfJw6Uqfc3zeM3ftqPOR7 DHQnSTYWBAvsE6qZp8SXeQt9QM5kFuSzMRxnZvqz5GJESsv2W5KnAxuPdlPBsLe6ZWEX IzpkPJuQ/Sa8hEEQAVlZnC9yF1lSv6ARbopxoTY1/P3cmOM1HgCv1tycy+ItJStDVS46 9yYtpRvvttieGcECw8FxJnhY1UfKql109wv3oV8fd2dSSY5Ye5RJcbH3/qS1NM7Jnwx2 UpTxmknSVxI/RgmrfOGiyA+yA6Z0AHpOr+RGpa9wqlSgHj0lU+LFduKp9BY/1PrGAZQB A2jw== X-Gm-Message-State: APzg51DARFZracLwXkb9XAqRbQSPcBv+xdu3U7AINEufMftGyzxicyW2 UXawBHc7ZtdIcdmh2924TEUEIy5n+rSiqA== X-Google-Smtp-Source: ANB0VdaVnxUC0NzKUlwGo1nbyQMRiKP+GIhZMQbwZPRPV8TsYaufVFUmK/dJEsfEHrGMYnrCr/X+/g== X-Received: by 2002:a5d:62c2:: with SMTP id o2-v6mr11951738wrv.83.1537526211836; Fri, 21 Sep 2018 03:36:51 -0700 (PDT) Received: from localhost.localdomain ([5.102.238.49]) by smtp.gmail.com with ESMTPSA id 204-v6sm6770843wmh.25.2018.09.21.03.36.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 21 Sep 2018 03:36:51 -0700 (PDT) From: Ramon Fried To: u-boot@lists.denx.de Date: Fri, 21 Sep 2018 13:35:56 +0300 Message-Id: <20180921103555.16240-15-ramon.fried@gmail.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180921103555.16240-1-ramon.fried@gmail.com> References: <20180921103555.16240-1-ramon.fried@gmail.com> Cc: Marek Vasut Subject: [U-Boot] [PATCH v2 14/14] usb:ci_udc: don't overwrite configuration on pullup X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" change writel to writebits32 in ci_pullup() in order to keep phy configuration in tact. Signed-off-by: Ramon Fried Reviewed-by: Lukasz Majewski --- Changes in v2: Patch introduced drivers/usb/gadget/ci_udc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/gadget/ci_udc.c b/drivers/usb/gadget/ci_udc.c index 8d23fab3b7..0a84f6850d 100644 --- a/drivers/usb/gadget/ci_udc.c +++ b/drivers/usb/gadget/ci_udc.c @@ -906,7 +906,8 @@ static int ci_pullup(struct usb_gadget *gadget, int is_on) writel(0xffffffff, &udc->epflush); /* Turn on the USB connection by enabling the pullup resistor */ - writel(USBCMD_ITC(MICRO_8FRAME) | USBCMD_RUN, &udc->usbcmd); + setbits_le32(&udc->usbcmd, USBCMD_ITC(MICRO_8FRAME) | + USBCMD_RUN); } else { udc_disconnect(); }