diff mbox series

[U-Boot,v7,12/12] cmd: mtdparts: describe as legacy

Message ID 20180906070854.9717-13-miquel.raynal@bootlin.com
State Accepted
Delegated to: Jagannadha Sutradharudu Teki
Headers show
Series SPI-NAND support | expand

Commit Message

Miquel Raynal Sept. 6, 2018, 7:08 a.m. UTC
The 'mtdparts' command is not needed anymore. While the environment
variable is still valid (and useful, along with the 'mtdids' one), the
command has been replaced by 'mtd' which is much more close to the MTD
stack and do not add its own specific glue.

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Reviewed-by: Stefan Roese <sr@denx.de>
---
 cmd/Kconfig | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

Comments

Boris Brezillon Sept. 6, 2018, 9:57 a.m. UTC | #1
On Thu,  6 Sep 2018 09:08:54 +0200
Miquel Raynal <miquel.raynal@bootlin.com> wrote:

> The 'mtdparts' command is not needed anymore. While the environment
> variable is still valid (and useful, along with the 'mtdids' one), the
> command has been replaced by 'mtd' which is much more close to the MTD
> stack and do not add its own specific glue.
> 
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> Reviewed-by: Stefan Roese <sr@denx.de>
> ---
>  cmd/Kconfig | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/cmd/Kconfig b/cmd/Kconfig
> index f82addca0a..51dd058128 100644
> --- a/cmd/Kconfig
> +++ b/cmd/Kconfig
> @@ -1680,7 +1680,11 @@ config CMD_MTDPARTS
>  	bool "MTD partition support"
>  	select MTD_DEVICE if (CMD_NAND || NAND)
>  	help
> -	  MTD partition support
> +	  MTD partitioning tool support.
> +	  It is strongly encouraged to avoid using this command
> +	  anymore. One can still declare the partitions in the
> +	  mtdparts environment variable but better use the MTD stack
> +	  and the mtd command instead than this one.

Well, that's only working if people stop using nand,onenand,sf,...
commands in favor the mtd ones, otherwise they still need mtdparts,
unfortunately :-(.

I guess a long term goal could be to define aliases between flash
specific commands and the generic mtd ones so that we can get rid of
cmd/<flashcmd>.c drivers.

Regards,

Boris
diff mbox series

Patch

diff --git a/cmd/Kconfig b/cmd/Kconfig
index f82addca0a..51dd058128 100644
--- a/cmd/Kconfig
+++ b/cmd/Kconfig
@@ -1680,7 +1680,11 @@  config CMD_MTDPARTS
 	bool "MTD partition support"
 	select MTD_DEVICE if (CMD_NAND || NAND)
 	help
-	  MTD partition support
+	  MTD partitioning tool support.
+	  It is strongly encouraged to avoid using this command
+	  anymore. One can still declare the partitions in the
+	  mtdparts environment variable but better use the MTD stack
+	  and the mtd command instead than this one.
 
 config MTDIDS_DEFAULT
 	string "Default MTD IDs"