| Message ID | 20180831145741.17350-14-miquel.raynal@bootlin.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Jagannadha Sutradharudu Teki |
| Headers | show |
| Series | Cleaner MTD devices management | expand |
On 31.08.2018 16:57, Miquel Raynal wrote: > The 'mtdparts' command is not needed anymore. While the environment > variable is still valid (and useful), the command has been replaced by > 'mtd' which is much more close to the MTD stack and do not add its own > specific glue. The 'mtdids' variable, only used by the 'mtdparts' > command is also useless if the right MTD device name is used in the > 'mtdparts' variable. > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > --- > cmd/Kconfig | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/cmd/Kconfig b/cmd/Kconfig > index 4deec0b238..0786663f4a 100644 > --- a/cmd/Kconfig > +++ b/cmd/Kconfig > @@ -1673,7 +1673,11 @@ config CMD_MTDPARTS > bool "MTD partition support" > select MTD_DEVICE if (CMD_NAND || NAND) > help > - MTD partition support > + MTD partitioning tool support. > + It is strongly encouraged to avoid using this command > + anymore. One can still declare the partitions in the > + mtdparts environment variable but better use the MTD stack > + and the mtd command instead than this one. > > config MTDIDS_DEFAULT > string "Default MTD IDs" > @@ -1681,6 +1685,10 @@ config MTDIDS_DEFAULT > help > Defines a default MTD IDs list for use with MTD partitions in the > Linux MTD command line partitions format. > + Declaration of this environment variable is not useful > + anymore when using the right MTD names in mtdparts along > + with the use of the 'mtd' command instead of the legacy > + 'mtdparts'. > > config MTDPARTS_DEFAULT > string "Default MTD partition scheme" > Very nice work overall. :) Reviewed-by: Stefan Roese <sr@denx.de> Thanks, Stefan
diff --git a/cmd/Kconfig b/cmd/Kconfig index 4deec0b238..0786663f4a 100644 --- a/cmd/Kconfig +++ b/cmd/Kconfig @@ -1673,7 +1673,11 @@ config CMD_MTDPARTS bool "MTD partition support" select MTD_DEVICE if (CMD_NAND || NAND) help - MTD partition support + MTD partitioning tool support. + It is strongly encouraged to avoid using this command + anymore. One can still declare the partitions in the + mtdparts environment variable but better use the MTD stack + and the mtd command instead than this one. config MTDIDS_DEFAULT string "Default MTD IDs" @@ -1681,6 +1685,10 @@ config MTDIDS_DEFAULT help Defines a default MTD IDs list for use with MTD partitions in the Linux MTD command line partitions format. + Declaration of this environment variable is not useful + anymore when using the right MTD names in mtdparts along + with the use of the 'mtd' command instead of the legacy + 'mtdparts'. config MTDPARTS_DEFAULT string "Default MTD partition scheme"
The 'mtdparts' command is not needed anymore. While the environment variable is still valid (and useful), the command has been replaced by 'mtd' which is much more close to the MTD stack and do not add its own specific glue. The 'mtdids' variable, only used by the 'mtdparts' command is also useless if the right MTD device name is used in the 'mtdparts' variable. Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> --- cmd/Kconfig | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)