diff mbox series

[U-Boot,v6,22/31] cmd: ubi: delete useless and misleading definitions

Message ID 20180816153029.15521-23-miquel.raynal@bootlin.com
State Superseded
Delegated to: Jagannadha Sutradharudu Teki
Headers show
Series SPI-NAND support | expand

Commit Message

Miquel Raynal Aug. 16, 2018, 3:30 p.m. UTC
These definitions are simply not used and are misleading because similar
definitions exist in jffs2/load_kernel.h and are used widely to define
MTD device types (which is, by the way, totally redundant with what the
MTD core does). Remove these definitions.

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Acked-by: Jagan Teki <jagan@openedev.com>
---
 cmd/ubi.c | 5 -----
 1 file changed, 5 deletions(-)

Comments

Boris Brezillon Aug. 16, 2018, 3:50 p.m. UTC | #1
On Thu, 16 Aug 2018 17:30:20 +0200
Miquel Raynal <miquel.raynal@bootlin.com> wrote:

> These definitions are simply not used and are misleading because similar
> definitions exist in jffs2/load_kernel.h and are used widely to define
> MTD device types (which is, by the way, totally redundant with what the
> MTD core does). Remove these definitions.
> 
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> Acked-by: Jagan Teki <jagan@openedev.com>

Reviewed-by: Boris Brezillon <boris.brezillon@bootlin.com>

> ---
>  cmd/ubi.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/cmd/ubi.c b/cmd/ubi.c
> index 913f0f71fd..0a3405a3b1 100644
> --- a/cmd/ubi.c
> +++ b/cmd/ubi.c
> @@ -27,11 +27,6 @@
>  #undef ubi_msg
>  #define ubi_msg(fmt, ...) printf("UBI: " fmt "\n", ##__VA_ARGS__)
>  
> -#define DEV_TYPE_NONE		0
> -#define DEV_TYPE_NAND		1
> -#define DEV_TYPE_ONENAND	2
> -#define DEV_TYPE_NOR		3
> -
>  /* Private own data */
>  static struct ubi_device *ubi;
>  static char buffer[80];
diff mbox series

Patch

diff --git a/cmd/ubi.c b/cmd/ubi.c
index 913f0f71fd..0a3405a3b1 100644
--- a/cmd/ubi.c
+++ b/cmd/ubi.c
@@ -27,11 +27,6 @@ 
 #undef ubi_msg
 #define ubi_msg(fmt, ...) printf("UBI: " fmt "\n", ##__VA_ARGS__)
 
-#define DEV_TYPE_NONE		0
-#define DEV_TYPE_NAND		1
-#define DEV_TYPE_ONENAND	2
-#define DEV_TYPE_NOR		3
-
 /* Private own data */
 static struct ubi_device *ubi;
 static char buffer[80];