diff mbox series

[U-Boot,1/2] ARM: kirkwood: Enforce size limit for sheevaplug

Message ID 20180604075150.7973-1-judge.packham@gmail.com
State Accepted
Commit 84035fccbe54af1d0513e6288e08a45885ee872c
Delegated to: Stefan Roese
Headers show
Series [U-Boot,1/2] ARM: kirkwood: Enforce size limit for sheevaplug | expand

Commit Message

Chris Packham June 4, 2018, 7:51 a.m. UTC
The u-boot binary sits in flash immediately before the environment.
Don't allow the binary size to grow into the environment space.

Signed-off-by: Chris Packham <judge.packham@gmail.com>
---
This will actually result in a build failure. Which is what we want, at
least until https://lists.denx.de/pipermail/u-boot/2018-June/330467.html
is merged.

 include/configs/sheevaplug.h | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Stefan Roese June 4, 2018, 8:05 a.m. UTC | #1
On 04.06.2018 09:51, Chris Packham wrote:
> The u-boot binary sits in flash immediately before the environment.
> Don't allow the binary size to grow into the environment space.
> 
> Signed-off-by: Chris Packham <judge.packham@gmail.com>
> ---
> This will actually result in a build failure. Which is what we want, at
> least until https://lists.denx.de/pipermail/u-boot/2018-June/330467.html
> is merged.
> 
>   include/configs/sheevaplug.h | 5 +++++
>   1 file changed, 5 insertions(+)

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan
Stefan Roese June 5, 2018, 9:26 a.m. UTC | #2
On 04.06.2018 09:51, Chris Packham wrote:
> The u-boot binary sits in flash immediately before the environment.
> Don't allow the binary size to grow into the environment space.
> 
> Signed-off-by: Chris Packham <judge.packham@gmail.com>

Applied to u-boot-marvell/master.

Thanks,
Stefan
diff mbox series

Patch

diff --git a/include/configs/sheevaplug.h b/include/configs/sheevaplug.h
index 23dd5ceb7cb9..dc6375841ed8 100644
--- a/include/configs/sheevaplug.h
+++ b/include/configs/sheevaplug.h
@@ -44,6 +44,11 @@ 
 #define CONFIG_ENV_SIZE			0x20000	/* 128k */
 #define CONFIG_ENV_ADDR			0x80000
 #define CONFIG_ENV_OFFSET		0x80000	/* env starts here */
+/*
+ * Environment is right behind U-Boot in flash. Make sure U-Boot
+ * doesn't grow into the environment area.
+ */
+#define CONFIG_BOARD_SIZE_LIMIT		CONFIG_ENV_OFFSET
 
 /*
  * Default environment variables