From patchwork Sat May 12 10:15:53 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ramon Fried X-Patchwork-Id: 912406 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="N7re/mbp"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 40jjcZ1bRLz9rxs for ; Sat, 12 May 2018 20:19:26 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id C341AC2241E; Sat, 12 May 2018 10:17:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H2, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 4AC27C223D2; Sat, 12 May 2018 10:16:36 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 6604AC22432; Sat, 12 May 2018 10:16:28 +0000 (UTC) Received: from mail-wr0-f193.google.com (mail-wr0-f193.google.com [209.85.128.193]) by lists.denx.de (Postfix) with ESMTPS id 767B1C223FA for ; Sat, 12 May 2018 10:16:24 +0000 (UTC) Received: by mail-wr0-f193.google.com with SMTP id g21-v6so7548128wrb.8 for ; Sat, 12 May 2018 03:16:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=8/yFma+7iFetOfMTrxxAW3b4wPtlcsSQE/d7mtSLObw=; b=N7re/mbpFmsS9oyyhXVTiX+tkM0StZLpHC2OZGuu3OKlr/d6npsnY/ekJZzQDRahqX lcCkWa3i/Pm2dZQQfMdFXZitIZvQJC6iffs8KOGWgK64n2K6D/5PUiQrdCYh4TxjO7Ul 1ugzA4OCoz/4l3lPU5EHS8sflWt6upWu3EAhdbdJTqRtGFN7VaxKwFAk8XNq9CR8hKKL L9XuEDSGIT21smEHgkfIud3h8oL40wsdicLYjqbT2U5+0W4FjuzbaCZAUObsBUTzOoZF xPOcyHfrOq9pQ7u/ax1XL3raawkf8dQGP8pSfiiB1OfX8L6ANnmWT4RUC/vy1LoT8tnl vofw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=8/yFma+7iFetOfMTrxxAW3b4wPtlcsSQE/d7mtSLObw=; b=BS672MRWZ35A+Z8Jr8NwSKN6cpl8Jvko+2wQApesZY20WgqtMZFXFm+JktQTI0HDd3 hmlsfP+XUPYM6sX6buKCAPQQmv4ewTl80bnUuAO+Vi2PEwjO864QqqGiJSCvnpUFHcpQ emi9Yk++r2v6n3foP4Cs1tXzgrI1Vpz6GMZBq+QkYsVvdJzV1aLRdIpSEYPMmkvTO6Jf FGVqjOYozPAFwWMLlc33ztrUTf+x08RRI7S9KCUdIhk/74us3BYz0D5i5SmexnfpRU49 Ff5m+TeqCcHvuqvxXClCxS+E7GuIQfJLKXIQ8vZXORXmsEHlizbK4eE0Kd+cH+7ksC/d h+3Q== X-Gm-Message-State: ALKqPwfAtUq+G1Bk8ZBWXG/u2XNP1i3WcyltvkfE2PHcTq9ehoTSlbKY 8G1l2u0UjWv4yWnAwqrLLUW4/mYQedk= X-Google-Smtp-Source: AB8JxZqfPeF5yISmcijHrJw5oMExzB++XwCAWF5b5T4m/IgWBvdBStlgxODM6Z7eKhydXSnf9zniVw== X-Received: by 2002:adf:d1cc:: with SMTP id m12-v6mr1834188wri.214.1526120184167; Sat, 12 May 2018 03:16:24 -0700 (PDT) Received: from localhost.localdomain ([141.226.166.38]) by smtp.gmail.com with ESMTPSA id h67-v6sm2881280wmg.41.2018.05.12.03.16.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 12 May 2018 03:16:23 -0700 (PDT) From: Ramon Fried To: albert.u.boot@aribaud.net, mateusz.kulikowski@gmail.com, jramirez@baylibre.com, robdclark@gmail.com, sjg@chromium.org Date: Sat, 12 May 2018 13:15:53 +0300 Message-Id: <20180512101558.24375-3-ramon.fried@gmail.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20180512101558.24375-1-ramon.fried@gmail.com> References: <20180512101558.24375-1-ramon.fried@gmail.com> Cc: u-boot@lists.denx.de Subject: [U-Boot] [PATCH 2/7] serial: serial_msm: fail probe if settings clocks fails X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Failure to set the clocks will causes data abort exception when trying to write to AHB uart registers. This patch ensures that we don't touch these registers if clock setting failed. Signed-off-by: Ramon Fried --- drivers/serial/serial_msm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/serial/serial_msm.c b/drivers/serial/serial_msm.c index 119e6b9846..250e48c996 100644 --- a/drivers/serial/serial_msm.c +++ b/drivers/serial/serial_msm.c @@ -183,8 +183,8 @@ static int msm_serial_probe(struct udevice *dev) { struct msm_serial_data *priv = dev_get_priv(dev); - msm_uart_clk_init(dev); /* Ignore return value and hope clock was - properly initialized by earlier loaders */ + if (msm_uart_clk_init(dev)) + return -EINVAL; if (readl(priv->base + UARTDM_SR) & UARTDM_SR_UART_OVERRUN) writel(UARTDM_CR_CMD_RESET_ERR, priv->base + UARTDM_CR);