diff mbox series

[U-Boot,3/3] sunxi: Add extra I2C bus support to Ainol AW1 defconfig

Message ID 20180325123601.12125-3-contact@paulk.fr
State Changes Requested
Delegated to: Jagannadha Sutradharudu Teki
Headers show
Series [U-Boot,1/3] arm: dts: sun7i: Update Ainol AW1 dts | expand

Commit Message

Paul Kocialkowski March 25, 2018, 12:36 p.m. UTC
Spam detection software, running on the system "lists.denx.de",
has identified this incoming email as possible spam.  The original
message has been attached to this so you can view it or label
similar future email.  If you have any questions, see
@@CONTACT_ADDRESS@@ for details.

Content preview:  I2C bus 1 is used for the accelerometer and i2c bus 2 for
  the touchscreen of the device. While these are not supported in U-Boot, its
   command line can be used to access these peripherals. Signed-off-by: Paul
   Kocialkowski <contact@paulk.fr> --- configs/Ainol_AW1_defconfig | 2 ++ 1
  file changed, 2 insertions(+) [...] 

Content analysis details:   (5.2 points, 5.0 required)

 pts rule name              description
---- ---------------------- --------------------------------------------------
 1.3 RCVD_IN_RP_RNBL        RBL: Relay in RNBL,
                            https://senderscore.org/blacklistlookup/
                           [77.128.107.220 listed in bl.score.senderscore.com]
 0.0 RCVD_IN_SORBS_DUL      RBL: SORBS: sent directly from dynamic IP address
                            [77.128.107.220 listed in dnsbl.sorbs.net]
 3.6 RCVD_IN_PBL            RBL: Received via a relay in Spamhaus PBL
                            [77.128.107.220 listed in zen.spamhaus.org]
 0.4 RDNS_DYNAMIC           Delivered to internal network by host with
                            dynamic-looking rDNS
I2C bus 1 is used for the accelerometer and i2c bus 2 for the
touchscreen of the device. While these are not supported in U-Boot, its
command line can be used to access these peripherals.

Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
---
 configs/Ainol_AW1_defconfig | 2 ++
 1 file changed, 2 insertions(+)

Comments

Maxime Ripard March 26, 2018, 11:10 a.m. UTC | #1
On Sun, Mar 25, 2018 at 02:36:01PM +0200, Paul Kocialkowski wrote:
> I2C bus 1 is used for the accelerometer and i2c bus 2 for the
> touchscreen of the device. While these are not supported in U-Boot, its
> command line can be used to access these peripherals.
> 
> Signed-off-by: Paul Kocialkowski <contact@paulk.fr>

I'm not sure what the use case would be for U-Boot though. I guess you
can always enable it through menuconfig if you really want it, but
there's no real need for it in the default configuration.

Maxime
Paul Kocialkowski March 26, 2018, 12:34 p.m. UTC | #2
Hi,

On Mon, 2018-03-26 at 13:10 +0200, Maxime Ripard wrote:
> On Sun, Mar 25, 2018 at 02:36:01PM +0200, Paul Kocialkowski wrote:
> > I2C bus 1 is used for the accelerometer and i2c bus 2 for the
> > touchscreen of the device. While these are not supported in U-Boot,
> > its
> > command line can be used to access these peripherals.
> > 
> > Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> 
> I'm not sure what the use case would be for U-Boot though. I guess you
> can always enable it through menuconfig if you really want it, but
> there's no real need for it in the default configuration.

Fair enough, I'll drop this patch.

Cheers,
diff mbox series

Patch

diff --git a/configs/Ainol_AW1_defconfig b/configs/Ainol_AW1_defconfig
index 9fb464b703..87f14b0ea5 100644
--- a/configs/Ainol_AW1_defconfig
+++ b/configs/Ainol_AW1_defconfig
@@ -4,6 +4,8 @@  CONFIG_MACH_SUN7I=y
 CONFIG_DRAM_CLK=432
 CONFIG_DRAM_ZQ=123
 CONFIG_MMC0_CD_PIN="PH1"
+CONFIG_I2C1_ENABLE=y
+CONFIG_I2C2_ENABLE=y
 CONFIG_USB0_VBUS_PIN="PB9"
 CONFIG_USB0_VBUS_DET="AXP0-VBUS-DETECT"
 CONFIG_USB0_ID_DET="PH4"