From patchwork Fri Mar 23 11:08:02 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rasmus Villemoes X-Patchwork-Id: 889911 X-Patchwork-Delegate: sbabic@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=prevas.dk Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=prevasonline.onmicrosoft.com header.i=@prevasonline.onmicrosoft.com header.b="moAVwINE"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 40714J3Ymvz9s0b for ; Fri, 23 Mar 2018 22:08:32 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id E9DEEC21D8E; Fri, 23 Mar 2018 11:08:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAD_ENC_HEADER, SPF_HELO_PASS, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id E5CE8C21C8B; Fri, 23 Mar 2018 11:08:19 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 63787C21D56; Fri, 23 Mar 2018 11:08:18 +0000 (UTC) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0107.outbound.protection.outlook.com [104.47.2.107]) by lists.denx.de (Postfix) with ESMTPS id ED4F7C21BE5 for ; Fri, 23 Mar 2018 11:08:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=prevasonline.onmicrosoft.com; s=selector1-prevas-se; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=YzqwxOgQmoqi6VokeJIC23+iIUmr9BB8Yr7gN3Lss+4=; b=moAVwINE7zKojDUcRx/La92QzCOC6kb6dZ927OkZwDChrRH6RCvlXeTQtb9q8yzzTcU7+PI/IymNKV71JK7supVApiJmpYVqD2u6VOsKCcHCB3mO0iCn4fALzTOsAw2V9b8qFmygWu77tLUB+n81Q3u6OO/SNOIt8VajSeaPYYk= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Rasmus.Villemoes@prevas.se; Received: from prevas-ravi.prevas.se (81.216.59.226) by AM5PR10MB0433.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:203:25::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.609.10; Fri, 23 Mar 2018 11:08:16 +0000 From: Rasmus Villemoes To: u-boot@lists.denx.de Date: Fri, 23 Mar 2018 12:08:02 +0100 Message-Id: <20180323110803.16512-1-rasmus.villemoes@prevas.dk> X-Mailer: git-send-email 2.15.1 MIME-Version: 1.0 X-Originating-IP: [81.216.59.226] X-ClientProxiedBy: HE1PR0402CA0012.eurprd04.prod.outlook.com (2603:10a6:3:d0::22) To AM5PR10MB0433.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:203:25::19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3cfbcd99-24d1-4561-0fec-08d590ae60f8 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4604075)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:AM5PR10MB0433; X-Microsoft-Exchange-Diagnostics: 1; AM5PR10MB0433; 3:Qc735ceeEgvKGzmeE4I9hOZZ0Bb4/rZSVx9uveMuv5C/Iz12QXBqChEMDB/1QvuF5Es2sUi/S2+SHUgfEzTchb5tZ8kygdzE7uk1L6p7OeDS5PdE+wMgy2cSuwb3g0ptRyoTElHLurenWuiAHRdrcARxPm69cGq6xIfBI7KOYgjSlFH2X9YaoaIrtYzVqoMt/UnrlXCOdNd/8MaDOpKF5gfDy9b4Q7NVgOh58zw5AYv2QBXTUhf8Vdv1vSmByQyr; 25:dyvrXS+VB8mbUdD+NehXdKPVKYeg4h1Qvtirqrcjz1HILX1I7WMPHjF1AOWecVfb25QLzdfBobcpKUr2+BP/skF9HnO1CBXPl1FFngm1GVsWkZ8jpWdDmcCF8Lc6K71keg+VPCSHdnCEgtqowWb2DVq5Po9mFMSfiwNzI/2T64EJoitoHlqQzejowFHbfAyMO2PKJjQviEXUlb/Pp3s6rP7omZtdre2TbxJsSS1vmRtAsaEAy//q+N59hFz5uSIsQSQCUb38AJepC1Kdi300/Psm9yTlThLvufTuZ3u8BpeE+srtg/E/zrqYGl6T/Gzufdw5hekUTnJUXVe3TnMtbQ==; 31:0g3ukCPoXM/hWdgcsOpML1RJqUuX9dmkqJdYuGUQ7pWLElz0rfvRFyIlcdr8/qgKnSRAv4o+KcalEqnOTAKctrFAhFnjoZP66sINQ3hYrGZL5CfgFy+/WJ1jb/gmRrtL0zu+YXQhTvATPzucuWbR80oHTpnSCjwK6AQPlvrc2Vsg4oL2Uv/HSMwvG0Hgk/jBlSo1ZY/+89u5/vrgY4qBzhL3ln2nIBuA7NxwHm6yWd0= X-MS-TrafficTypeDiagnostic: AM5PR10MB0433: X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(5005006)(8121501046)(93006095)(3231221)(944501327)(52105095)(10201501046)(3002001)(6041310)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123558120)(20161123562045)(6072148)(201708071742011); SRVR:AM5PR10MB0433; BCL:0; PCL:0; RULEID:; SRVR:AM5PR10MB0433; X-Microsoft-Exchange-Diagnostics: 1; AM5PR10MB0433; 4:PmwlOtl7l0hSwNMeLJnGFiraja7vhkr4zkYntBNpog/lnUWvUDlyTffSmu0BGGZNCMmu/jlSG1K8/H6Zckec95dsGzfZ6JbB2HdkZpJ+fAzY0CBHnrPX+SzTNS9jSMSPahCTNe/UQ7cGHhaUfjTFRvTgylMzvd0nfvaGcQHfL/bh9lJ7nB7HdW6wEvpcctWA7ORkR4oPdPKwJh8EaLNflLku9vegwQTotScAeJoDMwwQZRwu2XiieLq+AwFW9Iit2os9WnjLD5NiUoDD3ijVkw== X-Forefront-PRVS: 0620CADDF3 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(366004)(346002)(376002)(39850400004)(39380400002)(396003)(189003)(199004)(7736002)(8936002)(107886003)(97736004)(50466002)(36756003)(2351001)(2361001)(5660300001)(50226002)(2906002)(386003)(68736007)(48376002)(6916009)(6116002)(8976002)(66066001)(3846002)(42882007)(47776003)(6666003)(305945005)(6512007)(4326008)(16526019)(74482002)(6506007)(54906003)(26005)(6486002)(53416004)(106356001)(1076002)(478600001)(16586007)(186003)(53936002)(316002)(81156014)(81166006)(69596002)(52116002)(25786009)(8676002)(8656006)(105586002)(51416003)(72206003); DIR:OUT; SFP:1102; SCL:1; SRVR:AM5PR10MB0433; H:prevas-ravi.prevas.se; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: prevas.se does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM5PR10MB0433; 23:x0EUcT+Gyy66gdSKy4DoCr60QAJrkhPPGvo2z4p8G?= H8gvI7ftOGqrWguVTtKTpoAVHqY+ylSZccHJEhxmAeA1GgkAn+sekvmUUSKyaMTr6xwmEz+NEQGHzHjV2+PL13o3PD3v3JtaCre0FcO6pUD31mB6McoR/3DWpEZHlLYqLzuRKvgektolaDqtwbX09sJjsLdmMk+qo7dCGQHcKv6h76yOTRiNcoTRDMCYHQ3NCDuI4L2jZJCi1osdtgnVr8bABeKvxJ/sk41jUu+ZnBGuvDW6jtjb3rao9ZN5gc9FpSoxhL90vPxrPu79sZ/KztRfMMaQelKhU1yarm621o7IfBp3Voo3xcN3q5XidWlJc6QYEk8aG4AQV9IV8/Xvm/7ik+ggvrH8buWaU7i8S2vdziIi8bIMZXI+sRJgxy7uDiiFMj531+wZbdiYZk4XPYPDikusTMSGDuvNnw+SixFH1SOwtNm8j/GIoH0clnQ2ttSc6Bt54XW0dBHmQx1nBJQyw1GSbsoIHOmJI+VG7QlSP9bC7zxiTBZmesJ71WvetoxR9376K4MzDOjbaBv/Qx6HBAS9VE0DlncLDSkqbfNUd2lo9Xoni7h9v1Zjv0eAoRo7o5CG2KJnVvET6QGFqkekOlNaqaOF7bfRvUINL/4iraD+YnIaQx25+ssoDpY4zpKAIvP/CvIABvrNqTCFKJUUZx9pHybz4GI6JcmoeSFkNenIw9zif79hciSs9CAK/91C5uP6smK4fEQuOUYwgBWw5iBqGTM/q1KUcPQYbf7XPds+PGpyo2yOKVv+UJslMDa3QDchGyOz5D3BCRq1trQyiDkAg0Px/ons/PBhXf/EqDbD6jNVbWk/K0cxB7LnZO6Qnhgr6qRHYIRmBMnRYOSlZ57FfRqIamCfpdL/Bif+1/WQSgcu7MgDG0aRm3qaPndf24HKxkKwN/nkOmfMJlLavDoGqk8HIa4bwMyDgxmdi112ZvqOqnaJNN0SDsoXj1JNYK3/6tYvlcUf1p5n2HnlxI5nbwvNlxJIYTf/uYoBkazmoBk/Nr9NkIWpi0YKajfWfjamqjsX2s+h/AhmXfHxnxuNSPul6M7ZL97o8DHMjw+arA2CbiL50M401aIz8n750kkLmOY4uCDubWTd29NkZ85niqyA/06nPHCX6L3UMWZSmu1rxviqqlq2YheThyWDHP7vsQad4soPa1h1SxfchPEVVS6eW0IErgAnmZr+FtDnWOh9bd9bZscWi6fS+WLsnBzvuQoCoAaRKQUDlhN X-Microsoft-Antispam-Message-Info: VNKAW8zZbJPAkRBzuw+I3JwBhgGqBjwc3CRRpPYu2BcMlDByUjmKTEbbuqwrGAshnH2lS4Rppse5Ge/z6Zool+dweRT6jELWjHvs/ypv25XggzTIT+FciMDkUKTmA06AiWEEGU2mDsA3x/1V5rzL772XrS45tg7PcCxvYZ37VlHKaD49F38oAI3rX7e8huAf X-Microsoft-Exchange-Diagnostics: 1; AM5PR10MB0433; 6:UbyIuc8nsfgLlK0awxIUSRYFP79HatE+gWKXOD0DsW1Z6gyAI66cnUX/LY0sKJNU43ey2iCUFCZ3n2jWOssd/5wuAkES2FqGektoEZmhx4ZHbInZnM2XdDJqlikvH21vDaM9ySEy1LcB7lDmyhHZzSLsPXxA7uAnn4x1WObL5f5t4BRKBO7HZ29wSMsASAYEVFpLdUdH+JFzK3BvJmRZwUMjqT3h9hSZTp9KaOiNjei5qBusvOH7CaH9/ABEjRmsNZfjCwi2UJ4/4nanCi255az3Gd6xYG48bxWwhdb0h9Cd+EEO3JhMY/eaS8DYPUgF0pHNdaidkkfaJs2oOqDd8JvHAec4I3CSUadUwAwRq7nGNiD+M/wmknGF82H3bnwT2fPU4uE7eXTGEbakGIz2wtpVuY1wPVlX9DESxVd8+FN/j2TFVylonWNj98D3ZnDHetmcnyBsIuY63WRY5Ht8jQ==; 5:eIXe/cBnqzVyQwyOD3Nw5YiwIPatWeNYbn7/Hzjmw8JhmXkvZbSyZVrjFFq2uzr9wXsjfzMe7HAdVT9iWPKdZdTkiVmt8ZfiEh3w87bcq+MFokuXyIi8PxO6/Im+qT3pPSXvHwivekVslw7JkXcG5m8uv+NXAmQV/yNBBlu2sZA=; 24:c4UI7pJ5+pKJEwJeeKqu1jnqXlisoWItqM2gXVkWmTimtjpY3YGJGXDVbtIUxK6CZ7Gx7Rs9tqcluqt227NoL6joTyBCrNSdo58EiuadXL8= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; AM5PR10MB0433; 7:oWPfJQ+plWxREqRgecGSkdqxF4CnRq9ZV6OkwRWl+X5ul16O4Z7731hpzhv8QvAgaax2/7IUD/zzWytBCZXtVbp1NhA0fUCG15XsQUzKf2M5BnFFTOWLkgTcnOvjaTCOIKQHl5lvpEdw2OiQfoA7NqhBIhGPWR5vDpa6odVr5dosaAoQzAW0U+yl8335S6npKwPrjp2n4zm2SFEPeY5/7ExQ/aI5ILQ2R9dCJrW6jcUr3aVShsF4s3AM/QjMJlKi X-OriginatorOrg: prevas.dk X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2018 11:08:16.4778 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3cfbcd99-24d1-4561-0fec-08d590ae60f8 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: d350cf71-778d-4780-88f5-071a4cb1ed61 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR10MB0433 Cc: Fabio Estevam Subject: [U-Boot] [PATCH 1/2] Makefile: always preserve output for images that can contain HAB Blocks X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" The current makefile logic disables creation of the SPL.log/u-boot-ivt.img.log etc. files when V=1 is given on the command line, the rationale presumably being that the user wants and gets the information on the console. However, from general principles, I don't think a higher V= level should affect which build artifacts get generated (and certainly shouldn't produce fewer). Concretely, it's also a problem that when doing a V=1 build in a terminal, the relevant HAB blocks lines easily drown in all the other V=1 output. Moreover, build systems such as Yocto by default pass V=1, so in that case the information gets hidden away in the do_compile log file, making it nigh impossible to create a recipe for creating signed U-boot images - I don't want to disable V=1, because having verbose output in the log file is valuable when things go wrong, but OTOH trying to go digging in the do_compile log file (and getting exactly the right lines) is not pleasant to even think about. So change the logic so that for V=0, the mkimage output is redirected to MKIMAGEOUTPUT (which is also the current behaviour), while for any other value of V, we _additionally_ write the information to make's stdout, whatever that might be. Signed-off-by: Rasmus Villemoes Tested-by: Breno Lima --- Makefile | 4 ++-- scripts/Makefile.lib | 2 +- scripts/Makefile.spl | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Makefile b/Makefile index 5fa14789d9..a63dc96e57 100644 --- a/Makefile +++ b/Makefile @@ -845,11 +845,11 @@ MKIMAGEOUTPUT ?= /dev/null quiet_cmd_mkimage = MKIMAGE $@ cmd_mkimage = $(objtree)/tools/mkimage $(MKIMAGEFLAGS_$(@F)) -d $< $@ \ - $(if $(KBUILD_VERBOSE:1=), >$(MKIMAGEOUTPUT)) + >$(MKIMAGEOUTPUT) $(if $(KBUILD_VERBOSE:0=), && cat $(MKIMAGEOUTPUT)) quiet_cmd_mkfitimage = MKIMAGE $@ cmd_mkfitimage = $(objtree)/tools/mkimage $(MKIMAGEFLAGS_$(@F)) -f $(U_BOOT_ITS) -E $@ \ - $(if $(KBUILD_VERBOSE:1=), >$(MKIMAGEOUTPUT)) + >$(MKIMAGEOUTPUT) $(if $(KBUILD_VERBOSE:0=), && cat $(MKIMAGEOUTPUT)) quiet_cmd_cat = CAT $@ cmd_cat = cat $(filter-out $(PHONY), $^) > $@ diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib index 8f21653136..c6b3f69064 100644 --- a/scripts/Makefile.lib +++ b/scripts/Makefile.lib @@ -521,7 +521,7 @@ cmd_xzmisc = (cat $(filter-out FORCE,$^) | \ MKIMAGEOUTPUT ?= /dev/null quiet_cmd_mkimage = MKIMAGE $@ cmd_mkimage = $(objtree)/tools/mkimage $(MKIMAGEFLAGS_$(@F)) -d $< $@ \ - $(if $(KBUILD_VERBOSE:1=), >$(MKIMAGEOUTPUT)) + >$(MKIMAGEOUTPUT) $(if $(KBUILD_VERBOSE:0=), && cat $(MKIMAGEOUTPUT)) # fdtgrep # --------------------------------------------------------------------------- diff --git a/scripts/Makefile.spl b/scripts/Makefile.spl index 2993ade41e..7f2908d799 100644 --- a/scripts/Makefile.spl +++ b/scripts/Makefile.spl @@ -144,7 +144,7 @@ MKIMAGEOUTPUT ?= /dev/null quiet_cmd_mkimage = MKIMAGE $@ cmd_mkimage = $(objtree)/tools/mkimage $(MKIMAGEFLAGS_$(@F)) -d $< $@ \ - $(if $(KBUILD_VERBOSE:1=), >$(MKIMAGEOUTPUT)) + >$(MKIMAGEOUTPUT) $(if $(KBUILD_VERBOSE:0=), && cat $(MKIMAGEOUTPUT)) MKIMAGEFLAGS_MLO = -T omapimage -a $(CONFIG_SPL_TEXT_BASE)