From patchwork Sun Jan 14 23:46:12 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Beno=C3=AEt_Th=C3=A9baudeau?= X-Patchwork-Id: 860559 X-Patchwork-Delegate: jh80.chung@samsung.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Psoi4Jas"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 3zKY6g14f8z9s7h for ; Mon, 15 Jan 2018 10:46:49 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id 439EDC21EFF; Sun, 14 Jan 2018 23:46:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_MSPIKE_H2, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 2568FC21CA6; Sun, 14 Jan 2018 23:46:42 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 7271CC21CA6; Sun, 14 Jan 2018 23:46:40 +0000 (UTC) Received: from mail-wr0-f196.google.com (mail-wr0-f196.google.com [209.85.128.196]) by lists.denx.de (Postfix) with ESMTPS id 233D8C21C2F for ; Sun, 14 Jan 2018 23:46:40 +0000 (UTC) Received: by mail-wr0-f196.google.com with SMTP id 100so10024846wrb.7 for ; Sun, 14 Jan 2018 15:46:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=lppeHvcjG06aApr971Ja3PmMURmi7lKDO8m2mtQZ1Ug=; b=Psoi4JasFiMPeaMSvsa7kjFrabiVQ7AubOXgQojnByMKBss47ble5CHIiT3Y4sxwIJ zeK8dcq1CQhK+CkBUrXud5UGZqvZUyJjpb/OHgk5ImO+qYQRJoT7qH0f1KmBUjXjcLDN KP5qV8W0ahlgQ6U1kMTVjZuhw8Q1VzplULr03LNhOphNArw1Mg3B9PlrzMADUNRVfgtO HiuSOwJv0sHnjpCXMOGl58oq3NHYJCapyTPTHU6jFPzt2YFHxAJmcaio7PZTYn78MGiH wPnRwYrzZRDcYg3At0S6Bg5Hu54c0abyRmpVtD00A2Vz1wRK8nctFcfufaXK2L4ZjSMe 8Bww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=lppeHvcjG06aApr971Ja3PmMURmi7lKDO8m2mtQZ1Ug=; b=fyJjqMdeLjAUtYUzDkrEAzFUsTT5pH6QuAYXfC27yiwPX38y0wcHuQddQUScSaosJJ grxjW5OmYFHDjZG3DQWYn+Qcdua6jsvg4PK1wajqN7t67Oe+ad8yY0tvI4YCAtbM2RZi fKdfIm5OvvVT1FIGZAqHhCR1jNI16AE1VcwkcKl3cfYtifbtGQKzZJmTy6OAYLsBXikx ZQg9il/qZ2hM63GknB+fQirzx7KBXXsEktQf7LFk8FE1ALVQV6oFxbtejSmXtUl2fyUj m/HsNFoS5pfe8a5nSeZ+B26YUfDyJS/RYNpzD704765CG4CcT2JbO0nVqd83kR0sJvYq TT5g== X-Gm-Message-State: AKwxytciNE8Z59Qjm2xC9XYEO4AoaH8PZdFon46crslotQOkWNrsJckW CIB9xOG23B8geATzfDfGU0dkKEOe X-Google-Smtp-Source: ACJfBotABVmxVd51xpwEeV0VihFrjjRV/oYe/ZGua/SBHlV9b2b3ATClIDTF6kDMC79jaS6fqThpnw== X-Received: by 10.223.130.119 with SMTP id 110mr11170343wrb.139.1515973599575; Sun, 14 Jan 2018 15:46:39 -0800 (PST) Received: from localhost.localdomain (vno44-1-88-172-188-148.fbx.proxad.net. [88.172.188.148]) by smtp.gmail.com with ESMTPSA id 58sm9568374wru.56.2018.01.14.15.46.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 14 Jan 2018 15:46:39 -0800 (PST) From: =?utf-8?q?Beno=C3=AEt_Th=C3=A9baudeau?= To: u-boot@lists.denx.de Date: Mon, 15 Jan 2018 00:46:12 +0100 Message-Id: <20180114234612.58835-1-benoit.thebaudeau.dev@gmail.com> X-Mailer: git-send-email 2.14.1 MIME-Version: 1.0 Cc: Fabio Estevam , "Wladimir J . van der Laan" Subject: [U-Boot] [PATCH] mmc: fsl_esdhc: Fix i.MX53 eSDHCv3 clock X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Commit 4f425280fa71 ("mmc: fsl_esdhc: Allow all supported prescaler values") made it possible to set SYSCTL.SDCLKFS to 0 in SDR mode on i.MX, thus bypassing the SD clock frequency prescaler, in order to be able to get higher SD clock frequencies in some contexts. However, that commit missed the fact that this value is illegal on the eSDHCv3 instance of the i.MX53. This seems to be the only exception on i.MX, this value being legal even for the eSDHCv2 instances of the i.MX53. Fix this issue by changing the minimum prescaler value for the single instance of the i.MX53 eSDHCv3 controller. Signed-off-by: Benoît Thébaudeau Reviewed-by: Fabio Estevam --- drivers/mmc/fsl_esdhc.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/fsl_esdhc.c b/drivers/mmc/fsl_esdhc.c index 499d622c6d..90425e8a30 100644 --- a/drivers/mmc/fsl_esdhc.c +++ b/drivers/mmc/fsl_esdhc.c @@ -528,14 +528,19 @@ out: static void set_sysctl(struct fsl_esdhc_priv *priv, struct mmc *mmc, uint clock) { + struct fsl_esdhc *regs = priv->esdhc_regs; int div = 1; #ifdef ARCH_MXC +#ifdef CONFIG_MX53 + /* For i.MX53 eSDHCv3, SYSCTL.SDCLKFS may not be set to 0. */ + int pre_div = regs == (struct fsl_esdhc *)MMC_SDHC3_BASE_ADDR ? 2 : 1; +#else int pre_div = 1; +#endif #else int pre_div = 2; #endif int ddr_pre_div = mmc->ddr_mode ? 2 : 1; - struct fsl_esdhc *regs = priv->esdhc_regs; int sdhc_clk = priv->sdhc_clk; uint clk;