From patchwork Sat Dec 16 20:14:50 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Derald D. Woods" X-Patchwork-Id: 849554 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="FiU88GoF"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 3yzdl22Bkxz9sR8 for ; Sun, 17 Dec 2017 07:12:44 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id 4A084C21D9F; Sat, 16 Dec 2017 20:12:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H2, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 00F48C21F9B; Sat, 16 Dec 2017 20:11:00 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 49F5EC21C34; Sat, 16 Dec 2017 20:10:42 +0000 (UTC) Received: from mail-io0-f195.google.com (mail-io0-f195.google.com [209.85.223.195]) by lists.denx.de (Postfix) with ESMTPS id 5FD01C21F6B for ; Sat, 16 Dec 2017 20:10:39 +0000 (UTC) Received: by mail-io0-f195.google.com with SMTP id o2so5990640ioe.8 for ; Sat, 16 Dec 2017 12:10:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=B46k8eLUV731+hHP/s1Mk2jK/0OMHuGJmbWGhKLmDzM=; b=FiU88GoFLnuccS6OdsIMknYJQcSKZSFDhWetuwme2GAUsZm/QPLWO0EQEb45iCd0Qo YVkbsspw+xDmvhvtdImAyzacM9JhqXxS6B2wFYTVn2b+5rR3aX6X8ufMnmpfRWazhbaP q5+FEARusZd/rLLk1jva6rgRwYRiP0mz/eFScgAIJDLfYXq9JFi17IyyRR/WsuN+5eYv EfJL2d8GviUQ/73s3z4pviU/FkiIjdVUhh0dtoAIRSefyFl2E4nnEwGe1YlVWHhtZhHT 8RBlX6yMYpAymn8mw/RrMDfGxXYcGcoiy9Xwcf2fMNjVWGNY5u3kCiWAw9dt9ie5JRad MOMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=B46k8eLUV731+hHP/s1Mk2jK/0OMHuGJmbWGhKLmDzM=; b=Q5eTfsQbD8HCDnGjF6+XblEKnA5H0f46zURpVxiCvWeArqyx+1sT3KdQ1uMqjI/lrf K5lv09YiuklyYpbjZCjOhsxQfWRGU7skklVoVIHRX+v01YWu7fCPsHY9q/BO41b5+ucL ieeYQsKBSrMVDufwAIKZefvnwS3yfq9X3Ch2FtI26T9RlQ5mEwqom9VG4NJ7GmiWR/uG k63Y+S5ULdxStyDqGesqiZE004DTU5EJ5EGU0asMVKznvMRdan2SEp6k9KOc4E8Cp/pa UYLZncUZPapUzZnNOPAXKm0y68dx+lWU1EkmvnRZ02OQcVRjThwGkqFL30H0fEaN/xQ6 doWg== X-Gm-Message-State: AKGB3mLBB0fxhp3yk7RTpHjIpviuGpmxauc0y72I1erGrYhMAyK6R2tG eU1z0Kvv7nuSQSOZjwrl/DrPmQ== X-Google-Smtp-Source: ACJfBotnqqRGT7aZoseSTl6nYQ/t1A+EFXRhZqo6m6RocSu+NBvmh1U4omtrTnqncUKpJyZpECNz4Q== X-Received: by 10.107.78.10 with SMTP id c10mr18065991iob.34.1513455038069; Sat, 16 Dec 2017 12:10:38 -0800 (PST) Received: from ethiopia.hsd1.il.comcast.net ([2601:247:c080:b23:b6a:1db7:e702:d520]) by smtp.gmail.com with ESMTPSA id g130sm4921493ioe.78.2017.12.16.12.10.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 16 Dec 2017 12:10:37 -0800 (PST) From: "Derald D. Woods" To: u-boot@lists.denx.de Date: Sat, 16 Dec 2017 14:14:50 -0600 Message-Id: <20171216201450.5770-4-woods.technical@gmail.com> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20171216201450.5770-1-woods.technical@gmail.com> References: <20171216201450.5770-1-woods.technical@gmail.com> Cc: trini@konsulko.com Subject: [U-Boot] [PATCH 3/3] ARM: omap3: evm: Refactor 'board_eth_init' X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" This commit clears 'ethaddr' before calling 'smc911x_initialize' to allow the SROM MAC address to be assigned properly. Signed-off-by: Derald D. Woods --- board/ti/evm/evm.c | 24 +++++------------------- 1 file changed, 5 insertions(+), 19 deletions(-) diff --git a/board/ti/evm/evm.c b/board/ti/evm/evm.c index 4d5ddff1e1..3a9680ffec 100644 --- a/board/ti/evm/evm.c +++ b/board/ti/evm/evm.c @@ -299,26 +299,12 @@ static void reset_net_chip(void) int board_eth_init(bd_t *bis) { - int rc = 0; #if defined(CONFIG_SMC911X) -#define STR_ENV_ETHADDR "ethaddr" - - struct eth_device *dev; - uchar eth_addr[6]; - - rc = smc911x_initialize(0, CONFIG_SMC911X_BASE); - - if (!eth_env_get_enetaddr(STR_ENV_ETHADDR, eth_addr)) { - dev = eth_get_dev_by_index(0); - if (dev) { - eth_env_set_enetaddr(STR_ENV_ETHADDR, dev->enetaddr); - } else { - printf("omap3evm: Couldn't get eth device\n"); - rc = -1; - } - } -#endif /* CONFIG_SMC911X */ - return rc; + env_set("ethaddr", NULL); + return smc911x_initialize(0, CONFIG_SMC911X_BASE); +#else + return 0; +#endif } #endif /* CONFIG_CMD_NET */