From patchwork Sat Dec 9 22:59:55 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Fainelli X-Patchwork-Id: 846613 X-Patchwork-Delegate: joe.hershberger@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="X8kYsysu"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 3yvPrK4bjzz9s7B for ; Sun, 10 Dec 2017 10:02:41 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id 867BAC21E1E; Sat, 9 Dec 2017 23:01:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 68100C21E35; Sat, 9 Dec 2017 23:00:57 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 1C46EC21E45; Sat, 9 Dec 2017 23:00:37 +0000 (UTC) Received: from mail-oi0-f67.google.com (mail-oi0-f67.google.com [209.85.218.67]) by lists.denx.de (Postfix) with ESMTPS id 4A9EAC21DC5 for ; Sat, 9 Dec 2017 23:00:33 +0000 (UTC) Received: by mail-oi0-f67.google.com with SMTP id 184so9419542oii.2 for ; Sat, 09 Dec 2017 15:00:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=maYUuCPAsxtjNos/keRFJ6maMdoMWdjMrpfWblWhcM0=; b=X8kYsysuCM6K0xtVCgwvITOwqdrCTy42vdCyYms9r9JZpzX4o9pt7PDOODnI0Sogig 1K3SrVf3V9kcHE37mtNYKnVJqJOgoCs1wsd5sX2DC0n6DD79mlXJGqsv1LyyJlA/kpGV OREEjdDNedZVJ11+jKbAmrJHDgrE02IzW3OVQxQg7ghy0oPPPWnsEPBX8bhyxEPD3SDO cwke41AG916KzSGzxOmfbvubkVWS88VydMG/YFInkFEPJRSivxQdnSWMINvZI6vwvz3L dOzGMmXQlvAek1VFCQ59hviRxCeH+Clluytcwh80CDrKRaaS9CaPXB7muPVFBY1qlnfR vE2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=maYUuCPAsxtjNos/keRFJ6maMdoMWdjMrpfWblWhcM0=; b=ZgJCfHD3mQ2kQvC7l+/WObOmmKXdoMvmJSALVdcA43JubSxn0lnrOjstzKRWzqN57C jm3qcfJ9iSjMOibV+szJFZUpz7/3KRdAoER3xmZLaCyeOQ+0Vq9XJdvP9+NtZI1H25OH 5fwI6eU7idpgP46++ssY9dfUG9tnHN+WKQ/iE/dJ4OfFC8KZ95yguGgK5ycymyTTe9m3 Z3LRLzmtiDSmI+XzlmUestlkQ6FKFlUr7AG7qiJvyrdpmd8Y2F+iv33CFX8TYGDVSw6d HgrNVhNm5kJYZLS0iXqkRgcXiBxspCq5/O2MM2v06wrvdBipQslnXMZCPwmCnK7+OP4W lXnw== X-Gm-Message-State: AJaThX7kabh05x2IfftfDYsSgKzTO6NloKqVsz2uDfoO/D6u6WK4CZH1 X8JJnPc08ifXi/DXMlJrsWiDeqwQ X-Google-Smtp-Source: AGs4zMZasQH+mvZp/oZbbBmWVVuBvikYZ390MYte9x5ylAXTA6pOldXbLjzRux7yzdbqjcZa5Yd68g== X-Received: by 10.202.169.14 with SMTP id s14mr26162777oie.94.1512860431744; Sat, 09 Dec 2017 15:00:31 -0800 (PST) Received: from cox.net ([2001:470:d:73f:4d7d:8488:119c:738d]) by smtp.gmail.com with ESMTPSA id l32sm5097976ota.43.2017.12.09.15.00.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 09 Dec 2017 15:00:30 -0800 (PST) From: Florian Fainelli To: u-boot@lists.denx.de Date: Sat, 9 Dec 2017 14:59:55 -0800 Message-Id: <20171209225957.23458-3-f.fainelli@gmail.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20171209225957.23458-1-f.fainelli@gmail.com> References: <20171209225957.23458-1-f.fainelli@gmail.com> Cc: Alexandru Gagniuc , Joe Hershberger , Stefan Roese , Jelle de Jong Subject: [U-Boot] [PATCH v4 2/4] net: designware: Pad small packets X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Make sure that we pad small packets to a minimum length of 60 bytes (without FCS). This is necessary to interface with Ethernet switches that will reject RUNT frames unless padded correctly. Signed-off-by: Florian Fainelli Reviewed-by: Stefan Roese Acked-by: Joe Hershberger --- drivers/net/designware.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/designware.c b/drivers/net/designware.c index 036d231071ca..56fa0ebd8f31 100644 --- a/drivers/net/designware.c +++ b/drivers/net/designware.c @@ -17,6 +17,7 @@ #include #include #include +#include #include #include #include "designware.h" @@ -343,6 +344,8 @@ int designware_eth_enable(struct dw_eth_dev *priv) return 0; } +#define ETH_ZLEN 60 + static int _dw_eth_send(struct dw_eth_dev *priv, void *packet, int length) { struct eth_dma_regs *dma_p = priv->dma_regs_p; @@ -369,6 +372,8 @@ static int _dw_eth_send(struct dw_eth_dev *priv, void *packet, int length) return -EPERM; } + length = max(length, ETH_ZLEN); + memcpy((void *)data_start, packet, length); /* Flush data to be sent */