From patchwork Thu Nov 30 14:02:45 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rob Clark X-Patchwork-Id: 843023 X-Patchwork-Delegate: agraf@suse.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="IQxzwT+Y"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 3ynfHr1nW8z9ryv for ; Fri, 1 Dec 2017 01:03:04 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id E7EC8C21C4B; Thu, 30 Nov 2017 14:02:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id EACCDC21FC2; Thu, 30 Nov 2017 14:02:53 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 91057C21C4B; Thu, 30 Nov 2017 14:02:52 +0000 (UTC) Received: from mail-qk0-f194.google.com (mail-qk0-f194.google.com [209.85.220.194]) by lists.denx.de (Postfix) with ESMTPS id 110C8C21FAE for ; Thu, 30 Nov 2017 14:02:52 +0000 (UTC) Received: by mail-qk0-f194.google.com with SMTP id h19so8876128qkj.11 for ; Thu, 30 Nov 2017 06:02:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=TXWMosHe6AevkayNUcUWrvXUu8bOZ9XTfvFbrTAnGHc=; b=IQxzwT+YCDO81laMnNUEu/ZUHc2UaAEC4WRtxwxE0EKM3Iei/rqkn0Rv8UiOMGL8J8 Z1rDn46HU4GQCK2upUGqxGthjKdy0RdkKqg3WAar3tdl0NkWutQCr4WWNksvPOY3EZoo XcwiEPZV9ZyKr4ZGpK8KCB2ziXp1B6YQroIIV4EsItOlAmbAHI3FmrcY56UxGJ4aL3aS R+HF5u4mSlh/RSV/7XKPtVb3iLB4GJa7GuFw/3t9e48pn4bFhpuCLwVTdPExl94Kt1mo UF/NU4RKqORajsGdCGFzKa6AZ64dLtO82pN/DEg3ZPhtVr5HxksWadlhn24/Q9QU30X7 rcCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=TXWMosHe6AevkayNUcUWrvXUu8bOZ9XTfvFbrTAnGHc=; b=ZqTqzTds3J2bdo9MUjWe2YeSsFnmiXrCvQRYc8pnM9+qmxddVODlzXLi5M5DjPdx1U I8E52IXXFhFZig4De56Zt13h6C6vzBfU7XJvSYPnvj5XP7K7CtCuwJDfZ/d5yxFyFq4Y VLCWjWCYXG27COUxHlK/qtYWCJWtMi0bwTTiReUUywcoop/bpXk6wkke1vmnr+5tkjLa t+QBenQAC8RvqHDUh4Zi4eBqIXjNv1nL003kR6PI+2DFxPKpxtx+DZ8EcVdzfje4wOx4 3Ww74WNtQ2Z8tGaC2AvAYFiGJf0MCM6RdiN7eRIbXW7sT9qwTNg1BeSjcXFrOnm7EGvA wylQ== X-Gm-Message-State: AKGB3mJR7KkDZQXtZJlvlfbgp+X7pQIaeg96zWgmQxFijtTfnwKSmhBL S+/6MsNFbRFZSI/YqkgFsnDsMe74 X-Google-Smtp-Source: AGs4zMYRUpI5nMNX8UsB4oPMxEaSKNQM5pKl8A1/8GpdhcNBDomS5QJ5Lcs2fcYA1wUxYhuGrzaPfg== X-Received: by 10.55.33.13 with SMTP id h13mr2813764qkh.176.1512050570771; Thu, 30 Nov 2017 06:02:50 -0800 (PST) Received: from localhost ([144.121.20.162]) by smtp.gmail.com with ESMTPSA id 76sm3109401qky.56.2017.11.30.06.02.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 30 Nov 2017 06:02:50 -0800 (PST) From: Rob Clark To: U-Boot Mailing List Date: Thu, 30 Nov 2017 09:02:45 -0500 Message-Id: <20171130140248.7456-1-robdclark@gmail.com> X-Mailer: git-send-email 2.13.6 Cc: "xypron.glpk@gmx.de" , Alexander Graf Subject: [U-Boot] [PATCH] efi_loader: add missing breaks X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Otherwise with GUID partition types you would end up with things like: .../HD(Part0,Sig6252c819-4624-4995-8d16-abc9cd5d4130)/HD(Part0,MBRType=02,SigType=02) Signed-off-by: Rob Clark --- Reported by 'ykaukab' on IRC. Not sure if someone already sent a similar patch. lib/efi_loader/efi_device_path_to_text.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/efi_loader/efi_device_path_to_text.c b/lib/efi_loader/efi_device_path_to_text.c index 62771338f0..3b703301ff 100644 --- a/lib/efi_loader/efi_device_path_to_text.c +++ b/lib/efi_loader/efi_device_path_to_text.c @@ -135,10 +135,12 @@ static char *dp_media(char *s, struct efi_device_path *dp) case SIG_TYPE_GUID: s += sprintf(s, "/HD(Part%d,Sig%pUl)", hddp->partition_number, sig); + break; default: s += sprintf(s, "/HD(Part%d,MBRType=%02x,SigType=%02x)", hddp->partition_number, hddp->partmap_type, hddp->signature_type); + break; } break;