From patchwork Sun Nov 26 16:40:56 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Beniamino Galvani X-Patchwork-Id: 841415 X-Patchwork-Delegate: hs@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Gfs01U5f"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 3ylG2V1vDQz9s3w for ; Mon, 27 Nov 2017 03:43:13 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id A2B78C21E1E; Sun, 26 Nov 2017 16:42:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 1EA4CC21DDD; Sun, 26 Nov 2017 16:41:36 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id E6EE7C21DA9; Sun, 26 Nov 2017 16:41:26 +0000 (UTC) Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com [74.125.82.67]) by lists.denx.de (Postfix) with ESMTPS id CF03BC21DED for ; Sun, 26 Nov 2017 16:41:21 +0000 (UTC) Received: by mail-wm0-f67.google.com with SMTP id x63so30357236wmf.4 for ; Sun, 26 Nov 2017 08:41:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=YP88p+mfM4KzZyNq/lf/rJHTMo/vjchEKuBJMVhy0Vg=; b=Gfs01U5fX/c614ztUYIkx3Ph+Ks3D/CNed2YPL+qKokJLF9bKCVE1RpDiTr+vJJUut xn006y1zrDvb9kTVpCj/PS6VdqLUYeqny4OF2H6nd031uZdf4rTILK2pQldPUTnK/ykc kDUey+vdJzBc4vh11ootFU7yQptD5+uM7wNC+5KXtua0GnhljkpEb6P5N/8jioDHrg+6 NvgLjT2ZF6I4pXWrachDKRj+TfBemfrnW1bFreRTHR1roTWUllSKKSHc4wHjWGoiZKY9 HtPpm29mQj/+J37TsZp4izbnf2mLu1iZKp8J++uDJMEN3004SyvXzLpmWf4eQ68qGp5W XGng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=YP88p+mfM4KzZyNq/lf/rJHTMo/vjchEKuBJMVhy0Vg=; b=sTsq8KK0BDH8VRDmzem7/koVcQZjRB2eQ8F32shdiEM+fRhOwTXPfH3/sAGnvmUOFo f7CSNKXKJUBOGvTPsJ8hTdN/dBj861Nzs8mpQ4fnDAbgnbO7Gudegvi8Ra3//SLNp0h6 zNvKWJplwAvIVH44nG8Dxn82Ko9KVwmQX2Zao9rZeKqka8IxCTpw2BKpyWcZASpk0zz9 N4fiZTjeZFltO1mcfX56kgkoLAvMiNb/E4bRfFD9ZlgTD0zYwTNnUVsKeckPHotenP3e ioPzdNsjk3b9habA0ivq7laXlLniwRQ2QfCNwzUO/JMoaIEAK2b0p60w0nmJs8ABMccz wfFw== X-Gm-Message-State: AJaThX7kYeIqWUstu6uz23ntjc2fE8Lwpdjgv4rItcU2XTrE/m6ASqR6 OUZhzxZ4Nieas4WdriOZj+P4gLn/ X-Google-Smtp-Source: AGs4zMZ/UyGsUDFQvvFdRfcFV6ntXjQ5ta6xzu7creJy0kh2IeCljv9nom4VZaocaL1R0VuX869NKg== X-Received: by 10.28.184.130 with SMTP id i124mr14610001wmf.85.1511714481116; Sun, 26 Nov 2017 08:41:21 -0800 (PST) Received: from sark.homenet.telecomitalia.it (host78-28-dynamic.31-79-r.retail.telecomitalia.it. [79.31.28.78]) by smtp.gmail.com with ESMTPSA id k30sm47874486wrf.63.2017.11.26.08.41.19 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 26 Nov 2017 08:41:20 -0800 (PST) From: Beniamino Galvani To: u-boot@lists.denx.de Date: Sun, 26 Nov 2017 17:40:56 +0100 Message-Id: <20171126164057.27728-4-b.galvani@gmail.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20171126164057.27728-1-b.galvani@gmail.com> References: <20171126164057.27728-1-b.galvani@gmail.com> Cc: trini@konsulko.com, Martin Blumenstingl , linux-amlogic@lists.infradead.org, =?utf-8?q?Andreas_F=C3=A4rber?= Subject: [U-Boot] [PATCH 3/4] i2c: meson: fix return codes on error X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Change meson_i2c_xfer_msg() to return -EREMOTEIO in case of NACK, as done by other drivers. Also, don't change the return error in meson_i2c_xfer(). Signed-off-by: Beniamino Galvani Reviewed-by: Simon Glass Reviewed-by: Heiko Schocher --- drivers/i2c/meson_i2c.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/meson_i2c.c b/drivers/i2c/meson_i2c.c index 84e1997c76..2f39214ad2 100644 --- a/drivers/i2c/meson_i2c.c +++ b/drivers/i2c/meson_i2c.c @@ -178,7 +178,7 @@ static int meson_i2c_xfer_msg(struct meson_i2c *i2c, struct i2c_msg *msg, if (readl(&i2c->regs->ctrl) & REG_CTRL_ERROR) { debug("meson i2c: error\n"); - return -ENXIO; + return -EREMOTEIO; } if ((msg->flags & I2C_M_RD) && i2c->count) { @@ -200,7 +200,7 @@ static int meson_i2c_xfer(struct udevice *bus, struct i2c_msg *msg, for (i = 0; i < nmsgs; i++) { ret = meson_i2c_xfer_msg(i2c, msg + i, i == nmsgs - 1); if (ret) - return -EREMOTEIO; + return ret; } return 0;