From patchwork Wed Sep 13 22:05:36 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rob Clark X-Patchwork-Id: 813657 X-Patchwork-Delegate: agraf@suse.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="hxw4xxlj"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 3xsx1X3zRXz9sxR for ; Thu, 14 Sep 2017 08:20:16 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id 458B8C22743; Wed, 13 Sep 2017 22:10:56 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id A2880C22615; Wed, 13 Sep 2017 22:08:22 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 3E512C2259E; Wed, 13 Sep 2017 22:06:36 +0000 (UTC) Received: from mail-qk0-f195.google.com (mail-qk0-f195.google.com [209.85.220.195]) by lists.denx.de (Postfix) with ESMTPS id 9DD22C224BA for ; Wed, 13 Sep 2017 22:06:32 +0000 (UTC) Received: by mail-qk0-f195.google.com with SMTP id o77so945925qke.2 for ; Wed, 13 Sep 2017 15:06:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=rRpS4m7+k9Kgg68zb96oaEj5ZZmnh1UimVhSWh7Vh34=; b=hxw4xxljTkg940TVv2ZZ3+y6wt1DaUfzgDWTXj220EU8mTgT3F0OSDi8s6pOcpLGCf X38pzjVVXLWL/vyVN3oaOQmMva08u4ONR1VdpLKJm8deHEwLsw9UhMPK2vHDiFrhP1IS MdXrvLZ+fWjYJHoQHt59tqLGpRiRGmfqTn+X5CnQl4RDwt5a1/c4u28KFwvESPOMI4hB VlryONh9tN/tmPelDQ6CElYorR4AR2ysoeb21eFbqOmR8CqDzJtE5qxlqmvdVRPFgr3R C1xC0UFuHDPY8m+belEFqlqXX8m7HC/44OxAzQJepjdZJX1zSxhkX5wPqJOFnlyG0Rgv 8HZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=rRpS4m7+k9Kgg68zb96oaEj5ZZmnh1UimVhSWh7Vh34=; b=Sl+aLImgiVPIlutbwpBriMFL6vtk7bRUSYhn2E0h919aUselYZtOXvGM1ISwoJpZI4 qZeT6nTvtTTgdvTVsgzrCpnsX/MJod8sBGf98Ns36bQji0GhAdAareG4Es4dNJrEGHNq Xj9+nPDQc3wY8EM1wboGGVHkc0ZuwexycdcYUIkWIzuJwOxrW14Oz30WRABjMKcwqnBL I1f7M/8+qw5vDMq+RcNALl3xy6EoqJHcfb2mfGb3Z2tfkQAPkgegaKR3rRx3ocJieBct 8Gsh1GEerg22or4BgrMneNOXc50haWt0SBQ/0yFfzj6jW2zt6dsYEBDWBaligz8vm35p IuEg== X-Gm-Message-State: AHPjjUizqGnClUma2qRdQKR89YtD95OJhETNtMz350iBlBCUCWgStiFY EJH3x8zVpIjJ9TQV//A= X-Google-Smtp-Source: AOwi7QDMwpDESRcxWivvO7MTRHpaeS6YLTDiFHq97PeC0/yVEex9CCKlIMNwCyhOznGF500SGyqBLA== X-Received: by 10.55.209.16 with SMTP id s16mr32586qki.46.1505340391356; Wed, 13 Sep 2017 15:06:31 -0700 (PDT) Received: from localhost ([2601:184:4780:aac0:25f8:dd96:a084:785a]) by smtp.gmail.com with ESMTPSA id d42sm10355596qta.17.2017.09.13.15.06.30 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 13 Sep 2017 15:06:30 -0700 (PDT) From: Rob Clark To: U-Boot Mailing List Date: Wed, 13 Sep 2017 18:05:36 -0400 Message-Id: <20170913220546.19560-14-robdclark@gmail.com> X-Mailer: git-send-email 2.13.5 In-Reply-To: <20170913220546.19560-1-robdclark@gmail.com> References: <20170913220546.19560-1-robdclark@gmail.com> Cc: Heinrich Schuchardt Subject: [U-Boot] [PATCH v3 13/21] efi_loader: make pool allocations cacheline aligned X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" This avoids printf() spam about file reads (such as loading an image) into unaligned buffers (and the associated memcpy()). And generally seems like a good idea. Signed-off-by: Rob Clark --- lib/efi_loader/efi_memory.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/efi_loader/efi_memory.c b/lib/efi_loader/efi_memory.c index 9e079f1fa3..1f0b9d0449 100644 --- a/lib/efi_loader/efi_memory.c +++ b/lib/efi_loader/efi_memory.c @@ -43,7 +43,7 @@ void *efi_bounce_buffer; */ struct efi_pool_allocation { u64 num_pages; - char data[]; + char data[] __attribute__((aligned(ARCH_DMA_MINALIGN))); }; /* @@ -356,7 +356,8 @@ efi_status_t efi_allocate_pool(int pool_type, unsigned long size, { efi_status_t r; efi_physical_addr_t t; - u64 num_pages = (size + sizeof(u64) + EFI_PAGE_MASK) >> EFI_PAGE_SHIFT; + u64 num_pages = (size + sizeof(struct efi_pool_allocation) + + EFI_PAGE_MASK) >> EFI_PAGE_SHIFT; if (size == 0) { *buffer = NULL;