| Message ID | 20170815211102.28447-1-thomas.petazzoni@free-electrons.com |
|---|---|
| State | Accepted |
| Commit | c1ee8936bfcf467ccf69b5dbfcf358876e76e756 |
| Delegated to: | Tom Rini |
| Headers | show |
On 08/16/2017 12:11 AM, Thomas Petazzoni wrote: > CONFIG_SYS_GENERIC_GLOBAL_DATA is no longer used by any board or > platform, so support for it can be dropped. > > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Reviewed-by: Vladimir Zapolskiy <vz@mleia.com> > --- > README | 6 ------ > common/board_f.c | 27 --------------------------- > scripts/config_whitelist.txt | 1 - > 3 files changed, 34 deletions(-) > Apparently my IODATA Landisk board was the last user of the option, and I removed the dependency today. Thank you for the change. -- With best wishes, Vladimir
On 15 August 2017 at 15:11, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote: > CONFIG_SYS_GENERIC_GLOBAL_DATA is no longer used by any board or > platform, so support for it can be dropped. > > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > --- > README | 6 ------ > common/board_f.c | 27 --------------------------- > scripts/config_whitelist.txt | 1 - > 3 files changed, 34 deletions(-) Great news! Reviewed-by: Simon Glass <sjg@chromium.org>
On Tue, Aug 15, 2017 at 11:11:02PM +0200, Thomas Petazzoni wrote: > CONFIG_SYS_GENERIC_GLOBAL_DATA is no longer used by any board or > platform, so support for it can be dropped. > > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > Reviewed-by: Vladimir Zapolskiy <vz@mleia.com> > Reviewed-by: Simon Glass <sjg@chromium.org> Applied to u-boot/master, thanks!
diff --git a/README b/README index 3fdb89c..15ac00d 100644 --- a/README +++ b/README @@ -404,12 +404,6 @@ The following options need to be configured: supported, core will start to execute uboot when wakes up. - Generic CPU options: - CONFIG_SYS_GENERIC_GLOBAL_DATA - Defines global data is initialized in generic board board_init_f(). - If this macro is defined, global data is created and cleared in - generic board board_init_f(). Without this macro, architecture/board - should initialize global data before calling board_init_f(). - CONFIG_SYS_BIG_ENDIAN, CONFIG_SYS_LITTLE_ENDIAN Defines the endianess of the CPU. Implementation of those diff --git a/common/board_f.c b/common/board_f.c index 5915e50..37bbf5a 100644 --- a/common/board_f.c +++ b/common/board_f.c @@ -211,14 +211,6 @@ static int init_func_spi(void) } #endif -__maybe_unused -static int zero_global_data(void) -{ - memset((void *)gd, '\0', sizeof(gd_t)); - - return 0; -} - static int setup_mon_len(void) { #if defined(__ARM__) || defined(__MICROBLAZE__) @@ -910,25 +902,6 @@ static const init_fnc_t init_sequence_f[] = { void board_init_f(ulong boot_flags) { -#ifdef CONFIG_SYS_GENERIC_GLOBAL_DATA - /* - * For some architectures, global data is initialized and used before - * calling this function. The data should be preserved. For others, - * CONFIG_SYS_GENERIC_GLOBAL_DATA should be defined and use the stack - * here to host global data until relocation. - */ - gd_t data; - - gd = &data; - - /* - * Clear global data before it is accessed at debug print - * in initcall_run_list. Otherwise the debug print probably - * get the wrong value of gd->have_console. - */ - zero_global_data(); -#endif - gd->flags = boot_flags; gd->have_console = 0; diff --git a/scripts/config_whitelist.txt b/scripts/config_whitelist.txt index db28457..2df02d0 100644 --- a/scripts/config_whitelist.txt +++ b/scripts/config_whitelist.txt @@ -3341,7 +3341,6 @@ CONFIG_SYS_GBIT_MII_BUSNAME CONFIG_SYS_GBL_DATA_OFFSET CONFIG_SYS_GBL_DATA_SIZE CONFIG_SYS_GENERIC_BOARD -CONFIG_SYS_GENERIC_GLOBAL_DATA CONFIG_SYS_GIC400_ADDR CONFIG_SYS_GP1DIR CONFIG_SYS_GP1ODR
CONFIG_SYS_GENERIC_GLOBAL_DATA is no longer used by any board or platform, so support for it can be dropped. Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> --- README | 6 ------ common/board_f.c | 27 --------------------------- scripts/config_whitelist.txt | 1 - 3 files changed, 34 deletions(-)