From patchwork Sun Jul 30 18:27:16 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heinrich Schuchardt X-Patchwork-Id: 795412 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 3xL9zw1vF7z9sPt for ; Mon, 31 Jul 2017 04:27:38 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id D10D8C21DBA; Sun, 30 Jul 2017 18:27:27 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 00523C21C5C; Sun, 30 Jul 2017 18:27:25 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 07B66C21C5C; Sun, 30 Jul 2017 18:27:23 +0000 (UTC) Received: from mout.gmx.net (mout.gmx.net [212.227.15.18]) by lists.denx.de (Postfix) with ESMTPS id A4A60C21C58 for ; Sun, 30 Jul 2017 18:27:23 +0000 (UTC) Received: from LT002.fritz.box ([84.118.154.110]) by mail.gmx.com (mrgmx002 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MKpvc-1dbsvw2w8u-0005Kw; Sun, 30 Jul 2017 20:27:20 +0200 From: Heinrich Schuchardt To: Albert Aribaud Date: Sun, 30 Jul 2017 20:27:16 +0200 Message-Id: <20170730182716.8839-1-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.11.0 X-Provags-ID: V03:K0:6mXMuubo9gV6w0eml5ztnftuE01FNDx+kzLQPk1Z0hn3mFMV93c YYOVqlCBQiI3ZgNjHIMicKBn7yP4JIrftKIKOO5Xj1+a47oS0unicMVcMpXu1RdOfeqQs3j xyytHH+7gp3G168M055Yiv+2M5XYnNvx710I52VgRJIaH3D1jzXy0tFPMTmSFYFswGD93Uu vtaaqRhc5WwmXAR98vYiQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:5VtcxN8m4bc=:E33oGZ4sEInMSEf+NIWxKS iayiOygKgTQCsw6NFHNP2xwYGQj6IbhLPffmcSgqgkDO3BQsG2clvr2nE9gG0QREIHGpeOc8m KDPzkXpMUcZBbXsMFATPyF7wry61FEvbbWtSFu2/WjWfBWSiqgZaiTeth5qtWlUZTKZ9rz7CK sltTA+IGjKF+rvlI7emLn10j3e1TV72oyyFPAn5OeF1N4HI8k51CsKHUXfwKtLbLUD5SSJk8h gDNn/UKaeYQtLmiRjOsg0sjvdWG+8hRJR95INWuPpeEuxS+iu1XBwDegOcsTvhvgx1YUMOpFs ELMuRjedW7lx0ArRJBSmRkhDNxX8JNYyT87xfcYxrllXl2Repm+FBOr3xd8ROIw0UkMBUet/X JCFh6Qp6bCG0zTPviuh+XmxO0owGQ6ds2GhXZJZcjaJUIGyLR02I2xSgTZFMMO6x+iELXmLp8 6drKaJeJLKhdA6VWZSbsoQPyhBd6lEhiukNXmad65HuX15d5Adh5SWKOiCy6kCPS5dkX+LASd WgOyBjF/YvVYN8y0sx+vQ1oSiqUGT1RjeieR6DDMnCqCviEW4waey0wcjDibzRz2WW+FFwnHs idyl+naF8wz9j0VembrzWaZTi8E/Rl64wDLEBp89bGLJVzUPbaeoeZgSHPR+wjo7Pu2KIakOP ZqD1t3aj9UYRVF0KE39zPXh9iUR97iihhZpUse8IvvmnQqWjXfaEuoxCor3vKw8E2HBww2ISu ltpNYmqql/orPF1194EdQPIU60SlkYFVbJgoKXOkEmnbeu6eqCmaNKqcPtBz38/TYxZv8ul8q SQNhyW8aqFWCh+4icRTN0TSq53dJA== Cc: Heinrich Schuchardt , u-boot@lists.denx.de Subject: [U-Boot] [PATCH 1/1] bcm281xx: clock: avoid possible NULL dereference X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" It does not make sense first to dereference c and then to check if it is NULL. The problem was indicated by cppcheck. Signed-off-by: Heinrich Schuchardt --- arch/arm/cpu/armv7/bcm281xx/clk-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/cpu/armv7/bcm281xx/clk-core.c b/arch/arm/cpu/armv7/bcm281xx/clk-core.c index cdc1264d7c..b061c20648 100644 --- a/arch/arm/cpu/armv7/bcm281xx/clk-core.c +++ b/arch/arm/cpu/armv7/bcm281xx/clk-core.c @@ -479,9 +479,9 @@ unsigned long clk_get_rate(struct clk *c) { unsigned long rate; - debug("%s: %s\n", __func__, c->name); if (!c || !c->ops || !c->ops->get_rate) return 0; + debug("%s: %s\n", __func__, c->name); rate = c->ops->get_rate(c); debug("%s: rate = %ld\n", __func__, rate); @@ -493,9 +493,9 @@ int clk_set_rate(struct clk *c, unsigned long rate) { int ret; - debug("%s: %s rate=%ld\n", __func__, c->name, rate); if (!c || !c->ops || !c->ops->set_rate) return -EINVAL; + debug("%s: %s rate=%ld\n", __func__, c->name, rate); if (c->use_cnt) return -EINVAL;