From patchwork Sun Jul 30 18:22:47 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heinrich Schuchardt X-Patchwork-Id: 795411 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 3xL9th25zXz9sPt for ; Mon, 31 Jul 2017 04:23:08 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id 08574C21E4D; Sun, 30 Jul 2017 18:23:00 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id DADACC21C5C; Sun, 30 Jul 2017 18:22:57 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 8AF22C21C5C; Sun, 30 Jul 2017 18:22:56 +0000 (UTC) Received: from mout.gmx.net (mout.gmx.net [212.227.15.18]) by lists.denx.de (Postfix) with ESMTPS id 38C89C21C58 for ; Sun, 30 Jul 2017 18:22:56 +0000 (UTC) Received: from LT002.fritz.box ([84.118.154.110]) by mail.gmx.com (mrgmx003 [212.227.17.190]) with ESMTPSA (Nemesis) id 0LcShi-1e0jkZ0aP8-00jqI6; Sun, 30 Jul 2017 20:22:53 +0200 From: Heinrich Schuchardt To: Albert Aribaud Date: Sun, 30 Jul 2017 20:22:47 +0200 Message-Id: <20170730182247.8713-1-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.11.0 X-Provags-ID: V03:K0:lDojakkv5YaTFHbE9snC43NAp07OzNWvmFICdLM1VQj21O2ABJ0 YdMVuh6rQybyDjiA3J5JsM6hiHjNijxo2b8ZEyQhSeQJtLzN1EoxaDDqtn8BT96Pn1gERG6 aRzH5fIXNgFnU2IVHZbe94lU6gHl1noJdnB7fK/px/dwnDUScOpatAbIA0zD9Zv68WlTKkX I6pLavNcZcz53xG1Wj4lQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:MoEFsXy706c=:RunG0ZYuiCm+q0uwiPVNDE Ssr4pM22c0EV5JWKuO2jBYkqK2fUGRAGiSGs+efLGGDAl2PppSV2VmawT0gPUeuW8fNNvY21h 3/uZCJD48xSAk0cbdjYaalmzZC37Xy9UU18MB5HFu4SS/7no8hJbLp4fwbmFblNXDE+z6MUyk rrUp5H96ehW5RwUTXpIHUEre/83EP/ctDLD2RsuIAno4CZCl6NFz90+FeIo0b6fJYW6PU+ekV 0dmG4wMlLXmFSCGJK6Rw/zl1h8m8ThkZ4g6ZpA2yn2XOPTs4cBJS1p2elbFAbyqM3Yx7Yg0y7 QppG+5X3272DtPHNH8vb6yb9Mj8o/i9s5NgQmYgOu2N5xqRA5U1MzQoBdxm8P8BaUe6k08odW lgXHbuuoy3owtFt4oUw+F0L5BZMm1J2Ef0uP2pe7+H8Ph2taZxdfMw7mCBbwcwUkfEicOzbVy VHY149S1K9tl8WjgMoEhMkDmEtNwEgL0DCOOCgkrUwpSemz0QX+Y5KTN3PcO8H4aWafr4LB7n bYS7FOUlRYlXx0Yf412wWo3jJLWEoNC99tR8SIsN6bQ8n3ctC7spCvTMSemBQRQV6QqcbqA7k w4/wEXF/+Cr5uvUmLsPj9EVWQIcj/V+kdaV47ijnO5dT3d36NvSuhEMI3LRkzIvO4sLAAvRRN XLXRLHTJ4QNHqc4pffHZMwageZ2zg9Qm/cO9NNgXXuApCRb2eV2awhfrtMeh5gRqdlMyZEqEz 1+UWcaJDkQjFX6w/85AbIjyS6774+0kLUMX9ggW+BmZigJJGh53bWjr8JFKlJ5sNyM2bOO04D xwjQwtJZpsnrBoVvxa/VAFBEzzOcQ== Cc: Heinrich Schuchardt , u-boot@lists.denx.de Subject: [U-Boot] [PATCH 1/1] arm: bcm235xx: clk_set_rate avoid possible NULL deref X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" It does not make sense first to dereference c and then to check if it is NULL. Signed-off-by: Heinrich Schuchardt --- arch/arm/cpu/armv7/bcm235xx/clk-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/cpu/armv7/bcm235xx/clk-core.c b/arch/arm/cpu/armv7/bcm235xx/clk-core.c index ee4b34574a..89e367be82 100644 --- a/arch/arm/cpu/armv7/bcm235xx/clk-core.c +++ b/arch/arm/cpu/armv7/bcm235xx/clk-core.c @@ -493,9 +493,9 @@ int clk_set_rate(struct clk *c, unsigned long rate) { int ret; - debug("%s: %s rate=%ld\n", __func__, c->name, rate); if (!c || !c->ops || !c->ops->set_rate) return -EINVAL; + debug("%s: %s rate=%ld\n", __func__, c->name, rate); if (c->use_cnt) return -EINVAL;