From patchwork Sun Jul 30 18:15:51 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heinrich Schuchardt X-Patchwork-Id: 795409 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 3xL9kj0k2vz9sPt for ; Mon, 31 Jul 2017 04:16:12 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id 9DB90C21E38; Sun, 30 Jul 2017 18:16:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 684DCC21C5C; Sun, 30 Jul 2017 18:16:04 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 05B04C21C5C; Sun, 30 Jul 2017 18:16:02 +0000 (UTC) Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) by lists.denx.de (Postfix) with ESMTPS id A1BB2C21C58 for ; Sun, 30 Jul 2017 18:16:02 +0000 (UTC) Received: from LT002.fritz.box ([84.118.154.110]) by mail.gmx.com (mrgmx101 [212.227.17.168]) with ESMTPSA (Nemesis) id 0Mecqq-1dDmI30fqS-00OE9f; Sun, 30 Jul 2017 20:15:59 +0200 From: Heinrich Schuchardt To: Albert Aribaud Date: Sun, 30 Jul 2017 20:15:51 +0200 Message-Id: <20170730181551.8573-1-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.11.0 X-Provags-ID: V03:K0:I/+TqvzrB944AEtkzwXErPMQmFpOkQx+gKOI81V5khXC0T/oOze Rxjptts81uslD8BdeWpFYZKkReBYxzey042OlwAgV4D+DSXydSZ7H1bRdLwcvoL+CYP/GoI n3njKVOmVahgBwWovVASiyGD1cMW3OR8WzfG9Mg4CheyyIC9WHzOHXqPim3qEWgGkKpAAM9 ao26VNpaWIXNaLDgvFb9g== X-UI-Out-Filterresults: notjunk:1; V01:K0:cmShCh98oYg=:t4olHNV+/UBKgHFCIXKDTp bl25txkUaQveECQIl0gz5s7mxTg/uMvXceBghvcFoCAcuWy+7pIliK9c7YQcndF28kB157PT3 hUZSl82kzdVcYYIcxmdWBABa23CBuqLq+2QA4lZKdp+GX4I2/b3EPsb64B9Jp/ma7hq+5Tbh2 85F5F1HmjDwg+OcJYbW5W3di1mDNfR8a43I16lRp4qDG1LM1+HSUu7+CzTPUZ/MG4lMfc340p JtVyfYN4fZdmqO3oTCMxQVxpt54MeJRRgh2c3p52W0GjQnSuhNxeGroul1MMiu+GhYmOEVcPJ WGs0bYF05Z64SmGt9t5hYBPYwXbH5sgtGYuKRv2+Wh9Hgcza0Bjrp+M1Q46KOoQn8HfuUcAJf M9kGuV+t/JsaYqWWvDM76jtjhh2WcQP9cJko1oQ8d4rjMk/WEilqA4+NG6BIsC7gmay1CiW6c mGo3FlArmWL/hVjOWkv0Zf4USE/e/q3Jl25TxKZ6k6dlj1VOuA7dq2Dpp07fwebCIqudWb8rj Uh59mpAvl5vg6Ji7qxqYdgv29i+Al7kncc4/skIZ2dmFJy5atwRAFfBOf05qY/b48M/leM9iK x+jgNckhbB1L0D3IIKxrdUmjK7dHEZuTCYnKd5EV/vt+Gm2Em9r/sVvNZky9KnKkjxDMr/ekm OadhVqeM+mD4Rs9Ns+HvKfR2ez8EZg2Akl9Foaf+L16GQYRfdnG6cyTMqMnO5R73gxo5d/o4b ECKdVYg3IvaGqoGw9DR/3IoleKbunWj2j8z607J42C+EUJ5vEp9TZ/mm6I6MFRTzXMBOwopfS wWunuINT0dBv7attJU7iNbCDqjB3Q== Cc: Heinrich Schuchardt , u-boot@lists.denx.de Subject: [U-Boot] [PATCH 1/1] arm: bcm235xx: avoid possible NULL dereference X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" It does not make sense to first dereference c and then check if it is NULL. Signed-off-by: Heinrich Schuchardt --- arch/arm/cpu/armv7/bcm235xx/clk-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/cpu/armv7/bcm235xx/clk-core.c b/arch/arm/cpu/armv7/bcm235xx/clk-core.c index 79fafa08ed..ee4b34574a 100644 --- a/arch/arm/cpu/armv7/bcm235xx/clk-core.c +++ b/arch/arm/cpu/armv7/bcm235xx/clk-core.c @@ -479,9 +479,9 @@ unsigned long clk_get_rate(struct clk *c) { unsigned long rate; - debug("%s: %s\n", __func__, c->name); if (!c || !c->ops || !c->ops->get_rate) return 0; + debug("%s: %s\n", __func__, c->name); rate = c->ops->get_rate(c); debug("%s: rate = %ld\n", __func__, rate);