From patchwork Thu Jul 13 20:51:35 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heinrich Schuchardt X-Patchwork-Id: 787984 X-Patchwork-Delegate: agraf@suse.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 3x7p2t6zmcz9s7m for ; Fri, 14 Jul 2017 06:54:14 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id A6C88C21ED8; Thu, 13 Jul 2017 20:53:00 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 55C58C21ECC; Thu, 13 Jul 2017 20:51:48 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id E83BEC21DAC; Thu, 13 Jul 2017 20:51:42 +0000 (UTC) Received: from mout.gmx.net (mout.gmx.net [212.227.15.18]) by lists.denx.de (Postfix) with ESMTPS id 8A2C0C21E0B for ; Thu, 13 Jul 2017 20:51:42 +0000 (UTC) Received: from localhost.localdomain ([88.152.145.149]) by mail.gmx.com (mrgmx003 [212.227.17.190]) with ESMTPSA (Nemesis) id 0M92ZJ-1dNnw82cVZ-00CRBr; Thu, 13 Jul 2017 22:51:41 +0200 From: Heinrich Schuchardt To: Alexander Graf Date: Thu, 13 Jul 2017 22:51:35 +0200 Message-Id: <20170713205135.1538-6-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170713205135.1538-1-xypron.glpk@gmx.de> References: <20170713205135.1538-1-xypron.glpk@gmx.de> X-Provags-ID: V03:K0:3HmFFFqWIOtqFY6AHMoeBZfXPGN0kAHF4KurF5cuuyDIwjIs1Wp uVHEm+MyvpB8lVvu6IBjlJvRk/U+aKKbJM1vzal8UNc4cEIXfjQMdd8IZr3E7II90Ut7Q4N XMOAu1D2Mz9PsTNv07D54/+ryaOKSyCQ555mtium925TTWaG5mL+iJdl8zC9AwxzOdika7J CLEKFZjTI4E1ytxucmfYQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:ztAOjksHx7I=:GSX5VX4J2IG4Ja4zVQDX3D RyTJz38KnQ20NSxacZLN0zeadrn7VE6bSnp1BpY2/sT5ZnVRLhhSg07q+m6O/70q6ADmCOruE tWeQCbh81ELDbhvpdS32YwO4636IS/o9DtKQfW5J2N+EwcllaZsRelqs2ZsZOl/VN36axASTR BtT5K83Ee8rmz9NYVN8Ii2XnNlfFh0O6ckFuJ0yWvVR7YAGnArr60SCOy1iqRo1BUealAVlTY rk5A9B019BkOT3NsRXn/C3mmE57+9JILfldsGOQ4fZ7qyM8kHN74imRO/WPGdYiapi3GoYFR7 m5+0GdA7rTxqPX3HSwHVnsKa5nEHYT62SYU8tGHBc+MMmlUJnhubSvPKBNCIUugA1yn1fzSPo oQdcfFX8aGZBuUe1mypcDNo4CzGYNvI88q3QlTgo49bmt1F5ociAFtiteW4AUEHYNPnHxCrdX t06zlTjvu9CnqDwMr//gENOLGvqkk8WjFB5t5LF8vIcBnwEVPizwrG6lYCRFsYtqUH65njCU1 ThG9PWkc5eVM/IZQ9d8NELBJWP4h2cA3M+aT1ACeYO+3J3OGpgwr2185qLuU1khWdJRgpNFNk 46h2xGIYfrdbF5WAc4bzap9P5FoA8M4BSdYydPC4G9R+/09q/PatofuTcACDiQcfn40vAvT5t MRBAIu2lgMP06RqhyiqeZFZ5De2oMjhaQVOM/xi5BjKsrbnuWmQCgAzVP0I3xd1R5gkhRlCAT HexUiwWivBEAda7x46rF+R+MrDnppIFyAl4tfoDcRHdJhnVfVvaX6aXbjwEpoV/QoiSk+e/M6 NAuAEBCy3CUTBxgHvzKhhTG63O5Kw== Cc: u-boot@lists.denx.de, Heinrich Schuchardt Subject: [U-Boot] [PATCH v2 5/5] efi_loader: DevicePathToText put declarations first X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Variables should be declared before the first executable statement. Signed-off-by: Heinrich Schuchardt --- v2 new patch --- lib/efi_loader/efi_device_path_to_text.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/efi_loader/efi_device_path_to_text.c b/lib/efi_loader/efi_device_path_to_text.c index 56de328286..621bc4f528 100644 --- a/lib/efi_loader/efi_device_path_to_text.c +++ b/lib/efi_loader/efi_device_path_to_text.c @@ -30,12 +30,12 @@ uint16_t *efi_convert_device_path_to_text( bool display_only, bool allow_shortcuts) { - EFI_ENTRY("%p, %d, %d", device_path, display_only, allow_shortcuts); - unsigned long buffer_size; efi_status_t r; uint16_t *buffer = NULL; + EFI_ENTRY("%p, %d, %d", device_path, display_only, allow_shortcuts); + if (!device_path) { EFI_EXIT(EFI_INVALID_PARAMETER); return NULL;