From patchwork Thu Jun 29 19:16:19 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heinrich Schuchardt X-Patchwork-Id: 782416 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 3wz8Xn1Xmzz9s0m for ; Fri, 30 Jun 2017 05:16:39 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id B9458C21D81; Thu, 29 Jun 2017 19:16:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 361E4C21C6D; Thu, 29 Jun 2017 19:16:31 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id CC5A0C21C6D; Thu, 29 Jun 2017 19:16:29 +0000 (UTC) Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) by lists.denx.de (Postfix) with ESMTPS id 74A8CC21C61 for ; Thu, 29 Jun 2017 19:16:29 +0000 (UTC) Received: from LT002.fritz.box ([88.152.145.149]) by mail.gmx.com (mrgmx102 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MKbZD-1dPpym3BGJ-001yem; Thu, 29 Jun 2017 21:16:27 +0200 From: Heinrich Schuchardt To: Alexander Graf Date: Thu, 29 Jun 2017 21:16:19 +0200 Message-Id: <20170629191619.11597-1-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.11.0 X-Provags-ID: V03:K0:Wsf9zhLDtbhDN+b24LPEMhGy8/fTGEbFWAJV8hoNUXadUUuZOZM 3bMJC5YqIhwQ7a2DJJ/ZrRopr4cdUqvbIXDBsmsm8EJyAYHhpV8nO8azvfwbwfnyjnXBaXG gtuCfKdlpbnYLIJIIj61lMsn2Qpt4nfZCI/CezujS1BCvdy71GXUPy2qNHa2/6UV2DhEwqQ XfwQauESY32C7o9xKmUSQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:zW4WJ0MFGEw=:suCbIsTImlW2pEpcJRRPK2 OLYSUn/QHwgNGOjDDOozeq5OwbjW/3VNCJBZWpYUR9Mw3/ffepFZCwLq16VIrZm8Uf0iTEBF0 inUKEUVRBET4NNPQy5l/e159VFt/u8H72W1dP1tpNcumo38QXfmAXRvFg+7JwWB+5y/4f6AS0 noTgfzjxrRNybYszxnYKTWQRlQXSp8UcEbScQYHLzcrQ1LJ4CNT8vRmE5+li4bI5HiSViuD8j TUbeQcCsQtl4VhE0kHp3wScWcn59l6Zbi47dULiUph8rYY1CxwcayBTHBabu8ObbK0muj67KP 62YNMPU5PkoAFbKIaE+b5jf5kJFhZORSeLg9T009iKakK3SBcg/zwa/xzBbKx3bflfUjZGWXe aaLjPFqVI2vr3qHH9sRpfRJf/a/f/gta8IvGQTR53VsthxuZeJDNp87n8AgbH9mnw5XA2Zmma tA2MbbYXqh0EQKF9hYO/FnXPbzahHufM4PMPCL/+VOvAAgb7jTaqUW2fFzwSOqQoIWJHhYFUr x7GxrkGIaa+c6MpWAR27SBh0tusSWwsljoCeqWg+05Vh+eD3n8rss+ENluFZTa4FsJeSAXepE YOJdTWxKsaLEMx/eQO+Z+vwRaikeqXLyW4MK8oIb0mstgsmx857PfugpaHWJhw6gRODBxvl3a 4vaWDTfysEmq+HcYrqBhBTh4AiDOJQ2fXtEJzrAI05jZxwzY8whcYlG4tBONDsn1ETYI3XlzN ipaZQhnr1D9hgad7c10dlpRay2s4HsFbvzVs3XAEuyW8pDZQ8InurKXDOoQ= Cc: u-boot@lists.denx.de, Heinrich Schuchardt Subject: [U-Boot] [PATCH 1/1] efi_loader: efi_handle_protocol set attributes X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" UEFI spec 2.7 indicates that HandleProtocol can be implemented by calling OpenProtocol with attributes = EFI_OPEN_PROTOCOL_BY_HANDLE_PROTOCOL. Currently we pass attributes = 0 to efi_open_protocol. 0 is not a valid value when calling OpenProtocol. This does not cause any errors yet because our implementation of OpenProtocol is incomplete. We should pass the correct value to enable a fully compliant implementation of OpenProtocol in the future. Signed-off-by: Heinrich Schuchardt --- lib/efi_loader/efi_boottime.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/efi_loader/efi_boottime.c b/lib/efi_loader/efi_boottime.c index 51080cbeed..1fd31bb06b 100644 --- a/lib/efi_loader/efi_boottime.c +++ b/lib/efi_loader/efi_boottime.c @@ -738,8 +738,8 @@ static efi_status_t EFIAPI efi_handle_protocol(void *handle, efi_guid_t *protocol, void **protocol_interface) { - return efi_open_protocol(handle, protocol, protocol_interface, - NULL, NULL, 0); + return efi_open_protocol(handle, protocol, protocol_interface, NULL, + NULL, EFI_OPEN_PROTOCOL_BY_HANDLE_PROTOCOL); } static const struct efi_boot_services efi_boot_services = {