From patchwork Tue May 16 03:07:01 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heinrich Schuchardt X-Patchwork-Id: 762783 X-Patchwork-Delegate: joe.hershberger@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 3wRj6m1zCSz9s7B for ; Tue, 16 May 2017 13:07:28 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id 04E75C223C8; Tue, 16 May 2017 03:07:21 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 329D4C21CE6; Tue, 16 May 2017 03:07:19 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 6093DC21CE6; Tue, 16 May 2017 03:07:17 +0000 (UTC) Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) by lists.denx.de (Postfix) with ESMTPS id 2AC9AC21BE5 for ; Tue, 16 May 2017 03:07:16 +0000 (UTC) Received: from LT002.fritz.box ([95.222.184.236]) by mail.gmx.com (mrgmx102 [212.227.17.168]) with ESMTPSA (Nemesis) id 0Lr46Z-1df90W44VX-00eYtp; Tue, 16 May 2017 05:07:12 +0200 From: Heinrich Schuchardt To: Joe Hershberger Date: Tue, 16 May 2017 05:07:01 +0200 Message-Id: <20170516030701.29736-1-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.11.0 X-Provags-ID: V03:K0:fY5xcv4LQ8Pt0ca3capzY7QeVnQhb1/fhm+0sCVFlgAWt0ZHpFl RbsKe1ZMjZQ/1glGdJj2Xv53z3n8PlFB0gosTGvpdr5tzc7AaWylVphq7WFIsUpD8Iwsk59 ql9ybBMHkBMORD6yaz+eIY3tJV/Icl4guwS2mwnQwFwn7ZXPVRX9j+8xXv9serQ/+cYu2k9 r9DuZ8zl2iQgS1c1Ae1hg== X-UI-Out-Filterresults: notjunk:1; V01:K0:Ja97SbsNGy4=:lm+YjltpoAnvWEQWoy3eGR mMes3EEP1snBQ+Vf9yA0Pb5J/mqKLjSwnkg0LgEP9WWgP/Razk2tGHQXZ+kvolZqoId4Q99tU c2/0MOG5WlynEniti8NPNWGPch8UOJLpcYKF3PtZ8SdTPu9fq9p8K/q5m8UbLiQ+J1eJ86YNF UTbIeB81IMW7jjW0WGnp42+7LkLgVGaMPO/pb/MyNNHpFn3yLtuvCmU17tODoyL5sp8uj4sEN 66TKaQUx+jmxwU0PqWlfvQY/3vCLlRYVTCHv1a3XGPtxNciiYoF12n/Hv1bjywltZEhumkxPp hmfUzV+kSRHlPifa2d392yyjQHDqjgcTdT8kJqU4KZojjegn++DbF6yk80b6l7k+03Yq4QG2h xvA0jkCmkNKrj8zlQZLT4aTGyQkAG8o5oACudK+wN8HUQrEJ/hHv0I0toV7p7rCpn5DUU3fxg uMgwjI8bN2sK30KhSaADHRwnspEnCtCF9iw+O4CEFlVH7+j019OfQepjUMiEP6+gnogrkBxa1 j4jUGbdOPoc6Sj3y22rWRsVUR9Ff4xLZIjsUn/04gTOqYbnuCBA/0Wo8aA21dJKwe4+VT6Iij 41FSMc2MS8MGiDWd3kUXtwZGxyoBXN7N4PBXjL8lsHl60RhzKAUTmP1MBH1bFpFK0meFtTUrc qY3HvifR4l0qnPQO40U65P2Wm1BADLX7bUt2z6bULV8Jn+cXfah/BD+pTh2Qma/MS12sKBFZs DB4MlkYrYmTRuVo681A2x6kXOs/nz8O5ZHMZXx82hIyXTewmB9ReKFtAMeg= Cc: u-boot@lists.denx.de, Heinrich Schuchardt Subject: [U-Boot] [PATCH 1/1] net: core: avoid possible NULL pointer dereference X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Checking if dev is NULL after dereferencing it does not make sense. Signed-off-by: Heinrich Schuchardt Acked-by: Joe Hershberger --- net/eth-uclass.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/eth-uclass.c b/net/eth-uclass.c index c3cc3152a2..b659961a5d 100644 --- a/net/eth-uclass.c +++ b/net/eth-uclass.c @@ -181,7 +181,7 @@ int eth_get_dev_index(void) static int eth_write_hwaddr(struct udevice *dev) { - struct eth_pdata *pdata = dev->platdata; + struct eth_pdata *pdata; int ret = 0; if (!dev || !device_active(dev)) @@ -189,6 +189,7 @@ static int eth_write_hwaddr(struct udevice *dev) /* seq is valid since the device is active */ if (eth_get_ops(dev)->write_hwaddr && !eth_mac_skip(dev->seq)) { + pdata = dev->platdata; if (!is_valid_ethaddr(pdata->enetaddr)) { printf("\nError: %s address %pM illegal value\n", dev->name, pdata->enetaddr);