From patchwork Mon May 8 19:24:28 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heinrich Schuchardt X-Patchwork-Id: 759760 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 3wMCBG19W0z9s81 for ; Tue, 9 May 2017 05:24:54 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id D7DBDC21C4E; Mon, 8 May 2017 19:24:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 2234FC21C32; Mon, 8 May 2017 19:24:43 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id EE0C0C21C32; Mon, 8 May 2017 19:24:41 +0000 (UTC) Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) by lists.denx.de (Postfix) with ESMTPS id 9C031C21C27 for ; Mon, 8 May 2017 19:24:41 +0000 (UTC) Received: from LT002.fritz.box ([95.222.184.236]) by mail.gmx.com (mrgmx003 [212.227.17.190]) with ESMTPSA (Nemesis) id 0M9JYE-1dKV2p2Rig-00Cfr3; Mon, 08 May 2017 21:24:37 +0200 From: Heinrich Schuchardt To: Joe Hershberger Date: Mon, 8 May 2017 21:24:28 +0200 Message-Id: <20170508192428.30063-1-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.11.0 X-Provags-ID: V03:K0:VdVnzIKDDFi0XrYm/8saAP/dNy1McxeT94TrtGU1knC1brtc8Bp koNeQH8Qzy6BlyMHe81lsMuik2GLQLlDXKi6kj9NbomkVnUV01h2NFnpZSVeVsu7TmEWaNv DKJ6zOb71V9iGQ2agRRaS/oAO8oO/wWFaenNUa/+OdZjU5IjfnJF1lN1C7P0JbqkYFIZK02 8SluNzbw7QlI1nlhzQohA== X-UI-Out-Filterresults: notjunk:1; V01:K0:5WvQO0bsgqs=:Bn4j783qSn6T0yX+nsCkhS yVd5izI1cppY8hoU4d2R7ebvTTDhRGbvr9vnFlj1luhVxUkJg3dsxbyZQ7IMys3itlEIAUzmy Cr5FnC+Tl0qklkTX0tedZiXN+lI8hRxYohSE10CshnCkrFqg5eOUJsemi6TaU113zPZik5VhR CRQgBfcE1UCDlXWeG5cQPkBUK8WV7rMx9EhD1U//q0v//4Nn7MTt3ElH2cA6Be3lOgXss2sWh AVA+/oujZRqQxoqRpRqkP3/YSIjDvChSjLUs0yq5WM1Pr29FHDMecnVu+9BDRBU0VQ52MYH+S TyrQXebuff1Rm9U1l7xbWHSVQ5CsX29omK+1JR0NAmj2eJ+v4cHu3/AlurWA0ca8KFCNlz7tC ALL5GUxh2EGOm1ISz85wYtuUsjYOvxq0+yCykjygyqFj1IDT0QbdTp/PuYGHU+6FmqItzAY5i zo5xIynEtBmh5B4QVJ5DrICeSD+ZuvW4wVj9gm4NK+EKFhAP5556gClKoCZlrgNkdb/RDTvRi sX0FW3mOMvXmcjCcQq+1aFIC2KRGmtVahbhbv9tkPDlqfwysB5chtnQeyvSBLn+SUbf1gTHUo 5ak/zdRd9TsqiSlsRwsM85/SjjapOCPRuEdR/GT/mdedFidKKqJijp54MJ4MdKz3HeIF+wHE1 LUOQxPL0OD3wdGjGsTpMRdiHfv5YYddxwWgTZhN61SR8ieAqWyt85delzJQlheeQSLBsCg3ib rpYhFsceTQsb91Fi+w8T0eWD7IdDgtCiiYk593iXEqtPd2xL8vbZns/tM1c= Cc: u-boot@lists.denx.de, Heinrich Schuchardt Subject: [U-Boot] [PATCH 1/1] net/arp: remove superfluous assignments X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" The value of variable pkt is never used. The problem was indicated by clang scan-build. Signed-off-by: Heinrich Schuchardt --- net/arp.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/net/arp.c b/net/arp.c index 824d2e9393..f3ceff9ed8 100644 --- a/net/arp.c +++ b/net/arp.c @@ -125,7 +125,6 @@ void arp_receive(struct ethernet_hdr *et, struct ip_udp_hdr *ip, int len) { struct arp_hdr *arp; struct in_addr reply_ip_addr; - uchar *pkt; int eth_hdr_size; /* @@ -163,9 +162,7 @@ void arp_receive(struct ethernet_hdr *et, struct ip_udp_hdr *ip, int len) case ARPOP_REQUEST: /* reply with our IP address */ debug_cond(DEBUG_DEV_PKT, "Got ARP REQUEST, return our IP\n"); - pkt = (uchar *)et; eth_hdr_size = net_update_ether(et, et->et_src, PROT_ARP); - pkt += eth_hdr_size; arp->ar_op = htons(ARPOP_REPLY); memcpy(&arp->ar_tha, &arp->ar_sha, ARP_HLEN); net_copy_ip(&arp->ar_tpa, &arp->ar_spa);