Message ID | 20170508173058.16957-1-xypron.glpk@gmx.de |
---|---|
State | Accepted |
Commit | 9b57e252ffb85b175b0818bf01fb20086d788f5d |
Delegated to: | Tom Rini |
Headers | show |
On Mon, May 08, 2017 at 07:30:58PM +0200, xypron.glpk@gmx.de wrote: > Error codes should be negative. > > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> Applied to u-boot/master, thanks!
diff --git a/common/env_attr.c b/common/env_attr.c index 5bfe5e3a89..386219087b 100644 --- a/common/env_attr.c +++ b/common/env_attr.c @@ -153,7 +153,7 @@ static int regex_callback(const char *name, const char *attributes, void *priv) } } else { printf("Error compiling regex: %s\n", slre.err_str); - retval = EINVAL; + retval = -EINVAL; } done: return retval;
Error codes should be negative. Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> --- common/env_attr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)