From patchwork Wed May 3 21:44:11 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heinrich Schuchardt X-Patchwork-Id: 758237 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 3wJBWg2cT2z9rxm for ; Thu, 4 May 2017 07:44:30 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id CAD8EC21BE5; Wed, 3 May 2017 21:44:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 4BAFBC21C25; Wed, 3 May 2017 21:44:20 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id AC6B6C21C25; Wed, 3 May 2017 21:44:18 +0000 (UTC) Received: from mout.gmx.net (mout.gmx.net [212.227.15.18]) by lists.denx.de (Postfix) with ESMTPS id 61774C21BE5 for ; Wed, 3 May 2017 21:44:18 +0000 (UTC) Received: from LT002.fritz.box ([95.222.184.236]) by mail.gmx.com (mrgmx003 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MO7ee-1dBXqd1YZQ-005XF5; Wed, 03 May 2017 23:44:15 +0200 From: Heinrich Schuchardt To: Tom Rini , Hannes Petermaier Date: Wed, 3 May 2017 23:44:11 +0200 Message-Id: <20170503214411.14270-1-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.11.0 X-Provags-ID: V03:K0:DRrCk72NQataOK5nQUWswMlDIPl8Z67aNiOBcgkO/yjT8apv0Rv jiyaHqQYSQs67tm0INBBiwRDcmANvCBeAj+5o/CYTwhs9mtxlaix71Ep2wBVjLX5gd1bDJ6 SkH5+uBsK4WjmofVsFh0LD4Q2mSIsUp023oqrSwNMGiBwwpkFKzXCCqpz9/H6KwFvEBDnUf liL8TKsQ+5Sc61/hSa+NA== X-UI-Out-Filterresults: notjunk:1; V01:K0:cCBFHECWkrw=:cjClR9MS1Xnogb9OHBylYC xsAsB1iW2mEkl8pdyWEulsSLjsFoQX1Y1mxKBg7OKWp1Pv+jfqYzTtAnEdwznPChiD2Em6g0y SKZgE91ALH5g4wVMv34CcyzX2PxqcPJjjFX6am8az/bDk4MnOBJZaVB55qz8RC88wZvmrI0wZ uKrAFyoJy2lqGjJXZa8uslaYLOpOhdM/TRUv9vBS8b8nZ2lVT0sPPtXrnphbhtF3eQ55tUFz2 EhEKTo2LAz8pPg+8Sipp9hU9Eag4tiwWJDDMwxMrD83koDrP0z1bU9KDMhZ3jLqqfTL0uujUv I/iRJGT3eVX4jXoFmmgK0dWFWdCNR3wPMFJCF7KPOyOJx9fQU5Hv3d65GmGh0L+VGakLrzSie Ki3FnQD0GCCQ5KqmwiJtLU2fG0nbZaiTJ2NcSn7+yvSaAC6WmNtvwch4tDNDh7UcQBng2TxDn PmWVYJziJzSejDNbKAmau4MJ68x5BcpBr/kZtRO3Mcndi7odqEWv05aN3abJobDmKroNQ+3p7 eLXTz19ZzKJgHacFlJ6f3VyRhZIDFoWjN1gnotGtt7ReKAys9xMmTSpyPc1SfVD8mSsvn9eIU P2uijHoHn91jMCeDf6qiH8nGRtRuZCCiwxiRjxVZzm8kO04hzE3GDk1vHTc5komrD+QoyGOt6 o10jwPfD6HFn+Nu4KHHxHwhV1Dm5FeZm+ZGrsWLOe45eagrBUY6LE9JhtkpfAESmRQOSsk+up oCJjIn9SgAKpLo/2btrnlTk0VlLFJZVUhClV7hhnAf8jCBGY5XkuemS1kFU= Cc: Scott Wood , Heinrich Schuchardt , u-boot@lists.denx.de Subject: [U-Boot] [PATCH] board/BuR/common: incorrect check of dtb X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" The logical expression to check the dtb is incorrect in load_devicetree. The problem was indicated by cppcheck. Signed-off-by: Heinrich Schuchardt Reviewed-by: Hannes Schmelzer Acked-by: Hannes Schmelzer --- I do not have a board for testing. Please, review carefully. --- board/BuR/common/common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/board/BuR/common/common.c b/board/BuR/common/common.c index 876150402c..c0316b9ebd 100644 --- a/board/BuR/common/common.c +++ b/board/BuR/common/common.c @@ -265,7 +265,7 @@ static int load_devicetree(void) char *dtbname = getenv("dtb"); char *dtbdev = getenv("dtbdev"); char *dtppart = getenv("dtbpart"); - if (!dtbdev || !dtbdev || !dtbname) { + if (!dtbdev || !dtbpart || !dtbname) { printf("%s: // missing.\n", __func__); return -1; }