From patchwork Wed May 3 21:31:58 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heinrich Schuchardt X-Patchwork-Id: 758231 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 3wJBFZ54xGz9ryT for ; Thu, 4 May 2017 07:32:18 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id 697BEC21C5F; Wed, 3 May 2017 21:32:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 78C0BC21C25; Wed, 3 May 2017 21:32:11 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 55937C21C25; Wed, 3 May 2017 21:32:10 +0000 (UTC) Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) by lists.denx.de (Postfix) with ESMTPS id 022A9C21BE5 for ; Wed, 3 May 2017 21:32:09 +0000 (UTC) Received: from LT002.fritz.box ([95.222.184.236]) by mail.gmx.com (mrgmx102 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MSY2q-1dXUMZ1syC-00Rcgy; Wed, 03 May 2017 23:32:03 +0200 From: Heinrich Schuchardt To: Prafulla Wadaskar , Luka Perkov , Stefan Roese Date: Wed, 3 May 2017 23:31:58 +0200 Message-Id: <20170503213158.14106-1-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.11.0 X-Provags-ID: V03:K0:8qSXP9354B9Z43bugGmXh22MkernxVuKTwaAGSzZreq1RISnq8w pKuB0D7+TwYR3FQB8iEruhJdx9ZXy3cWykOZ8bX7tgbLWmNQB1xBxoe4vvI18ZNXMoY1Ja9 7irLXCEjCVzNP0iI7UVAp0N2FrVGmRSS2Am++AQTfBj5v92er7C0lDdeEzY/Atinpkx92F9 olgvXlLq1D0r7dyM34r3Q== X-UI-Out-Filterresults: notjunk:1; V01:K0:E15cMOAlOeM=:4TgJ/1zJDhq4d9nwipFeEi 0UVaPbVfQfURbCFv6uszJ/kKjzUsPah4etKqbbqRHnd/px6KjbavhRfrCKQk0U7lZNJvOrGgt v9QFohFNGNgPZzvHBafz9wMTJmU0Xpnag05jrv/15UwtX8qg9z0rUJfMpqgFRwvFU8+uNpVNA uJf75PoshwKZ615VyVl+gAMnW3sGbiQBEi+RLQ5PbTk/1rgbzcB8JIT6EZNtSdHzdjDmlqFtY 1IS9iw5tAI63x4mRiuJuoH8EXW40MiiQR8bc8gTfD5amOKF39u1fd6F9ZZ4C4mvJW4FeDM89R cbG5LHd54dIJ/10pzyo/95D8vWnNVhNT/o5nIygFWFy2ywju1oZTyhl6iFp811TWMluIH7svp 4qWnJpefwEcNWF/1xCMphLIeu3N92UdpHlRTbUxsWVrrdL0szY3JVLAmHV+G/wC/TAeOGGihL EeVRXn0SlZmsYLNqGCgtqQaMCU1r3AeflJR0WBZUJTSnlYse5X321ZZ6HN9VK7Tzx0PqxU+xn oajMCg+NVQvVVRzuHqi/fmvb2NnEhCdoCl0YrA8AkUFxoDFX8GEprOrQ9roj2PBBdrXHtC1Sp PQzyaJbDXGg6vdI8zQ/aF1Yc0It+RV6JOs1y3VENzh+M6r/yDMF7I6hU7N0mkoSxYpRZp9w5d CD9EcTaRM2J9mAWCBixyCKtxFDPrrjGeDarzHh8JCR0m98iKMSSaf6B3L8MUUWUtx/8rvMGb6 Z0OmwnaDqa1Vhn1Q59y3HJ+dpe5kwEi6wsovbBOnXYZ28pv6sNHzWLQY+fY= Cc: Heinrich Schuchardt , u-boot@lists.denx.de Subject: [U-Boot] [PATCH 1/1] arm64: mvebu: incorrect check of fdt address cells X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" In dram_init_banksize there seems to be a typo concerning a plausibility check of the fdt. Testing sc > 2 twice does not make any sense. The problem was indicated by cppcheck. Signed-off-by: Heinrich Schuchardt --- I do not have a board for testing. So review carefully. --- arch/arm/mach-mvebu/arm64-common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-mvebu/arm64-common.c b/arch/arm/mach-mvebu/arm64-common.c index 1c0477a3ca..2ef5726905 100644 --- a/arch/arm/mach-mvebu/arm64-common.c +++ b/arch/arm/mach-mvebu/arm64-common.c @@ -94,7 +94,7 @@ int dram_init_banksize(void) ac = fdt_address_cells(fdt, 0); sc = fdt_size_cells(fdt, 0); - if (ac < 1 || sc > 2 || sc < 1 || sc > 2) { + if (ac < 1 || ac > 2 || sc < 1 || sc > 2) { printf("invalid address/size cells\n"); return -ENXIO; }