From patchwork Sat Apr 15 14:25:25 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heinrich Schuchardt X-Patchwork-Id: 751044 X-Patchwork-Delegate: hs@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 3w4xdr6k1jz9s7k for ; Sun, 16 Apr 2017 00:25:52 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id A467CC21C49; Sat, 15 Apr 2017 14:25:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_MSPIKE_H2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 704E2C21C45; Sat, 15 Apr 2017 14:25:43 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 6B4F1C21C45; Sat, 15 Apr 2017 14:25:41 +0000 (UTC) Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) by lists.denx.de (Postfix) with ESMTPS id 16762C21C3F for ; Sat, 15 Apr 2017 14:25:41 +0000 (UTC) Received: from LT002.fritz.box ([95.222.184.236]) by mail.gmx.com (mrgmx103 [212.227.17.168]) with ESMTPSA (Nemesis) id 0M9s8K-1csknZ2HKS-00B5kE; Sat, 15 Apr 2017 16:25:37 +0200 From: Heinrich Schuchardt To: Ladislav Michl Date: Sat, 15 Apr 2017 16:25:25 +0200 Message-Id: <20170415142525.27402-1-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.11.0 X-Provags-ID: V03:K0:JZJZAM1feCnkjGv+HTwLX2L+M8lzdLoWOBz9ddOc8JwI6WrjbhD fetuiJkxWAG9qD3WpTRZpHsrs47zo7BxLV0e1d2ma8ahrqNMgUhrsI9H+5y34Msc3HU/37E QGh/IrmKb/XHlVRzQthHxasuKumATp9+y6Nxv8x3M8OaJkupPZcPmc/R93oMctRw00+Ovwg xzeFJbIge5JdT1TEZsujw== X-UI-Out-Filterresults: notjunk:1; V01:K0:NDEVdkNRrYw=:dyd4VvbbAkdOquTiJI+jtg bejXeqq5f0jOgqlI61XScxM0/Oj1dzAUyrpwLF/NAWuW28BBkBzNV2uqi3iUFVU1ex6suW0ph tV0sRLyikPssQUcUfF4pbw5YU7t4AO9Ly9YldMadfFaTnqZ+Foc3upHYMkFjgRhCu2LJ8m16y STMKqYi6MxtYA12X9BUq3vkpyluPRS2VLk0kOx3+DrtSB7E7iBrF3kRh6oa5BTaPGiZ2tORxg gc8AXu9nGAGie3JbChv/qaiYbF1XtYy1iiU/2AyguQpu34nwrh+CwKySnCDxrfXLaJwCOswzp xDp+hgna749PUkXxFfKwYLR87WIUlEbcbnpF8cAwslpZtoKvE1Eocy7Qzvr9tjwRsM6quvUwC GpFh0elHV7ZEF9a3OqTY9y1Z0ImxTUMftsgiKzC3rIgq1DTv+qhLX3M30GfYOISF/0+jQdpr5 BEDRVeNE6wW5aacdjsolHo8WSd5Q2M+aHdkH6w2aoC8FL9T3pa1Y9hjCKNKJM15SSmr6jhRDd iTTuZrqUVG3EPMQqqkUpkJWNrdvwIzVUEL0T4GSQD4DlL3O/wP4kgCmktRIPlceB2ZWk9uFZc GA8WNmPaUb5sbq5qgOaXuceb+eg5YmIC3vJUsjo1rdofIPMELB4B/nVny1LJTm7qlF+tF8KST EVRPW03yVTtAIwdAPgGC2SeDimisEQrZnfh7pco4OaF303RPPYMPFbu4d6KFf072FZdzgPXsS LPQk/aMsa1uRFjRYodGIdpcSvrpyIkGe1+uxWhbxgimGyEl+Fobe/fOLf9A= Cc: Heinrich Schuchardt , u-boot@lists.denx.de Subject: [U-Boot] [PATCH] cmd: ubi: remove unnecessary logical constraint X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" A size_t variable can never be negative. The problem was indicated by cppcheck. Signed-off-by: Heinrich Schuchardt Reviewed-by: Tom Rini Reviewed-by: Heiko Schocher --- cmd/ubi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/ubi.c b/cmd/ubi.c index efc43ffde9..222be5a357 100644 --- a/cmd/ubi.c +++ b/cmd/ubi.c @@ -308,7 +308,7 @@ int ubi_volume_begin_write(char *volume, void *buf, size_t size, return ENODEV; rsvd_bytes = vol->reserved_pebs * (ubi->leb_size - vol->data_pad); - if (size < 0 || size > rsvd_bytes) { + if (size > rsvd_bytes) { printf("size > volume size! Aborting!\n"); return EINVAL; }