From patchwork Sat Apr 15 14:11:12 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heinrich Schuchardt X-Patchwork-Id: 751043 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 3w4xKB0f16z9s7h for ; Sun, 16 Apr 2017 00:11:26 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id B32BAC21C49; Sat, 15 Apr 2017 14:11:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_MSPIKE_H2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id A8627C21C45; Sat, 15 Apr 2017 14:11:20 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 0D64EC21C45; Sat, 15 Apr 2017 14:11:19 +0000 (UTC) Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) by lists.denx.de (Postfix) with ESMTPS id 9CD16C21C3F for ; Sat, 15 Apr 2017 14:11:19 +0000 (UTC) Received: from LT002.fritz.box ([95.222.184.236]) by mail.gmx.com (mrgmx103 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MVvDo-1cWq1l07I0-00X7wN; Sat, 15 Apr 2017 16:11:17 +0200 From: Heinrich Schuchardt To: Albert Aribaud Date: Sat, 15 Apr 2017 16:11:12 +0200 Message-Id: <20170415141112.27145-1-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.11.0 X-Provags-ID: V03:K0:dZ8rHTaL+ybZdWNoCisvEYW9h9WuEPRPwhdWVTn7Zr1aeZvK3wa WtfYJQw41omfpYvuo+bd2BM2LVyzeuTWnFBKazJ32y4H6yU7bmP/kF8OxMW6lOinlkxqM1Q cmUlF3cMlhPN4aPPrhqSqk+si7NR7Q9uMenlz9mp7XbMt7O7QIE3alq2a0qCjrwEzHt+7Yj TV91ITE3WntmQaDry4vmg== X-UI-Out-Filterresults: notjunk:1; V01:K0:Pu1XtSwi2N4=:U1jYFSWSLJ74zbEIPol39M CyTO94FESAn2gP2Awz0A95H99noRz176dSyD+DUjLmbRA2PxzFP9tZoocojAcYN7bWr+TDgY4 tOnkew6z/It3OGQ8XmKe8dDUv0M3mmfG5Mt2BmGwpfWNyXjMxhAUwWjDIe/TczBQyvmtRJXwB crTSBD6XLzJHLCCrVImIMF8npq8C1yULJeIU6v1k/H9zi6PdJwzBPti1siY7tBEuwDQBOxIEv ND5ceAG7NKyrEmY4pXvzCrQI4RIoM33jh65cE2zVW7jLJPuq5I/jmpyeosyw2gDBsaU5jbCpI yB75+/GIAnEDIChkgjAlLxj22jUC2VvVvF4d3I4inRow43IT+q1KVKYK9TTs9cBKJE3M1bXf5 RSVQdBnlyfubXQKP1P0EhNC+Gipv1NV7pE3t4JnOxlSbohPRr4eypjXfJsUl9DR6+GuvZRvgX tGwTi7FbN5b7ZSjUJ0LhEZwOF5lAq87pGj7jmzTbkSrsatd5whAkH2KOh5Ih5KAZ25YZ6UX+H uaPa5vH7aQM/JSbRksqvqNVYabE4Kn6PWigb9FL8m68Fy99XIWUJBMZv+OXXtn0Y/ItqTj6Kr DalA59OmJn0E+urCLmDE2xVqifli/ZztqCl5wkk/LMyfg/RLrqRzz7phJT59vUI0d7nXEalpE s/fEZ+Zd0GJKpP5kJhrZ/BdE1OVr54fJGe8kfc36rnrBWRYM4tP+Xr5sOLrFD2iWHGRhsr0ut Y1Tv95ebwFXOORP5HpnImlQXO63lrnQXd3XyXTubEaNgbezXIyIlCyNdQ8c= Cc: Tom Rini , Heinrich Schuchardt , u-boot@lists.denx.de Subject: [U-Boot] [RFC 1/1] omap3: incorrect logical check in do_emif4_init X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" ((readl(&emif4_base->sdram_iodft_tlgc) & (1<<10)) == 0x01) is always false. This does not match the comment /*Wait till that bit clears*/ The problem was indicated by cppcheck. I do not have the hardware to test if the code change below leads to a correct system behavior. Signed-off-by: Heinrich Schuchardt Reviewed-by: Simon Glass --- arch/arm/mach-omap2/omap3/emif4.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-omap2/omap3/emif4.c b/arch/arm/mach-omap2/omap3/emif4.c index d540cf08d2..8197e7b032 100644 --- a/arch/arm/mach-omap2/omap3/emif4.c +++ b/arch/arm/mach-omap2/omap3/emif4.c @@ -76,7 +76,7 @@ static void do_emif4_init(void) regval |= (1<<10); writel(regval, &emif4_base->sdram_iodft_tlgc); /*Wait till that bit clears*/ - while ((readl(&emif4_base->sdram_iodft_tlgc) & (1<<10)) == 0x1); + while ((readl(&emif4_base->sdram_iodft_tlgc) & (1<<10)) != 0x0); /*Re-verify the DDR PHY status*/ while ((readl(&emif4_base->sdram_sts) & (1<<2)) == 0x0);