From patchwork Sat Apr 15 13:31:53 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heinrich Schuchardt X-Patchwork-Id: 751033 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 3w4wS25Bk0z9s7f for ; Sat, 15 Apr 2017 23:32:18 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id 1D1C9C21C52; Sat, 15 Apr 2017 13:32:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 696F3C21C45; Sat, 15 Apr 2017 13:32:03 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 9F545C21C45; Sat, 15 Apr 2017 13:32:01 +0000 (UTC) Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) by lists.denx.de (Postfix) with ESMTPS id 4B199C21C3F for ; Sat, 15 Apr 2017 13:32:01 +0000 (UTC) Received: from LT002.fritz.box ([95.222.184.236]) by mail.gmx.com (mrgmx101 [212.227.17.168]) with ESMTPSA (Nemesis) id 0M0tr1-1cBpgX1QtT-00v8jK; Sat, 15 Apr 2017 15:31:58 +0200 From: Heinrich Schuchardt To: Dave Liu Date: Sat, 15 Apr 2017 15:31:53 +0200 Message-Id: <20170415133153.26062-1-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.11.0 X-Provags-ID: V03:K0:qxWcOYbExfIiFD11wqZARlXl5gqZk9M/CEc0l9pGCqFX9QxDVyl jvifJUyuf3sb0a1ZMGVvMgd8eypA+x0YKspQXiqQfLf8pWTW2MvcElira0BKUCcZxqEqrF/ Z02VIM5dPnMaWg/oRPM4rmKgjSF8ZuzuVb5nfLH3dM5qd1YoL1yF9hcGsdXRxrO5XX2X68G 7RpApnEry0jH8z34d5oiQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:+cTM+lBtBtQ=:z5RIh+GhZoN5nJg1nYalzn eCkmpi9gTVYBG+DqSgUT2X/ECTQWlwqu20z1RVIvVHDuDVW99wA6AXGZxqGi4JLqNql7iZub0 bXAsOJbjPadGuZg5FpGvf+p9pHxRUXOHZ6QY5zW+keiQSW+OEMjfgDJBYKC4fNg5NncXqEeVE 0qm5MxgcHFMrRWCCW4DgJGQ9Hw4xAXIyB+W1gLRKhV6wQ3DGx8YRiiCdjPT0juv51IcMlOe6G sFXk4IKFY2xPE4U3tpoBtyVjg8HzwCsALYo7kcySdKgdVimfL6UYhaw63z25BU1KAaXKXvfZa cBiWxkQ17itMtEd+l6P99nEsLhpkrF8OKePT0H2HIXJglpizDQw6met/3+hIIYQU4SJWeKpxP Bdy11X/soL00R5X2HmZ9De/QN7VPutK1dCaFfxrm93dT59W70tg37s7BJerIFHCPUhlmN+vDe Nn6fTShN1lTWYAM48sR1TJ4tfkf6je2f9I3AuDNYw+fv+we/TjITj6+2JNnYHeBvZ0InE7Auy xNKPfmODOsZpynSr4O0ja4TynU5HhfSEzaRsuQFBDRmURZNYRK7eT2LJfld4VcpuUzJ9ex2bV t1MAiDUaOZmXzet5qNUPMdh7WnA9Y44/qDK3+RP2Mgl8XcvLCtNcxGtcGQQlerogVvS9ZZ1FQ VKqDBLR6XNN33GCMjB5U954Zl+fzBl7MLTQaN4IIHLv4raQfFQVh1qu0FocazylCr/X1YFk47 gYoD/L8LsJob65p6Kr5lffMDZ7ncLCbUNIIvD3IFydUm8ffixR7h3GS5hjs= Cc: Tang Yuantian , Kim Phillips , Heinrich Schuchardt , u-boot@lists.denx.de Subject: [U-Boot] [PATCH 1/1] fsl/sata: correctly identify failed malloc X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" After allocating sata->cmd_hdr_tbl_offset we have to check this variable and not variable sata. The problem was indicated by cppcheck. Signed-off-by: Heinrich Schuchardt Reviewed-by: Tom Rini --- drivers/block/fsl_sata.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/fsl_sata.c b/drivers/block/fsl_sata.c index e000ebff76..31f7fab8b4 100644 --- a/drivers/block/fsl_sata.c +++ b/drivers/block/fsl_sata.c @@ -124,7 +124,7 @@ int init_sata(int dev) length = sizeof(struct cmd_hdr_tbl); align = SATA_HC_CMD_HDR_TBL_ALIGN; sata->cmd_hdr_tbl_offset = (void *)malloc(length + align); - if (!sata) { + if (!sata->cmd_hdr_tbl_offset) { printf("alloc the command header failed\n\r"); return -1; }