From patchwork Sat Apr 15 11:28:13 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heinrich Schuchardt X-Patchwork-Id: 751026 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 3w4sjP3PM0z9s7j for ; Sat, 15 Apr 2017 21:28:41 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id 2DCDFC21C61; Sat, 15 Apr 2017 11:28:35 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_MSPIKE_H2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 5344EC21C3C; Sat, 15 Apr 2017 11:28:33 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 89543C21C3C; Sat, 15 Apr 2017 11:28:31 +0000 (UTC) Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) by lists.denx.de (Postfix) with ESMTPS id 386E6C21C2C for ; Sat, 15 Apr 2017 11:28:31 +0000 (UTC) Received: from LT002.fritz.box ([95.222.184.236]) by mail.gmx.com (mrgmx102 [212.227.17.168]) with ESMTPSA (Nemesis) id 0Ls7MZ-1c31vv3PqB-013zQE; Sat, 15 Apr 2017 13:28:28 +0200 From: Heinrich Schuchardt To: u-boot@lists.denx.de Date: Sat, 15 Apr 2017 13:28:13 +0200 Message-Id: <20170415112813.17349-1-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.11.0 X-Provags-ID: V03:K0:R1s/bL0PaTZyZuSWbySt5Mrqz/smlLGTuuqIuBQtovuSa/ytSWq wW3RA6s9pKlLQJNSnuwWAq3yKntCRwKsqWiILPxtcNtEh5W9+IkWDX82pWjVfJXSzqm9PSv LRSgd1o0Vl5uCkLQzZ6GVOA1FJCX/zNEAzOCoBo69XfcSXEjVRPiZo++14KH7EerRn1h6ad IoRWZHmGuBq7mQEMkNuZQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:hcBTVCvw5GE=:4+l4SN9inuKJRGPWPybpye vIQC4c/0Mzx0nD1OW2EINMUUstzurpQeWjiOc3y02QaTRJoNdsh+2zrxZJXnvE9/zz2W2bo14 xe9eYU0bV3NI3XWVZ6hGfJpYcjb2l4VNdjnYg8PY+sToSuhBsZQLwxUDgrTTCHGHjMJ57vDfh oiN/DQwLlbAo29xWODvvGwqmr6bpv8a90XTmSPOQ+wtqbx76GurqdgTPbnJTZiUk2Sh5bA9VQ S6+XhSuFGeWgwA/CtbCdTIBthCAudxS1Qielz8JBpa6ScS5R4+sCHs2/e9GJYu84MWjDWKY50 A44JvtbxyXCjIrqLPTJAjhZnGR+HjqU32tm7FDlSbF9ja392IFpljg7WU674bWM2iW7KE/0Kx dcm1vBzbb8aWkqG2/fGJZt6atZ3QXrIOCbeLWApsgotDCDLhCzYgHvT1ChUWS7OxU9RB81/31 lZiOLCllaeyifFg5TTv2QDl0zrTpK+0qnMPzJqq7aluCXmgGLjMYx7XybFsL8ZFAyhuJB0FrC JjdTVDwuL8idmOYGe0/9JIsROGjyYXeaDfU1raklkfktUqnmGJt27vYuBeMm7iqBJNSnHgLky RB7OWu/XcgwLxpQTDbIRpM1+q46ntGZhrgqZY0HSLxTvcT4zehtoR0FREPgOdQXe/rN0IZSdz OfM8eo42We/kNFDLho5E4K347vjO5DxAst1Db/qYqtkorSBBRsNSUdHRfgi0dhzKWK5Oby6fB MUILudqIKREq80M3Z9X/unpMevwuVydUkRKiPWbgkIBpkn21ncahgy1a8+k= Cc: Tom Rini , Heinrich Schuchardt , Jeroen Hofstee Subject: [U-Boot] [PATCH 1/1] yaffs2: remove redundant condition X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" If !parent, the changed line is not reached. So there is no need to check the value again. Signed-off-by: Heinrich Schuchardt Reviewed-by: Tom Rini --- fs/yaffs2/yaffsfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/yaffs2/yaffsfs.c b/fs/yaffs2/yaffsfs.c index 41e5f0108c..ba76a5ccdb 100644 --- a/fs/yaffs2/yaffsfs.c +++ b/fs/yaffs2/yaffsfs.c @@ -3018,7 +3018,7 @@ int yaffs_symlink(const YCHAR *oldpath, const YCHAR *newpath) yaffsfs_SetError(-ENFILE); else if (parent->my_dev->read_only) yaffsfs_SetError(-EROFS); - else if (parent) { + else { obj = yaffs_create_symlink(parent, name, mode, 0, 0, oldpath); if (obj) retVal = 0;