From patchwork Fri Mar 10 11:26:36 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gary Bisson X-Patchwork-Id: 737371 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 3vflMv6GtDz9s7m for ; Fri, 10 Mar 2017 22:26:51 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=boundarydevices-com.20150623.gappssmtp.com header.i=@boundarydevices-com.20150623.gappssmtp.com header.b="RLZrZf/D"; dkim-atps=neutral Received: by lists.denx.de (Postfix, from userid 105) id 9A36FC21C58; Fri, 10 Mar 2017 11:26:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=RCVD_IN_MSPIKE_H2, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 026EFC21C39; Fri, 10 Mar 2017 11:26:46 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 25FC4C21C39; Fri, 10 Mar 2017 11:26:44 +0000 (UTC) Received: from mail-wr0-f175.google.com (mail-wr0-f175.google.com [209.85.128.175]) by lists.denx.de (Postfix) with ESMTPS id AA8A7C21C30 for ; Fri, 10 Mar 2017 11:26:43 +0000 (UTC) Received: by mail-wr0-f175.google.com with SMTP id g10so63003465wrg.2 for ; Fri, 10 Mar 2017 03:26:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=boundarydevices-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=XbkX3L619GDaj7mRa3BpHRvie0d1OSZgaKt+0v1Ii50=; b=RLZrZf/DeyE6Pj29OUPIMRM0K1SCBoYEfiZ3rHAiE2aWdYBgqDixb3BEIC3iJAY+kn oTree4p5aMJSTJY4WGQsfShYIQfv8exoSYERnP+qGdiZ8Ny4IXX1yAMWG+YrTBbU4L2l mQOtWMx1nGEQYPJ87HwNrZfWcCFJjNFA2WN9S37C1H6dskkLjpObNZw8CzlWiTSDZrWs l5NdaAcSYFVcwRbjf1Ea5pHoxEh1V1FvSSFDYXBXLu/4KVOHlGKV9Nsf98VFvtWGx+Hc Foj0GBxGMzbkPvwUHM1unBA5pSfNMJWWdEbHErnN4K6icybNVDKcitfApJ7v6XmU9prD ODrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=XbkX3L619GDaj7mRa3BpHRvie0d1OSZgaKt+0v1Ii50=; b=RgfHeZXC61a0CLGuHJYLbeb/P/caRr0r9CATMyrO6n/qgFTpJv5Kgx9bivoM73sJDE f1bZKoOpMQ16rzhySDhk+pGT7VStS7bg1oh+RmBvSZS2NUavklEGB8urPFWPJnde9kPL moVvJLtkynqU1/x33Myu2D0v3ON1rK0rlFN0ZsidaYpamSM1Mk/wcfZRQszVRJTPC6hT FYBbVoQVYXn1LDO4GVlkY9zzNqTaU4DljunpZ8uvvVXQM9w8jmycn11xT1cUPoXIk1bo ycJTPJPb3H7lm/bPRTrYXlGxibO8Wi1sqLQXFdGmsNMVUkkAT13qphg5BUkRvWfqa2UG dcwg== X-Gm-Message-State: AMke39nCMgUZY3dyTrMtOkghopbzkKrf1glIKjUiu2grXrT2WXVD5Tc5M7ewnY968zqVTQ== X-Received: by 10.223.162.205 with SMTP id t13mr16566465wra.155.1489145203366; Fri, 10 Mar 2017 03:26:43 -0800 (PST) Received: from localhost.localdomain (LMontsouris-657-1-10-89.w90-63.abo.wanadoo.fr. [90.63.251.89]) by smtp.googlemail.com with ESMTPSA id s18sm2879701wmb.18.2017.03.10.03.26.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 10 Mar 2017 03:26:42 -0800 (PST) From: Gary Bisson To: u-boot@lists.denx.de Date: Fri, 10 Mar 2017 12:26:36 +0100 Message-Id: <20170310112636.7999-1-gary.bisson@boundarydevices.com> X-Mailer: git-send-email 2.11.0 Cc: marex@denx.de, Gary Bisson , hdegoede@redhat.com, steve.rae@raedomain.com Subject: [U-Boot] [PATCH] arm: cache: exit maintenance functions when cache disabled X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" No need to check the region range and send commands when the cache isn't even enabled. Signed-off-by: Gary Bisson --- Hi all, This is a follow-up to this thread: https://lists.denx.de/pipermail/u-boot/2017-March/283423.html Although what started the conversation was the sparse-image flashing procedure, it appears cache maintenance functions don't check on cache status. Regards, Gary --- arch/arm/cpu/armv7/cache_v7.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/cpu/armv7/cache_v7.c b/arch/arm/cpu/armv7/cache_v7.c index c4bbcc3cc3..992cdeaa6e 100644 --- a/arch/arm/cpu/armv7/cache_v7.c +++ b/arch/arm/cpu/armv7/cache_v7.c @@ -117,6 +117,9 @@ void flush_dcache_all(void) */ void invalidate_dcache_range(unsigned long start, unsigned long stop) { + if (!dcache_status()) + return; + check_cache_range(start, stop); v7_dcache_maint_range(start, stop, ARMV7_DCACHE_INVAL_RANGE); @@ -131,6 +134,9 @@ void invalidate_dcache_range(unsigned long start, unsigned long stop) */ void flush_dcache_range(unsigned long start, unsigned long stop) { + if (!dcache_status()) + return; + check_cache_range(start, stop); v7_dcache_maint_range(start, stop, ARMV7_DCACHE_CLEAN_INVAL_RANGE);