| Message ID | 20161104115521.GA7713@localhost.localdomain |
|---|---|
| State | Accepted |
| Commit | ad560f87e0eb5c82a4f6393b6f873fa737556a59 |
| Delegated to: | Tom Rini |
| Headers | show |
On Fri, Nov 04, 2016 at 12:42:57PM -0300, Javier Martinez Canillas wrote: > Hello Ladis, > > On 11/04/2016 08:55 AM, Ladislav Michl wrote: > > As a single U-Boot binary can now run on various board modifications, > > drop CONFIG_DISPLAY_BOARDINFO as it prints flash memory information > > too early to give us chance to easily detect it. Also saves few bytes > > as a bonus. > > > > Signed-off-by: Ladislav Michl <ladis@linux-mips.org> > > --- > > I tried to test your patches on latest u-boot master (sha-1 dd93a8e9e688) > but my IGEPv2 board fails to boot and prints in an infinite loop following: > > "ecc unrecoverable error" This comes from SPL, right? That would imply you boot from NAND... > This is not related to your patches though, since I've the same issue > without your patches applied. > > Did you see this issue? u-boot works with previous v2016.09 release so > this is a newly introduced regression. No, otherwise I would fix that. Care to send complete boot log if there is any? > Unfortunately I don't have time to dig deeper on this but I may give a > try next week. Thank you, ladis
Hello Ladis, On Fri, Nov 4, 2016 at 2:21 PM, Ladislav Michl <ladis@linux-mips.org> wrote: > On Fri, Nov 04, 2016 at 12:42:57PM -0300, Javier Martinez Canillas wrote: >> Hello Ladis, >> >> On 11/04/2016 08:55 AM, Ladislav Michl wrote: >> > As a single U-Boot binary can now run on various board modifications, >> > drop CONFIG_DISPLAY_BOARDINFO as it prints flash memory information >> > too early to give us chance to easily detect it. Also saves few bytes >> > as a bonus. >> > >> > Signed-off-by: Ladislav Michl <ladis@linux-mips.org> >> > --- >> >> I tried to test your patches on latest u-boot master (sha-1 dd93a8e9e688) >> but my IGEPv2 board fails to boot and prints in an infinite loop following: >> >> "ecc unrecoverable error" > > This comes from SPL, right? That would imply you boot from NAND... > >> This is not related to your patches though, since I've the same issue >> without your patches applied. >> >> Did you see this issue? u-boot works with previous v2016.09 release so >> this is a newly introduced regression. > > No, otherwise I would fix that. Care to send complete boot log if there is > any? > As talked on irc, this is because I don't have an UBI partition on my NAND. I've just commented the error messages for now to be able to boot since this is an unrelated issue. >> Unfortunately I don't have time to dig deeper on this but I may give a >> try next week. > > Thank you, > ladis Best regards, Javier
Hello Ladis, On Fri, Nov 4, 2016 at 8:55 AM, Ladislav Michl <ladis@linux-mips.org> wrote: > As a single U-Boot binary can now run on various board modifications, > drop CONFIG_DISPLAY_BOARDINFO as it prints flash memory information > too early to give us chance to easily detect it. Also saves few bytes > as a bonus. > > Signed-off-by: Ladislav Michl <ladis@linux-mips.org> > --- Patch looks good to me. Reviewed-by: Javier Martinez Canillas <javier@samsung.com> I've also tested on an IGEPv2 board: Tested-by: Javier Martinez Canillas <javier@samsung.com> Best regards, Javier
On Fri, Nov 04, 2016 at 12:55:21PM +0100, Ladislav Michl wrote: > As a single U-Boot binary can now run on various board modifications, > drop CONFIG_DISPLAY_BOARDINFO as it prints flash memory information > too early to give us chance to easily detect it. Also saves few bytes > as a bonus. > > Signed-off-by: Ladislav Michl <ladis@linux-mips.org> > Reviewed-by: Javier Martinez Canillas <javier@samsung.com> > Tested-by: Javier Martinez Canillas <javier@samsung.com> Applied to u-boot/master, thanks!
diff --git a/board/isee/igep00x0/igep00x0.c b/board/isee/igep00x0/igep00x0.c index 808955e..71688cc 100644 --- a/board/isee/igep00x0/igep00x0.c +++ b/board/isee/igep00x0/igep00x0.c @@ -27,24 +27,6 @@ DECLARE_GLOBAL_DATA_PTR; -const omap3_sysinfo sysinfo = { - DDR_STACKED, -#if (CONFIG_MACH_TYPE == MACH_TYPE_IGEP0020) - "IGEPv2", -#endif -#if (CONFIG_MACH_TYPE == MACH_TYPE_IGEP0030) - "IGEP COM MODULE/ELECTRON", -#endif -#if (CONFIG_MACH_TYPE == MACH_TYPE_IGEP0032) - "IGEP COM PROTON", -#endif -#if defined(CONFIG_ENV_IS_IN_ONENAND) - "ONENAND", -#else - "NAND", -#endif -}; - static const struct ns16550_platdata igep_serial = { .base = OMAP34XX_UART3, .reg_shift = 2, diff --git a/configs/igep0020_defconfig b/configs/igep0020_defconfig index 9c247d7..c25b6b8 100644 --- a/configs/igep0020_defconfig +++ b/configs/igep0020_defconfig @@ -7,6 +7,7 @@ CONFIG_BOOTDELAY=3 CONFIG_SYS_CONSOLE_IS_IN_ENV=y CONFIG_SYS_CONSOLE_INFO_QUIET=y CONFIG_VERSION_VARIABLE=y +# CONFIG_DISPLAY_BOARDINFO is not set CONFIG_SPL=y CONFIG_SPL_MTD_SUPPORT=y CONFIG_SPL_ONENAND_SUPPORT=y diff --git a/configs/igep0030_defconfig b/configs/igep0030_defconfig index 1312ddb..75f731d 100644 --- a/configs/igep0030_defconfig +++ b/configs/igep0030_defconfig @@ -6,6 +6,7 @@ CONFIG_SYS_EXTRA_OPTIONS="MACH_TYPE=MACH_TYPE_IGEP0030,BOOT_ONENAND" CONFIG_SYS_CONSOLE_IS_IN_ENV=y CONFIG_SYS_CONSOLE_INFO_QUIET=y CONFIG_VERSION_VARIABLE=y +# CONFIG_DISPLAY_BOARDINFO is not set CONFIG_SPL=y CONFIG_SPL_MTD_SUPPORT=y CONFIG_SPL_ONENAND_SUPPORT=y diff --git a/configs/igep0032_defconfig b/configs/igep0032_defconfig index 37e46b0..1819995 100644 --- a/configs/igep0032_defconfig +++ b/configs/igep0032_defconfig @@ -6,6 +6,7 @@ CONFIG_SYS_EXTRA_OPTIONS="MACH_TYPE=MACH_TYPE_IGEP0032,BOOT_ONENAND" CONFIG_SYS_CONSOLE_IS_IN_ENV=y CONFIG_SYS_CONSOLE_INFO_QUIET=y CONFIG_VERSION_VARIABLE=y +# CONFIG_DISPLAY_BOARDINFO is not set CONFIG_SPL=y CONFIG_SPL_MTD_SUPPORT=y CONFIG_SPL_ONENAND_SUPPORT=y
As a single U-Boot binary can now run on various board modifications, drop CONFIG_DISPLAY_BOARDINFO as it prints flash memory information too early to give us chance to easily detect it. Also saves few bytes as a bonus. Signed-off-by: Ladislav Michl <ladis@linux-mips.org> --- Changes in v2: - update to current git (uses Kconfig)