diff mbox

[U-Boot] cmd: load: align cache flush

Message ID 20161025072248.10841-1-judge.packham@gmail.com
State Accepted
Commit 0a6036da63ebc618204cd5c3d5e8cac833845751
Delegated to: Tom Rini
Headers show

Commit Message

Chris Packham Oct. 25, 2016, 7:22 a.m. UTC
Prevent cache misalignment message by ensuring that a whole cache line
is flushed.

Signed-off-by: Chris Packham <judge.packham@gmail.com>
---

 cmd/load.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stefan Roese Oct. 25, 2016, 7:35 a.m. UTC | #1
On 25.10.2016 09:22, Chris Packham wrote:
> Prevent cache misalignment message by ensuring that a whole cache line
> is flushed.
>
> Signed-off-by: Chris Packham <judge.packham@gmail.com>
> ---
>
>  cmd/load.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/cmd/load.c b/cmd/load.c
> index 65557e4f9ec3..77c3359b29b7 100644
> --- a/cmd/load.c
> +++ b/cmd/load.c
> @@ -997,7 +997,7 @@ static ulong load_serial_ymodem(ulong offset, int mode)
>  	xyzModem_stream_terminate(false, &getcxmodem);
>
>
> -	flush_cache(offset, size);
> +	flush_cache(offset, ALIGN(size, ARCH_DMA_MINALIGN));
>
>  	printf("## Total Size      = 0x%08x = %d Bytes\n", size, size);
>  	setenv_hex("filesize", size);
>

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan
Tom Rini Nov. 2, 2016, 2:26 p.m. UTC | #2
On Tue, Oct 25, 2016 at 08:22:48PM +1300, Chris Packham wrote:

> Prevent cache misalignment message by ensuring that a whole cache line
> is flushed.
> 
> Signed-off-by: Chris Packham <judge.packham@gmail.com>
> Reviewed-by: Stefan Roese <sr@denx.de>

Applied to u-boot/master (before v2016.11-rc3), thanks!
diff mbox

Patch

diff --git a/cmd/load.c b/cmd/load.c
index 65557e4f9ec3..77c3359b29b7 100644
--- a/cmd/load.c
+++ b/cmd/load.c
@@ -997,7 +997,7 @@  static ulong load_serial_ymodem(ulong offset, int mode)
 	xyzModem_stream_terminate(false, &getcxmodem);
 
 
-	flush_cache(offset, size);
+	flush_cache(offset, ALIGN(size, ARCH_DMA_MINALIGN));
 
 	printf("## Total Size      = 0x%08x = %d Bytes\n", size, size);
 	setenv_hex("filesize", size);