[U-Boot,1/3] igep00x0: disable CONFIG_DISPLAY_BOARDINFO

As a single U-Boot binary can now run on various board modifications,
drop CONFIG_DISPLAY_BOARDINFO as there's no known way to distinguish
between them. Also saves few bytes as a bonus.

Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
---
 board/isee/igep00x0/igep00x0.c   | 18 ------------------
 include/configs/omap3_igep00x0.h |  5 +----
 2 files changed, 1 insertion(+), 22 deletions(-)

Hi Ladis,

2016-09-20 11:04 GMT+02:00 Ladislav Michl <ladis@linux-mips.org>:
> As a single U-Boot binary can now run on various board modifications,
> drop CONFIG_DISPLAY_BOARDINFO as there's no known way to distinguish
> between them. Also saves few bytes as a bonus.
>
> Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
> ---
>  board/isee/igep00x0/igep00x0.c   | 18 ------------------
>  include/configs/omap3_igep00x0.h |  5 +----
>  2 files changed, 1 insertion(+), 22 deletions(-)
>
> diff --git a/board/isee/igep00x0/igep00x0.c b/board/isee/igep00x0/igep00x0.c
> index 808955e..71688cc 100644
> --- a/board/isee/igep00x0/igep00x0.c
> +++ b/board/isee/igep00x0/igep00x0.c
> @@ -27,24 +27,6 @@
>
>  DECLARE_GLOBAL_DATA_PTR;
>
> -const omap3_sysinfo sysinfo = {
> -       DDR_STACKED,
> -#if (CONFIG_MACH_TYPE == MACH_TYPE_IGEP0020)
> -       "IGEPv2",
> -#endif
> -#if (CONFIG_MACH_TYPE == MACH_TYPE_IGEP0030)
> -       "IGEP COM MODULE/ELECTRON",
> -#endif
> -#if (CONFIG_MACH_TYPE == MACH_TYPE_IGEP0032)
> -       "IGEP COM PROTON",
> -#endif
> -#if defined(CONFIG_ENV_IS_IN_ONENAND)
> -       "ONENAND",
> -#else
> -       "NAND",
> -#endif
> -};
> -
>  static const struct ns16550_platdata igep_serial = {
>         .base = OMAP34XX_UART3,
>         .reg_shift = 2,
> diff --git a/include/configs/omap3_igep00x0.h b/include/configs/omap3_igep00x0.h
> index 1f30710..2ae9737 100644
> --- a/include/configs/omap3_igep00x0.h
> +++ b/include/configs/omap3_igep00x0.h
> @@ -23,11 +23,8 @@
>  #undef CONFIG_SPL_TEXT_BASE
>  #define CONFIG_SPL_TEXT_BASE           0x40200000
>
> -/*
> - * Display CPU and Board information
> - */
> +/* Display CPU information */
>  #define CONFIG_DISPLAY_CPUINFO         1
> -#define CONFIG_DISPLAY_BOARDINFO       1
>
>  #define CONFIG_MISC_INIT_R
>
> --
> 2.1.4
>

I must NACK for now these series, meanwhile I don't find time to look
at this deeply. I think this will break lots of things. For example,
will this u-boot boot a non-device tree based kernel without breaking
things? I don't think so, It's right that non-device tree kernels are
old but these are still used in lots of IGEP boards and I don't want
to break this, for now.

Please give me some time to look at this and think in all the use cases.

Thanks,
  Enric.

Hi Enric,

On Tue, Sep 20, 2016 at 05:41:02PM +0200, Enric Balletbo Serra wrote:
[snip]
> I must NACK for now these series, meanwhile I don't find time to look
> at this deeply. I think this will break lots of things. For example,
> will this u-boot boot a non-device tree based kernel without breaking
> things? I don't think so, It's right that non-device tree kernels are
> old but these are still used in lots of IGEP boards and I don't want
> to break this, for now.
> 
> Please give me some time to look at this and think in all the use cases.

Any chance you'll find time to look at this? I'm sending updated patch serie
as a reply to this email. I do not think it breaks anything and I'll provide
fix if you prove me wrong. Please note, that without "igep00x0: add Hynix
timings" patch some boards are unable to boot. My bad, of course, as I hadn't
all board variants on my table at the time writing runtime flash detection
support.

Thank you,
	ladis