From patchwork Thu Sep 8 12:01:52 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Gray X-Patchwork-Id: 667531 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 3sVJq70v7sz9ryT for ; Thu, 8 Sep 2016 22:02:11 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 4DB66A7544; Thu, 8 Sep 2016 14:02:08 +0200 (CEST) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id R2Oc99np1MCL; Thu, 8 Sep 2016 14:02:08 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id B639AA7534; Thu, 8 Sep 2016 14:02:07 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 425D7A7534 for ; Thu, 8 Sep 2016 14:02:01 +0200 (CEST) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LWFx0WvCet-T for ; Thu, 8 Sep 2016 14:02:01 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from lechuck.jsg.id.au (jsg.id.au [210.15.216.215]) by theia.denx.de (Postfix) with ESMTPS id 0E8F2A752D for ; Thu, 8 Sep 2016 14:01:56 +0200 (CEST) Received: from largo.jsg.id.au (largo.jsg.id.au [192.168.1.43]) by lechuck.jsg.id.au (OpenSMTPD) with ESMTP id 50a6202c; Thu, 8 Sep 2016 22:01:52 +1000 (AEST) Received: from localhost (largo.jsg.id.au [local]) by largo.jsg.id.au (OpenSMTPD) with ESMTPA id 3e24f10a; Thu, 8 Sep 2016 22:01:52 +1000 (AEST) Date: Thu, 8 Sep 2016 22:01:52 +1000 From: Jonathan Gray To: Tom Rini Message-ID: <20160908120152.GB42608@largo.jsg.id.au> References: <20160902223014.86215-1-jsg@jsg.id.au> <20160907180019.GX4990@bill-the-cat> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20160907180019.GX4990@bill-the-cat> User-Agent: Mutt/1.6.2 (2016-07-01) Cc: u-boot@lists.denx.de Subject: Re: [U-Boot] image-fit: switch ENOLINK to ENOENT X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.15 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" On Wed, Sep 07, 2016 at 02:00:19PM -0400, Tom Rini wrote: > On Sat, Sep 03, 2016 at 08:30:14AM +1000, Jonathan Gray wrote: > > > ENOLINK is not required by POSIX and does not exist on OpenBSD > > and likely other systems. > > > > Signed-off-by: Jonathan Gray > > Applied to u-boot/master, thanks! Thanks for applying this and the other patch. In tools/kwboot.c I've also locally changed EPROTO and EBADMSG as they aren't on OpenBSD either. They are in POSIX however so I am trying to get them into OpenBSD, but it will need some time to be scheduled as introducing errnos involves cranking the major version of libc due to the size of the array with errno strings changing. I wasn't sure if the following would be accepted for that reason, thoughts? FreeBSD and NetBSD seems to have definitions for both already. diff --git a/tools/kwboot.c b/tools/kwboot.c index 26b3949..9b50b32 100644 --- a/tools/kwboot.c +++ b/tools/kwboot.c @@ -402,13 +402,13 @@ kwboot_xm_sendblock(int fd, struct kwboot_block *block) rc = 0; break; case NAK: - errno = EBADMSG; + errno = ECONNREFUSED; break; case CAN: errno = ECANCELED; break; default: - errno = EPROTO; + errno = EIO; break; }