diff mbox

[U-Boot] igep00x0: enable CONFIG_CMD_SETEXPR

Message ID 20160121103449.GA22730@localhost.localdomain
State Changes Requested
Delegated to: Tom Rini
Headers show

Commit Message

Ladislav Michl Jan. 21, 2016, 10:35 a.m. UTC
Enable CONFIG_CMD_SETEXPR, useful when passing initramfs end address:
$ fatload mmc 0:1 $rdaddr root.cpio.gz
$ setexpr rdendaddr $rdaddr + $filesize
$ fdt chosen $rdaddr $rdendaddr
$ bootz $loadaddr - $fdtaddr

Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
---
 configs/igep0020_defconfig      | 2 +-
 configs/igep0020_nand_defconfig | 2 +-
 configs/igep0030_defconfig      | 2 +-
 configs/igep0030_nand_defconfig | 2 +-
 configs/igep0032_defconfig      | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

Comments

Tom Rini Jan. 21, 2016, 7:11 p.m. UTC | #1
On Thu, Jan 21, 2016 at 11:35:01AM +0100, Ladislav Michl wrote:

> Enable CONFIG_CMD_SETEXPR, useful when passing initramfs end address:
> $ fatload mmc 0:1 $rdaddr root.cpio.gz
> $ setexpr rdendaddr $rdaddr + $filesize
> $ fdt chosen $rdaddr $rdendaddr
> $ bootz $loadaddr - $fdtaddr

OK, but why do that instead of 'bootz $loadaddr $rdaddr $fdtaddr' ?
Ladislav Michl Jan. 21, 2016, 7:56 p.m. UTC | #2
On Thu, Jan 21, 2016 at 02:11:13PM -0500, Tom Rini wrote:
> On Thu, Jan 21, 2016 at 11:35:01AM +0100, Ladislav Michl wrote:
> 
> > Enable CONFIG_CMD_SETEXPR, useful when passing initramfs end address:
> > $ fatload mmc 0:1 $rdaddr root.cpio.gz
> > $ setexpr rdendaddr $rdaddr + $filesize
> > $ fdt chosen $rdaddr $rdendaddr
> > $ bootz $loadaddr - $fdtaddr
> 
> OK, but why do that instead of 'bootz $loadaddr $rdaddr $fdtaddr' ?

=> bootz $loadaddr $rdaddr $fdtaddr
Wrong Ramdisk Image Format
Ramdisk image is corrupt or invalid

Well, perhaps that could be done with CONFIG_SUPPORT_RAW_INITRD, which
expects size of initrd, not an end address. I'll give it a try and possibly
enable that instead.

	ladis
Ladislav Michl Jan. 21, 2016, 8:03 p.m. UTC | #3
On Thu, Jan 21, 2016 at 08:56:15PM +0100, Ladislav Michl wrote:
> On Thu, Jan 21, 2016 at 02:11:13PM -0500, Tom Rini wrote:
[...]
> > OK, but why do that instead of 'bootz $loadaddr $rdaddr $fdtaddr' ?
> 
> => bootz $loadaddr $rdaddr $fdtaddr
> Wrong Ramdisk Image Format
> Ramdisk image is corrupt or invalid
> 
> Well, perhaps that could be done with CONFIG_SUPPORT_RAW_INITRD, which
> expects size of initrd, not an end address. I'll give it a try and possibly
> enable that instead.

Ok, works and is even already defined in ti_armv7_common.h and
'bootz $loadaddr $rdaddr:$filesize $fdtaddr' is even simpler. Thank you :)

	ladis
diff mbox

Patch

diff --git a/configs/igep0020_defconfig b/configs/igep0020_defconfig
index a96c130..d4b5746 100644
--- a/configs/igep0020_defconfig
+++ b/configs/igep0020_defconfig
@@ -6,6 +6,6 @@  CONFIG_SYS_EXTRA_OPTIONS="MACH_TYPE=MACH_TYPE_IGEP0020,BOOT_ONENAND"
 # CONFIG_CMD_IMLS is not set
 # CONFIG_CMD_FLASH is not set
 CONFIG_CMD_GPIO=y
-# CONFIG_CMD_SETEXPR is not set
+CONFIG_CMD_SETEXPR=y
 CONFIG_SYS_NS16550=y
 CONFIG_NET_RANDOM_ETHADDR=y
diff --git a/configs/igep0020_nand_defconfig b/configs/igep0020_nand_defconfig
index cf3ee79..57a3e78 100644
--- a/configs/igep0020_nand_defconfig
+++ b/configs/igep0020_nand_defconfig
@@ -6,6 +6,6 @@  CONFIG_SYS_EXTRA_OPTIONS="MACH_TYPE=MACH_TYPE_IGEP0020,BOOT_NAND"
 # CONFIG_CMD_IMLS is not set
 # CONFIG_CMD_FLASH is not set
 CONFIG_CMD_GPIO=y
-# CONFIG_CMD_SETEXPR is not set
+CONFIG_CMD_SETEXPR=y
 CONFIG_SYS_NS16550=y
 CONFIG_NET_RANDOM_ETHADDR=y
diff --git a/configs/igep0030_defconfig b/configs/igep0030_defconfig
index 63ce633..1a1f548 100644
--- a/configs/igep0030_defconfig
+++ b/configs/igep0030_defconfig
@@ -6,5 +6,5 @@  CONFIG_SYS_EXTRA_OPTIONS="MACH_TYPE=MACH_TYPE_IGEP0030,BOOT_ONENAND"
 # CONFIG_CMD_IMLS is not set
 # CONFIG_CMD_FLASH is not set
 CONFIG_CMD_GPIO=y
-# CONFIG_CMD_SETEXPR is not set
+CONFIG_CMD_SETEXPR=y
 CONFIG_SYS_NS16550=y
diff --git a/configs/igep0030_nand_defconfig b/configs/igep0030_nand_defconfig
index dce7e06..c59b988 100644
--- a/configs/igep0030_nand_defconfig
+++ b/configs/igep0030_nand_defconfig
@@ -6,5 +6,5 @@  CONFIG_SYS_EXTRA_OPTIONS="MACH_TYPE=MACH_TYPE_IGEP0030,BOOT_NAND"
 # CONFIG_CMD_IMLS is not set
 # CONFIG_CMD_FLASH is not set
 CONFIG_CMD_GPIO=y
-# CONFIG_CMD_SETEXPR is not set
+CONFIG_CMD_SETEXPR=y
 CONFIG_SYS_NS16550=y
diff --git a/configs/igep0032_defconfig b/configs/igep0032_defconfig
index b7f1d61..27a763f 100644
--- a/configs/igep0032_defconfig
+++ b/configs/igep0032_defconfig
@@ -6,6 +6,6 @@  CONFIG_SYS_EXTRA_OPTIONS="MACH_TYPE=MACH_TYPE_IGEP0032,BOOT_ONENAND"
 # CONFIG_CMD_IMLS is not set
 # CONFIG_CMD_FLASH is not set
 CONFIG_CMD_GPIO=y
-# CONFIG_CMD_SETEXPR is not set
+CONFIG_CMD_SETEXPR=y
 CONFIG_SYS_NS16550=y
 CONFIG_NET_RANDOM_ETHADDR=y