Message ID | 20120527212029.GA15012@w500.iskon.local |
---|---|
State | Rejected |
Delegated to: | Prafulla Wadaskar |
Headers | show |
Hi Luka, Am Sonntag 27 Mai 2012, 23:20:29 schrieb Luka Perkov: > NACK. At least in this version. Please double check all the kirkwood > boards (taken from boards.cfg): ups sorry, actually my tree wasn't up to date :( pogo_e02 is missing, too. > diff --git a/board/raidsonic/ib62x0/ib62x0.c > b/board/raidsonic/ib62x0/ib62x0.c index 65f2c2e..f888901 100644 > --- a/board/raidsonic/ib62x0/ib62x0.c > +++ b/board/raidsonic/ib62x0/ib62x0.c > @@ -42,7 +42,7 @@ int board_early_init_f(void) > IB62x0_OE_LOW, IB62x0_OE_HIGH); > > /* Multi-Purpose Pins Functionality configuration */ > - u32 kwmpp_config[] = { > + static const kwmpp_config[] = { this should be static const u32 kwmpp_config[] = { > Also you should note that this patch should be applied after your > patches for lsxl board. ah yes, thanks.
diff --git a/board/raidsonic/ib62x0/ib62x0.c b/board/raidsonic/ib62x0/ib62x0.c index 65f2c2e..f888901 100644 --- a/board/raidsonic/ib62x0/ib62x0.c +++ b/board/raidsonic/ib62x0/ib62x0.c @@ -42,7 +42,7 @@ int board_early_init_f(void) IB62x0_OE_LOW, IB62x0_OE_HIGH); /* Multi-Purpose Pins Functionality configuration */ - u32 kwmpp_config[] = { + static const kwmpp_config[] = { MPP0_NF_IO2, MPP1_NF_IO3, MPP2_NF_IO4,