From patchwork Wed Apr 25 17:43:55 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luka Perkov X-Patchwork-Id: 155046 X-Patchwork-Delegate: prafulla@marvell.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id ED301B6EEB for ; Thu, 26 Apr 2012 03:44:08 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 2C061282EA; Wed, 25 Apr 2012 19:44:04 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ibkw3ZP6B+TH; Wed, 25 Apr 2012 19:44:03 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 4550528270; Wed, 25 Apr 2012 19:44:01 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 6DCFD28270 for ; Wed, 25 Apr 2012 19:43:59 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YRoBVvPB-Ycn for ; Wed, 25 Apr 2012 19:43:58 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mail-bk0-f44.google.com (mail-bk0-f44.google.com [209.85.214.44]) by theia.denx.de (Postfix) with ESMTPS id 78F35281DD for ; Wed, 25 Apr 2012 19:43:55 +0200 (CEST) Received: by bkuw5 with SMTP id w5so296034bku.3 for ; Wed, 25 Apr 2012 10:43:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-type:content-disposition:in-reply-to :user-agent:x-gm-message-state; bh=gHIRTXy3R8QiuNS19Ddb/8TyeRTIjesC4sjywHsllpk=; b=ecgcoTAkr3osoMAPiAw9xhhwi1pbfbGBL9yJHIVrHvrf0armzyu/Dbr/rtVAHY6uod Iex/WhugNi78wWYAVxxrCizY229ofHvGPBCaCjwpqkglDfO3rjjV8qDPuoRq1FIvPNHg svgCpmRW0DG/FGj1RmaKJyBo5GORRwJKuHh5PxwbJsK8JU5JhsHKoGZYlRHLGysBoTmk 5f0wMKJh88pxy5YY697j7yvqywnFjdswkvkS7jDqpNfaKmF/dXuO5YAFMMOFtEqt42/k gIwUpD+VoOx9yvN45eYBmg7S3lQhLbiOSlodfkWfHyUK9AZVF8UJ3vXuPmXcEKHoCQDm CKLQ== Received: by 10.204.155.73 with SMTP id r9mr1135746bkw.22.1335375833293; Wed, 25 Apr 2012 10:43:53 -0700 (PDT) Received: from localhost (213-191-157-185.dhcp.iskon.hr. [213.191.157.185]) by mx.google.com with ESMTPS id iq2sm668324bkc.1.2012.04.25.10.43.50 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 25 Apr 2012 10:43:51 -0700 (PDT) Date: Wed, 25 Apr 2012 19:43:55 +0200 From: Luka Perkov To: Wolfgang Denk Message-ID: <20120425174355.GA1087@w500.lan> Mail-Followup-To: Wolfgang Denk , Daniel Stodden , U-Boot References: <20120423205937.40742200261@gemini.denx.de> <1335247641-10207-1-git-send-email-daniel.stodden@googlemail.com> <1335247641-10207-2-git-send-email-daniel.stodden@googlemail.com> <20120425000818.GB28921@w500.iskon.local> <1335325799.8304.15.camel@ramone> <20120425123407.E05DA204AE3@gemini.denx.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20120425123407.E05DA204AE3@gemini.denx.de> User-Agent: Mutt/1.5.21 (2010-09-15) X-Gm-Message-State: ALoCoQnk4xBFXFtF0nrOSdW1cQSKUfXrZhWbiKcto1TrwHhdL52gk2d4PbWHgkHTkgB7viJumpIa Cc: U-Boot Subject: Re: [U-Boot] [PATCH] kwboot: Boot Marvell Kirkwood SoCs over a serial link. X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.11 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de Hi Daniel, On Wed, Apr 25, 2012 at 02:34:07PM +0200, Wolfgang Denk wrote: > In message <1335325799.8304.15.camel@ramone> you wrote: > > > > > Why not use something like: > > > > > > BIN_FILES-$(CONFIG_KIRKWOOD) += kwboot$(SFX) > > > > Huh? > > > > I don't know u-boot's build system very well, but normally CONFIG items > > are employed to keep the target lean. Where the best you could ask from > > down-config'd host toolset build would be to not accidentally miss sth? > > This is all host code. > > > > Is building that conditionally really best current practice? If so, > > yeah, we sure can change that. > > > > But would appreciate a clarification. > > It makes no sense to build this tool on systems that will have no use > for it - say, on Power architecture. It only costs build time. This is what I was talking about: That worked for me. Please test this, merge it and resend patch v2. When sending patch v2 please put me in CC because I don't look at the mailing list regularly... Regards, Luka diff --git a/tools/Makefile b/tools/Makefile index 8993fdd..8097d95 100644 --- a/tools/Makefile +++ b/tools/Makefile @@ -72,6 +72,7 @@ BIN_FILES-$(CONFIG_SMDK5250) += mksmdk5250spl$(SFX) BIN_FILES-$(CONFIG_MX28) += mxsboot$(SFX) BIN_FILES-$(CONFIG_NETCONSOLE) += ncb$(SFX) BIN_FILES-$(CONFIG_SHA1_CHECK_UB_IMG) += ubsha1$(SFX) +BIN_FILES-$(CONFIG_KIRKWOOD) += kwboot$(SFX) # Source files which exist outside the tools directory EXT_OBJ_FILES-$(CONFIG_BUILD_ENVCRC) += common/env_embedded.o @@ -101,6 +102,7 @@ OBJ_FILES-$(CONFIG_NETCONSOLE) += ncb.o NOPED_OBJ_FILES-y += os_support.o OBJ_FILES-$(CONFIG_SHA1_CHECK_UB_IMG) += ubsha1.o NOPED_OBJ_FILES-y += ublimage.o +OBJ_FILES-$(CONFIG_KIRKWOOD) += kwboot.o # Don't build by default #ifeq ($(ARCH),ppc) @@ -234,6 +236,10 @@ $(obj)ncb$(SFX): $(obj)ncb.o $(obj)ubsha1$(SFX): $(obj)os_support.o $(obj)sha1.o $(obj)ubsha1.o $(HOSTCC) $(HOSTCFLAGS) $(HOSTLDFLAGS) -o $@ $^ +$(obj)kwboot$(SFX): $(obj)kwboot.o + $(HOSTCC) $(HOSTCFLAGS) $(HOSTLDFLAGS) -o $@ $^ + $(HOSTSTRIP) $@ + # Some of the tool objects need to be accessed from outside the tools directory $(obj)%.o: $(SRCTREE)/common/%.c $(HOSTCC) -g $(HOSTCFLAGS_NOPED) -c -o $@ $<