From patchwork Wed Mar 21 00:34:36 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luka Perkov X-Patchwork-Id: 147912 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 38CCDB6EE6 for ; Wed, 21 Mar 2012 16:37:12 +1100 (EST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 6E6A0280C0; Wed, 21 Mar 2012 06:37:07 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xIq10mmCOVaJ; Wed, 21 Mar 2012 06:37:07 +0100 (CET) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id B2D5A280C1; Wed, 21 Mar 2012 06:37:02 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id BD42128098 for ; Wed, 21 Mar 2012 01:34:49 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2fn9pCvAFoTg for ; Wed, 21 Mar 2012 01:34:48 +0100 (CET) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mail-wg0-f52.google.com (mail-wg0-f52.google.com [74.125.82.52]) by theia.denx.de (Postfix) with ESMTPS id 6C6EE28097 for ; Wed, 21 Mar 2012 01:34:44 +0100 (CET) Received: by wgbgn7 with SMTP id gn7so402761wgb.9 for ; Tue, 20 Mar 2012 17:34:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-type:content-disposition:in-reply-to :user-agent:x-gm-message-state; bh=Wij134Vos8jQm7JU8dCyBgug/WJlwDkTOq6fBz73hqo=; b=Q68ws882O8tAT/ciLnOAj+7AP93B7SuywQAK+XJFBqWI7RDHDNlrr+nfTJCJKed356 FpbJ6ApeZNqlb7RBhXX+VE66YaanaqchUiKVhkj4+rCWi6fDIm+dodKIhFGxZq6c9bOp rfjjX/Rh7SceflWZO3J9xyJaMqVGWpajdcNRprTu7rGv01nzed+EqsVM2ndHRNZemJ4K W+s6jB2Ju5OGY5/XPThJjerb6wR+9Kr9w2FFnSbNBnrAWZZrfg9sFehcYMWnmdFWIVLf 6VKCfdhUY54JDIhMtiAeCDSaDDlRWHbpInJdTNHLWFMIeHrH/uC7K/0gFLcy8XTIcQVW VE9Q== Received: by 10.180.24.4 with SMTP id q4mr33243671wif.7.1332290081722; Tue, 20 Mar 2012 17:34:41 -0700 (PDT) Received: from localhost (213-191-157-231.dhcp.iskon.hr. [213.191.157.231]) by mx.google.com with ESMTPS id 17sm282401wis.0.2012.03.20.17.34.38 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 20 Mar 2012 17:34:40 -0700 (PDT) Date: Wed, 21 Mar 2012 01:34:36 +0100 From: Luka Perkov To: Marek Vasut Message-ID: <20120321003435.GB17427@w500.lan> Mail-Followup-To: Marek Vasut , u-boot@lists.denx.de, dreagle@doukki.net, Wolfgang Denk , prafulla@marvell.com References: <20120317234054.GA21334@w500.lan> <201203191650.52310.marex@denx.de> <20120319224244.GA13300@w500.lan> <201203200748.05455.marex@denx.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <201203200748.05455.marex@denx.de> User-Agent: Mutt/1.5.21 (2010-09-15) X-Gm-Message-State: ALoCoQlBO2b5lpV+0ON+dyt3hla+3jCStBJK5WErJhvmCb/U7OzPlACuGa4nGOIRjQfc0vDx2HsE X-Mailman-Approved-At: Wed, 21 Mar 2012 06:37:00 +0100 Cc: dreagle@doukki.net, u-boot@lists.denx.de Subject: Re: [U-Boot] [PATCH v2] add new board nas62x0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.11 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de Hi Marek, On Tue, Mar 20, 2012 at 07:48:05AM +0100, Marek Vasut wrote: > > > > > > +#define CONFIG_SKIP_LOWLEVEL_INIT /* disable board lowlevel_init > > > > > > */ > > > > > > > > Are you sure you want to skip lowlevel init? It'll break cache setup > > > > > etc. I believe. > > > > > > > > I will retest and send v4 once I get your feedback on other items. > > > > > > Ok, what's the result? From IRC I take it you must define this ... why? > > > > It generates error when building without it: > > > > /home/luka/uboot/arch/arm/cpu/arm926ejs/start.S:393: undefined reference to > > `lowlevel_init' arm-openwrt-linux-ld: BFD (GNU Binutils) 2.22 assertion > > fail elf32-arm.c:13830 > > Define it empty in your arch/arm/cpu/..../kirkwood.c and be done with it ;-) Yes, this seems to fix it: I'll clean this up and resend after we commit this... > > All other kirkwood targets I looked at define CONFIG_SKIP_LOWLEVEL_INIT, > > including the ones mentioned above; here are their configs for > > comparison: > > > > include/configs/dreamplug.h > > include/configs/sheevaplug.h > > include/configs/dockstar.h > > Why do you need to skip it? Does it hang or something? See above. I guess compile error also for other boards. > > This is my proposal - I'll resend v4 and it should be ok to commit > > without fixes for: > > > > 1) IB62x0_OE_LOW and IB62x0_OE_HIGH > > 2) CONFIG_SKIP_LOWLEVEL_INIT > > 3) ifdef indentation > > > > Because fixing the 1) and 2) is more than adding support for this new > > board, and if it was in the same patch I would need to separate it. That > > is a different issue. > > You can wait for Prafulla with #1 and #2, also for #2 check my comment. But we > have two bugs going on for granted here at least and they're not your boards > fault. On the other hand, it'd be cool if you could fix them prior to adding > your board ;-) I'll resend v4 now and work on patches for this stuff later. > > I'll put on my TODO list, and work on this after commit: > > > > * replace tabs with spaces in boards.config > > * look at IB62x0_OE_LOW and IB62x0_OE_HIGH issue > > * look at CONFIG_SKIP_LOWLEVEL_INIT issue For this one we have a patch now :) Thank you Marek. Bye, Luka diff --git a/arch/arm/cpu/arm926ejs/kirkwood/cpu.c b/arch/arm/cpu/arm926ejs/kirkwood/cpu.c index fba5e01..ec2026c 100644 --- a/arch/arm/cpu/arm926ejs/kirkwood/cpu.c +++ b/arch/arm/cpu/arm926ejs/kirkwood/cpu.c @@ -33,6 +33,8 @@ #define BUFLEN 16 +inline void lowlevel_init(void) {} + void reset_cpu(unsigned long ignored) { struct kwcpu_registers *cpureg = diff --git a/include/configs/ib62x0.h b/include/configs/ib62x0.h index 1c4778d..9808a04 100644 --- a/include/configs/ib62x0.h +++ b/include/configs/ib62x0.h @@ -43,7 +43,6 @@ #define CONFIG_KIRKWOOD /* SOC Family Name */ #define CONFIG_KW88F6281 /* SOC Name */ #define CONFIG_MACH_NAS6210 /* Machine type */ -#define CONFIG_SKIP_LOWLEVEL_INIT /* disable board lowlevel_init */ /* * Other required minimal configurations