diff mbox

[U-Boot,2/2] odroid-c2: support storing the uboot environment in eMMC

Message ID 1b0d0270-1f6e-da77-5fe3-f6d15383ca6a@gmail.com
State Deferred
Delegated to: Jaehoon Chung
Headers show

Commit Message

Heiner Kallweit April 14, 2017, 8:26 a.m. UTC
Support storing uboot environment in eMMC.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
 include/configs/meson-gxbb-common.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Andreas Färber April 14, 2017, 1:40 p.m. UTC | #1
Am 14.04.2017 um 10:26 schrieb Heiner Kallweit:
> Support storing uboot environment in eMMC.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
>  include/configs/meson-gxbb-common.h | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/include/configs/meson-gxbb-common.h b/include/configs/meson-gxbb-common.h
> index cc2b5b6..5951263 100644
> --- a/include/configs/meson-gxbb-common.h
> +++ b/include/configs/meson-gxbb-common.h
> @@ -11,8 +11,10 @@
>  #define CONFIG_CPU_ARMV8
>  #define CONFIG_REMAKE_ELF
>  #define CONFIG_NR_DRAM_BANKS		1
> -#define CONFIG_ENV_IS_NOWHERE		1
> +#define CONFIG_ENV_IS_IN_MMC		1
> +#define CONFIG_SYS_MMC_ENV_DEV		0

Apart from relying on the modified device order, have you tested this
without eMMC?

Regards,
Andreas

>  #define CONFIG_ENV_SIZE			0x2000
> +#define CONFIG_ENV_OFFSET		(SZ_1M - CONFIG_ENV_SIZE)
>  #define CONFIG_SYS_MAXARGS		32
>  #define CONFIG_SYS_MALLOC_LEN		(32 << 20)
>  #define CONFIG_SYS_CBSIZE		1024
>
Heiner Kallweit April 14, 2017, 3:48 p.m. UTC | #2
Am 14.04.2017 um 15:40 schrieb Andreas Färber:
> Am 14.04.2017 um 10:26 schrieb Heiner Kallweit:
>> Support storing uboot environment in eMMC.
>>
>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>> ---
>>  include/configs/meson-gxbb-common.h | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/include/configs/meson-gxbb-common.h b/include/configs/meson-gxbb-common.h
>> index cc2b5b6..5951263 100644
>> --- a/include/configs/meson-gxbb-common.h
>> +++ b/include/configs/meson-gxbb-common.h
>> @@ -11,8 +11,10 @@
>>  #define CONFIG_CPU_ARMV8
>>  #define CONFIG_REMAKE_ELF
>>  #define CONFIG_NR_DRAM_BANKS		1
>> -#define CONFIG_ENV_IS_NOWHERE		1
>> +#define CONFIG_ENV_IS_IN_MMC		1
>> +#define CONFIG_SYS_MMC_ENV_DEV		0
> 
> Apart from relying on the modified device order, have you tested this
> without eMMC?
> 
For testing I switched CONFIG_SYS_MMC_ENV_DEV to another number.
U-Boot complained about the non-existing device and used the
compiled-in default environment.
I didn't test storing environment on SD card.

Rgds, Heiner

> Regards,
> Andreas
> 
>>  #define CONFIG_ENV_SIZE			0x2000
>> +#define CONFIG_ENV_OFFSET		(SZ_1M - CONFIG_ENV_SIZE)
>>  #define CONFIG_SYS_MAXARGS		32
>>  #define CONFIG_SYS_MALLOC_LEN		(32 << 20)
>>  #define CONFIG_SYS_CBSIZE		1024
>>
> 
>
diff mbox

Patch

diff --git a/include/configs/meson-gxbb-common.h b/include/configs/meson-gxbb-common.h
index cc2b5b6..5951263 100644
--- a/include/configs/meson-gxbb-common.h
+++ b/include/configs/meson-gxbb-common.h
@@ -11,8 +11,10 @@ 
 #define CONFIG_CPU_ARMV8
 #define CONFIG_REMAKE_ELF
 #define CONFIG_NR_DRAM_BANKS		1
-#define CONFIG_ENV_IS_NOWHERE		1
+#define CONFIG_ENV_IS_IN_MMC		1
+#define CONFIG_SYS_MMC_ENV_DEV		0
 #define CONFIG_ENV_SIZE			0x2000
+#define CONFIG_ENV_OFFSET		(SZ_1M - CONFIG_ENV_SIZE)
 #define CONFIG_SYS_MAXARGS		32
 #define CONFIG_SYS_MALLOC_LEN		(32 << 20)
 #define CONFIG_SYS_CBSIZE		1024