From patchwork Fri Jun 26 12:39:19 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sagar Shrikant Kadam X-Patchwork-Id: 1317625 X-Patchwork-Delegate: uboot@andestech.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=sifive.com header.i=@sifive.com header.a=rsa-sha256 header.s=selector1 header.b=Xx57QoUT; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 49tc1Q4q7Xz9sRN for ; Fri, 26 Jun 2020 22:40:42 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 34F898179D; Fri, 26 Jun 2020 14:40:09 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=sifive.com header.i=@sifive.com header.b="Xx57QoUT"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 45A6380390; Fri, 26 Jun 2020 14:39:58 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FORGED_SPF_HELO,MSGID_FROM_MTA_HEADER, SPF_HELO_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on20608.outbound.protection.outlook.com [IPv6:2a01:111:f400:7eaa::608]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 43AB380390 for ; Fri, 26 Jun 2020 14:39:50 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sagar.kadam@sifive.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M75L2Gin9b2XL0nfnkGtcKUgudCa9XAKG2LeQo4IHTEMk81s9KUaY5T6Pfs7ebMN//kNj6ifeoLWvSxkcwiPGWQArDIor5hUHzzZk5+2duLFWItkjTVCAzKK+C189cWV+qFNZM0uaVMBj4BK3qVREccoTj+1xNUN0Awz5yaUEjYDjabTQzVxqvgUiHlSOamiZDr34H79O3GmfUqhzH5Uj13WjgS3EzSPvOjPuqgDIpNk/T4rvHNt4PIAEuUGXjlB0k/cdXDsP1C4xj/cosHIEqu1wZrc3Ae1QzJgm3Y5ebv1Oya2LfSbvV5KnfKWFmyNa6bGst74d+X1Zl5g/A7Wzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=woIvGn4AL6ZDqJaADSNbBp1v1dcAuMA3sOsud9AXni8=; b=fWpnCoywg5bI8CQelPladsejd633pm6DF49AMjq5vrIE0JhLHZzTgE4nKpCVKaLf6Jtd3+0j+SfFZ5to42uEoTXepGvnWaXQcn5zd4W9Q7kLO/KKS46c4Bn+ZEdktnoAOot4W1leFQ4YoNryqmWMDyj86UvigthN+zLwSpon/qTw0TXn9fM9KBA5qne79L8NYP7FWdztZyP9UHb9qpt3KhWMcKn4+BMUwcbTocm2pnwAQqj1g1CA6YTA/riHoRt0+WNqrVXHrtZ7juLukoYyBN042GDVMWFCYw1qS/AtlebhIebi8To4nJNQLYndFWBwJe3Opaka/TrdhEaFpvh+5A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=sifive.com; dmarc=pass action=none header.from=sifive.com; dkim=pass header.d=sifive.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=woIvGn4AL6ZDqJaADSNbBp1v1dcAuMA3sOsud9AXni8=; b=Xx57QoUTBN72Nw9CCliz2D/v1KIMiF7auwuCozjZPXvbA1iqXZ/MbMRHlf0Sm9CPefHf1nnXjcy3H37e5mmwaBRFKZDN0cW2nOgmibSUM2KeIaPqN9kWswDty6bQvSvFReBv0z3QWFwOOPXv54xnakP7qlXbGjW17D+nK/poLe8= Authentication-Results: lists.denx.de; dkim=none (message not signed) header.d=none;lists.denx.de; dmarc=none action=none header.from=sifive.com; Received: from BN8PR13MB2611.namprd13.prod.outlook.com (2603:10b6:408:81::17) by BN6PR13MB1651.namprd13.prod.outlook.com (2603:10b6:404:142::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.10; Fri, 26 Jun 2020 12:39:36 +0000 Received: from BN8PR13MB2611.namprd13.prod.outlook.com ([fe80::c1d9:f4ee:80ab:de83]) by BN8PR13MB2611.namprd13.prod.outlook.com ([fe80::c1d9:f4ee:80ab:de83%6]) with mapi id 15.20.3153.010; Fri, 26 Jun 2020 12:39:36 +0000 From: Sagar Shrikant Kadam To: u-boot@lists.denx.de Cc: rick@andestech.com, bin.meng@windriver.com, jagan@amarulasolutions.com, pragnesh.patel@sifive.com, anup.patel@wdc.com, sjg@chromium.org, ye.li@nxp.com, peng.fan@nxp.com, seanga2@gmail.com, Sagar Shrikant Kadam Subject: [PATCH v6 2/4] uclass: cpu: fix to display proper CPU features Date: Fri, 26 Jun 2020 05:39:19 -0700 Message-Id: <1593175161-26278-3-git-send-email-sagar.kadam@sifive.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1593175161-26278-1-git-send-email-sagar.kadam@sifive.com> References: <1593175161-26278-1-git-send-email-sagar.kadam@sifive.com> X-ClientProxiedBy: BY3PR05CA0027.namprd05.prod.outlook.com (2603:10b6:a03:254::32) To BN8PR13MB2611.namprd13.prod.outlook.com (2603:10b6:408:81::17) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from gamma07.internal.sifive.com (64.62.193.194) by BY3PR05CA0027.namprd05.prod.outlook.com (2603:10b6:a03:254::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.3131.12 via Frontend Transport; Fri, 26 Jun 2020 12:39:35 +0000 X-Mailer: git-send-email 2.7.4 X-Originating-IP: [64.62.193.194] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d76a5cc6-c783-4f58-c6e2-08d819cdfc13 X-MS-TrafficTypeDiagnostic: BN6PR13MB1651: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-Forefront-PRVS: 0446F0FCE1 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KN6BHYumINb7FSSXrXXhUYp6CxMjvcQpMN8S4mWCVPFTjSyrOQA0w7895yiTYaqmyaQm7QOwTeYWN4QKhmI2Xzi2gNP2pqy2kAp5F00uJcXBLd5wPBW3C6L0w8F9OHUCPU583EYdRGlfalxLC59AcDVPZ5XHzo9m8SaTdJOAedULuW5KeAB6ofJNB7gQi8YtaDXz3aPLNwCQs6sW7FnaeTmI/RK6WKBAeCCY0zQ0jhEkBprN+ACFdl4GVrBqj/7jAuwHFCcLMBYbOFxlTwH3FchQXR/npWGbpskYbsPdU2YLHktZ8NJ+HiqIvPBJnFQzxHF3/67KdwiP/GtjljoaDQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR13MB2611.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(346002)(396003)(136003)(39850400004)(366004)(376002)(478600001)(6666004)(186003)(16526019)(5660300002)(107886003)(36756003)(6486002)(66946007)(316002)(86362001)(4326008)(8936002)(6916009)(52116002)(956004)(26005)(7696005)(8676002)(66556008)(2616005)(66476007)(2906002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: 092bP4h68F5n4FwnBuzdRzhn/mZP+S0kGMuDxwQSbMVuJmVg8phirV5lFPJuKr3R4Tn0G2cgcEMc7gf9s8VOJdMViV907Erbov+g3LEIRLiSMhc653z+dy4YNiiiMnUPHtEzwgLf9L6N/qy5OQBCxVz5dziE5u26gTu7t8VTfA8Fkt6AKsFo54SYSwFVr+tIf6cZXzJYeYWvOT2ccfuy0Q1zlL71PJytDzZ4zoWMUELUhXNZN5MUxE/9e/YtWkQzIeiAerBveFHjzLzn/3nEyRDI3lQVDfeWDXAe2cdfO0Nd64fGLwIumE1BD8o5dQCctAOzy2iharJjvnf+YlURkZIPctCDZmIwt+UqMUXccHp1bIlmKfOQjvwztGzuD2RnQYqOQgNULFG2dx39JjS6zKhBXV0we+l27mZsx0MMQkRUAjbTlEjZnNAzeOWLyjEnyh2pCeb17GIovq0BmBSRsrtH0GUwzyEUCce2nhUQwlBYdEe37yNahABRald8XUqG X-OriginatorOrg: sifive.com X-MS-Exchange-CrossTenant-Network-Message-Id: d76a5cc6-c783-4f58-c6e2-08d819cdfc13 X-MS-Exchange-CrossTenant-AuthSource: BN8PR13MB2611.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jun 2020 12:39:36.4247 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 22f88e9d-ae0d-4ed9-b984-cdc9be1529f1 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: d0Y3SiRB3VYvn3X/Or36tc7ZPcSH6PeIExaL6HHGNBAc87KihfoL13BaOs69Ly7n1xcpcO3arwL2aHVgl6rIDw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR13MB1651 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.30rc1 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.2 at phobos.denx.de X-Virus-Status: Clean The cmd "cpu detail" fetches uninitialized cpu feature information and thus displays wrong / inconsitent details as below. For eg: FU540-C000 doesn't have any microcode, yet the cmd display's it. => cpu detail 1: cpu@1 rv64imafdc ID = 1, freq = 999.100 MHz: L1 cache, MMU, Microcode, Device ID Microcode version 0x0 Device ID 0x0 2: cpu@2 rv64imafdc ID = 2, freq = 999.100 MHz: L1 cache, MMU, Microcode, Device ID Microcode version 0x0 Device ID 0x0 3: cpu@3 rv64imafdc ID = 3, freq = 999.100 MHz: L1 cache, MMU, Microcode, Device ID Microcode version 0x0 Device ID 0x0 4: cpu@4 rv64imafdc ID = 4, freq = 999.100 MHz: L1 cache, MMU, Microcode, Device ID Microcode version 0x0 Device ID 0x0 The L1 cache or MMU entry seen above is also displayed inconsistently. So initialize cpu information to zero into cpu-uclass itself so that similar issues can be avoided for other CPU drivers. We now see correct features as: => cpu detail 1: cpu@1 rv64imafdc ID = 1, freq = 999.100 MHz 2: cpu@2 rv64imafdc ID = 2, freq = 999.100 MHz 3: cpu@3 rv64imafdc ID = 3, freq = 999.100 MHz 4: cpu@4 rv64imafdc ID = 4, freq = 999.100 MHz Signed-off-by: Sagar Shrikant Kadam Reviewed-by: Pragnesh Patel Reviewed-by: Bin Meng --- drivers/cpu/cpu-uclass.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/cpu/cpu-uclass.c b/drivers/cpu/cpu-uclass.c index 7418c26..9f4a8fd 100644 --- a/drivers/cpu/cpu-uclass.c +++ b/drivers/cpu/cpu-uclass.c @@ -83,6 +83,9 @@ int cpu_get_info(struct udevice *dev, struct cpu_info *info) { struct cpu_ops *ops = cpu_get_ops(dev); + /* Init cpu_info to 0 */ + memset(info, 0, sizeof(struct cpu_info)); + if (!ops->get_info) return -ENOSYS;